)]}'
{"patrole_tempest_plugin/tests/api/image/test_images_rbac.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a57645b9b0d0b21aaafb46012ee9b53b3aff8ed1","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @rbac_rule_validation.action(component\u003d\"Image\", service\u003d\"glance\","},{"line_number":44,"context_line":"                                 rule\u003d\"add_image\")"},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u00270f148510-63bf-11e6-b348-080027d0d606\u0027)"},{"line_number":46,"context_line":"    def test_create_image(self):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        \"\"\"Create Image Test"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_3e891976","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":69},"updated":"2017-01-16 18:53:32.000000000","message":"nit: it is nice to separate this part for easy review with line 20/21 change.","commit_id":"94138aaffddef6935f9385ec194c871da6d6c93b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a57645b9b0d0b21aaafb46012ee9b53b3aff8ed1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            image_file \u003d moves.cStringIO(data_utils.random_bytes())"},{"line_number":82,"context_line":"            self.client.store_image_file(body[\u0027id\u0027], image_file)"},{"line_number":83,"context_line":"        except ValueError as e:"},{"line_number":84,"context_line":"            \u0027\u0027\u0027ValueError is being thrown when role doesn\u0027t have permission to"},{"line_number":85,"context_line":"            upload file when creating an image\u0027\u0027\u0027"},{"line_number":86,"context_line":"            LOG.info(\"ValueError is being thrown when role doesn\u0027t have \""},{"line_number":87,"context_line":"                     \"permission to upload file during image creation\")"},{"line_number":88,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_3e0cb9ec","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":49},"updated":"2017-01-16 18:53:32.000000000","message":"Humm, I am not sure the reason here..\n\nAll operations of image_client_v2 should be based on REST API and the exception should be part of tempest.lib\u0027s exceptions which are based on ClientRestClientException.\nWe should be able to check the error status_code(like HTTP400, etc).","commit_id":"94138aaffddef6935f9385ec194c871da6d6c93b"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"d88b740345a1c203aa137c2d2914457b5758e749","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            image_file \u003d moves.cStringIO(data_utils.random_bytes())"},{"line_number":82,"context_line":"            self.client.store_image_file(body[\u0027id\u0027], image_file)"},{"line_number":83,"context_line":"        except ValueError as e:"},{"line_number":84,"context_line":"            \u0027\u0027\u0027ValueError is being thrown when role doesn\u0027t have permission to"},{"line_number":85,"context_line":"            upload file when creating an image\u0027\u0027\u0027"},{"line_number":86,"context_line":"            LOG.info(\"ValueError is being thrown when role doesn\u0027t have \""},{"line_number":87,"context_line":"                     \"permission to upload file during image creation\")"},{"line_number":88,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_078c0c7e","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":49},"in_reply_to":"7a3c09a3_3e0cb9ec","updated":"2017-01-16 19:58:01.000000000","message":"This was originally written for a different version of Glance.  You are correct, this exception handling is no longer needed.","commit_id":"94138aaffddef6935f9385ec194c871da6d6c93b"}]}