)]}'
{"patrole_tempest_plugin/tests/api/network/test_networks_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                             enable_dhcp\u003dFalse)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _delete_network(self, network):"},{"line_number":62,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":63,"context_line":"        self.networks_client.delete_network(network[\u0027id\u0027])"},{"line_number":64,"context_line":"        if network in self.networks:"},{"line_number":65,"context_line":"            self.networks.remove(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_ae4d579b","line":62,"range":{"start_line":62,"start_character":55,"end_line":62,"end_character":61},"updated":"2017-01-18 18:58:28.000000000","message":"it exists","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _delete_network(self, network):"},{"line_number":62,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":63,"context_line":"        self.networks_client.delete_network(network[\u0027id\u0027])"},{"line_number":64,"context_line":"        if network in self.networks:"},{"line_number":65,"context_line":"            self.networks.remove(network)"},{"line_number":66,"context_line":"        for subnet in self.subnets:"},{"line_number":67,"context_line":"            if subnet[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":68,"context_line":"                self.subnets.remove(subnet)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_c2bd12d9","line":66,"range":{"start_line":64,"start_character":8,"end_line":66,"end_character":35},"updated":"2017-01-18 18:58:28.000000000","message":"I don\u0027t see where self.networks or self.subnets are defined or where they\u0027re being populated. If it\u0027s somewhere in another file, then disregard this.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"24f06666d395411bbc3570ef2845a9547b505927","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _delete_network(self, network):"},{"line_number":62,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":63,"context_line":"        self.networks_client.delete_network(network[\u0027id\u0027])"},{"line_number":64,"context_line":"        if network in self.networks:"},{"line_number":65,"context_line":"            self.networks.remove(network)"},{"line_number":66,"context_line":"        for subnet in self.subnets:"},{"line_number":67,"context_line":"            if subnet[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":68,"context_line":"                self.subnets.remove(subnet)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_e3b4d083","line":66,"range":{"start_line":64,"start_character":8,"end_line":66,"end_character":35},"in_reply_to":"7a3c09a3_c2bd12d9","updated":"2017-01-18 20:00:10.000000000","message":"self.networks and self.subnets are part of the BaseNetworkTest that this class extends.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        \"\"\""},{"line_number":182,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":183,"context_line":"        self._create_network(provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":184,"context_line":"                             provider_segmentation_id\u003d200)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def _update_network(self,"},{"line_number":187,"context_line":"                        admin\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_519e5664","line":184,"range":{"start_line":184,"start_character":54,"end_line":184,"end_character":57},"updated":"2017-01-18 18:58:28.000000000","message":"If possible, this could be data_utils.rand_int_id(): https://github.com/openstack/tempest-lib/blob/master/tempest_lib/common/utils/data_utils.py","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self._create_network(provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":184,"context_line":"                             provider_segmentation_id\u003d200)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def _update_network(self,"},{"line_number":187,"context_line":"                        admin\u003dNone,"},{"line_number":188,"context_line":"                        shared_network\u003dNone,"},{"line_number":189,"context_line":"                        router_external\u003dNone,"},{"line_number":190,"context_line":"                        router_private\u003dNone,"},{"line_number":191,"context_line":"                        segments\u003dNone):"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # update a network that has been created during class setup"},{"line_number":194,"context_line":"        net_id \u003d self.admin_network[\u0027id\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        post_body \u003d {}"},{"line_number":197,"context_line":"        updated_network \u003d None"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if admin is not None:"},{"line_number":200,"context_line":"            post_body[\u0027admin_state_up\u0027] \u003d admin"},{"line_number":201,"context_line":"        elif shared_network is not None:"},{"line_number":202,"context_line":"            post_body[\u0027shared\u0027] \u003d shared_network"},{"line_number":203,"context_line":"        elif router_external is not None:"},{"line_number":204,"context_line":"            post_body[\u0027router:external\u0027] \u003d router_external"},{"line_number":205,"context_line":"        elif segments is not None:"},{"line_number":206,"context_line":"            post_body[\u0027segments\u0027] \u003d segments"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            return updated_network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        body \u003d self.networks_client.update_network(net_id, **post_body)"},{"line_number":211,"context_line":"        updated_network \u003d body[\u0027network\u0027]"},{"line_number":212,"context_line":"        return updated_network"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","},{"line_number":215,"context_line":"                                 rule\u003d\"update_network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_113e8e29","line":212,"range":{"start_line":186,"start_character":0,"end_line":212,"end_character":30},"updated":"2017-01-18 18:58:28.000000000","message":"I think it would be better to put this up with _create_network and _delete_network.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":224,"context_line":"        updated_network \u003d self._update_network(admin\u003dFalse)"},{"line_number":225,"context_line":"        self.assertEqual(updated_network[\u0027admin_state_up\u0027], False)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Revert back to True"},{"line_number":228,"context_line":"        updated_network \u003d self._update_network(admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9110bead","line":225,"range":{"start_line":225,"start_character":8,"end_line":225,"end_character":66},"updated":"2017-01-18 18:58:28.000000000","message":"assertFalse","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Revert back to True"},{"line_number":228,"context_line":"        updated_network \u003d self._update_network(admin\u003dTrue)"},{"line_number":229,"context_line":"        self.assertEqual(updated_network[\u0027admin_state_up\u0027], True)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","},{"line_number":232,"context_line":"                                 rule\u003d\"update_network:shared\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_d10a4679","line":229,"range":{"start_line":229,"start_character":8,"end_line":229,"end_character":65},"updated":"2017-01-18 18:58:28.000000000","message":"assertTrue","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":241,"context_line":"        updated_network \u003d self._update_network(shared_network\u003dTrue)"},{"line_number":242,"context_line":"        self.assertEqual(updated_network[\u0027shared\u0027], True)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # Revert back to False"},{"line_number":245,"context_line":"        updated_network \u003d self._update_network(shared_network\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9177de07","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":57},"updated":"2017-01-18 18:58:28.000000000","message":"assertTrue","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # Revert back to False"},{"line_number":245,"context_line":"        updated_network \u003d self._update_network(shared_network\u003dFalse)"},{"line_number":246,"context_line":"        self.assertEqual(updated_network[\u0027shared\u0027], False)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","},{"line_number":249,"context_line":"                                 rule\u003d\"update_network:router:external\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_f18662da","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":58},"updated":"2017-01-18 18:58:28.000000000","message":"assertFalse","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":258,"context_line":"        updated_network \u003d self._update_network(router_external\u003dTrue)"},{"line_number":259,"context_line":"        self.assertEqual(updated_network[\u0027router:external\u0027], True)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Revert back to False"},{"line_number":262,"context_line":"        updated_network \u003d self._update_network(router_external\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_62c7fe64","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":66},"updated":"2017-01-18 18:58:28.000000000","message":"assertTrue","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Revert back to False"},{"line_number":262,"context_line":"        updated_network \u003d self._update_network(router_external\u003dFalse)"},{"line_number":263,"context_line":"        self.assertEqual(updated_network[\u0027router:external\u0027], False)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","},{"line_number":266,"context_line":"                                 rule\u003d\"get_network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_51765607","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":67},"updated":"2017-01-18 18:58:28.000000000","message":"assertFalse","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        showed_net \u003d body[\u0027network\u0027]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if len(showed_net) \u003d\u003d 0:"},{"line_number":310,"context_line":"            raise rbac_exceptions.RbacActionFailed"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","},{"line_number":313,"context_line":"                                 rule\u003d\"get_network:provider:physical_network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_71f8b24a","line":310,"range":{"start_line":310,"start_character":12,"end_line":310,"end_character":50},"updated":"2017-01-18 18:58:28.000000000","message":"Maybe provide explanation why this is being thrown.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d179c6a0c6870f959dd4f5857dd89381cfc3774c","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        self.assertRaises(lib_exc.NotFound, self.subnets_client.show_subnet,"},{"line_number":429,"context_line":"                          subnet[\u0027id\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        self.subnets.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_42912252","line":431,"range":{"start_line":431,"start_character":8,"end_line":431,"end_character":26},"updated":"2017-01-18 18:58:28.000000000","message":"Again, I don\u0027t see where this is defined or populated.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"24f06666d395411bbc3570ef2845a9547b505927","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        self.assertRaises(lib_exc.NotFound, self.subnets_client.show_subnet,"},{"line_number":429,"context_line":"                          subnet[\u0027id\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        self.subnets.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9568a389","line":431,"range":{"start_line":431,"start_character":8,"end_line":431,"end_character":26},"in_reply_to":"7a3c09a3_42912252","updated":"2017-01-18 20:00:10.000000000","message":"see above.","commit_id":"ce4a7e3096577b3936f23e8d1bda958cf9064d50"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"48dacd36b3f8dcae1ef49256d2d0d65ad6e02337","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_df906298","line":16,"updated":"2017-01-19 17:55:18.000000000","message":"We\u0027re using oslo_log","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"48dacd36b3f8dcae1ef49256d2d0d65ad6e02337","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class RbacNetworksTest(base.BaseNetworkRbacTest):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_ffe43e3c","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":47},"updated":"2017-01-19 17:55:18.000000000","message":"Shouldn\u0027t this be inheriting from network_base?","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"48dacd36b3f8dcae1ef49256d2d0d65ad6e02337","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(RbacNetworksTest, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.networks_client \u003d cls.os.networks_client"},{"line_number":40,"context_line":"        cls.subnet_client \u003d cls.os.subnets_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_7fcf6eb0","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":49},"updated":"2017-01-19 17:55:18.000000000","message":"These setups are already done in the base class","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"48dacd36b3f8dcae1ef49256d2d0d65ad6e02337","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def resource_setup(cls):"},{"line_number":44,"context_line":"        super(RbacNetworksTest, cls).resource_setup()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        network_name \u003d data_utils.rand_name(\u0027rbac-admin-network-\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":49,"context_line":"        body \u003d cls.networks_client.create_network(**post_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_bf48f62e","line":46,"range":{"start_line":46,"start_character":63,"end_line":46,"end_character":64},"updated":"2017-01-19 17:55:18.000000000","message":"If making the change on L78, don\u0027t forget to make it here too.","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d52aea5dac2d3ece6df735ad5e02eecec264046f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                        provider_physical_network\u003dNone,"},{"line_number":76,"context_line":"                        provider_segmentation_id\u003dNone):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        network_name \u003d data_utils.rand_name(\u0027test-network-\u0027)"},{"line_number":79,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if shared is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_9a77d0d3","line":78,"range":{"start_line":78,"start_character":23,"end_line":78,"end_character":60},"updated":"2017-01-19 16:19:21.000000000","message":"nit: Not really important, but you don\u0027t need to tack on \u0027-\u0027 at the end of \u0027test-network\u0027. rand_name already does that for you: https://github.com/openstack/tempest-lib/blob/master/tempest_lib/common/utils/data_utils.py","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d52aea5dac2d3ece6df735ad5e02eecec264046f","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if len(showed_net) \u003d\u003d 0:"},{"line_number":310,"context_line":"            # Catches successful return (200) but with no showed networks."},{"line_number":311,"context_line":"            LOG.info(\"No networks were returned by show_network\")"},{"line_number":312,"context_line":"            raise rbac_exceptions.RbacActionFailed"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_5df3a20a","line":311,"range":{"start_line":311,"start_character":16,"end_line":311,"end_character":20},"updated":"2017-01-19 16:19:21.000000000","message":"nit: Can we make this error since an error is being thrown? You could then do LOG.error(_LE(\u0027error message here\u0027)). See this: http://docs.openstack.org/developer/oslo.i18n/guidelines.html\n\nAlso, I see why you added a LOG.info -- because rbac_exceptions current doesn\u0027t have custom constructor that takes in custom message. I think this should be fixed in another patch. \n\n\"Rbac action failed\" just isn\u0027t specific enough for a testing framework.","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"80b3036fd35cf47ffa1d5f4f984280aedb248945","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if len(showed_net) \u003d\u003d 0:"},{"line_number":310,"context_line":"            # Catches successful return (200) but with no showed networks."},{"line_number":311,"context_line":"            LOG.info(\"No networks were returned by show_network\")"},{"line_number":312,"context_line":"            raise rbac_exceptions.RbacActionFailed"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @rbac_rule_validation.action(component\u003d\"Network\", service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_ae136a5b","line":311,"range":{"start_line":311,"start_character":16,"end_line":311,"end_character":20},"in_reply_to":"5a3905b3_5df3a20a","updated":"2017-01-19 16:55:56.000000000","message":"This exception is intended for cases where endpoints do something other than return a 403 when the RBAC action we are trying to test fails.  This does not indicate that the test has failed, which is why it is .info rather than .error.","commit_id":"db8451db15d09eb15412286ef4c86631fe767b0e"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"0f8eb0cf9ebb1c858b015e9c846cc246b488c8f6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        super(RbacNetworksTest, cls).resource_setup()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        network_name \u003d data_utils.rand_name(\u0027rbac-admin-network-\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":46,"context_line":"        body \u003d cls.networks_client.create_network(**post_body)"},{"line_number":47,"context_line":"        cls.admin_network \u003d body[\u0027network\u0027]"},{"line_number":48,"context_line":"        cls.networks.append(cls.admin_network)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_fd07a519","line":46,"range":{"start_line":43,"start_character":0,"end_line":46,"end_character":62},"updated":"2017-01-20 19:26:51.000000000","message":"Can be replaced with cls.create_network() (would still require added cleanup -- where is this being cleaned up, by the way?)","commit_id":"45497629ed84c749be76a58191b099523b4768d8"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"7598c92c7e3837dd53449d701b14188e6823605b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        super(RbacNetworksTest, cls).resource_setup()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        network_name \u003d data_utils.rand_name(\u0027rbac-admin-network-\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":46,"context_line":"        body \u003d cls.networks_client.create_network(**post_body)"},{"line_number":47,"context_line":"        cls.admin_network \u003d body[\u0027network\u0027]"},{"line_number":48,"context_line":"        cls.networks.append(cls.admin_network)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_a0a3324e","line":46,"range":{"start_line":43,"start_character":0,"end_line":46,"end_character":62},"in_reply_to":"5a3905b3_fd07a519","updated":"2017-01-20 19:39:41.000000000","message":"It is added to cls.networks, which is cleaned up in resource_cleanup of the Tempest BaseNetworkTest.","commit_id":"45497629ed84c749be76a58191b099523b4768d8"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"0f8eb0cf9ebb1c858b015e9c846cc246b488c8f6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                        provider_physical_network\u003dNone,"},{"line_number":73,"context_line":"                        provider_segmentation_id\u003dNone):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        network_name \u003d data_utils.rand_name(\u0027test-network-\u0027)"},{"line_number":76,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if shared is not None:"},{"line_number":79,"context_line":"            post_body[\u0027shared\u0027] \u003d shared"},{"line_number":80,"context_line":"        if router_external is not None:"},{"line_number":81,"context_line":"            post_body[\u0027router:external\u0027] \u003d router_external"},{"line_number":82,"context_line":"        if router_private is not None:"},{"line_number":83,"context_line":"            post_body[\u0027router:private\u0027] \u003d router_private"},{"line_number":84,"context_line":"        if provider_network_type is not None:"},{"line_number":85,"context_line":"            post_body[\u0027provider:network_type\u0027] \u003d provider_network_type"},{"line_number":86,"context_line":"        if provider_physical_network is not None:"},{"line_number":87,"context_line":"            post_body[\u0027provider:physical_network\u0027] \u003d provider_physical_network"},{"line_number":88,"context_line":"        if provider_segmentation_id is not None:"},{"line_number":89,"context_line":"            post_body[\u0027provider:segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        body \u003d self.networks_client.create_network(**post_body)"},{"line_number":92,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_60786a90","line":91,"range":{"start_line":75,"start_character":0,"end_line":91,"end_character":63},"updated":"2017-01-20 19:26:51.000000000","message":"This can all be replaced with cls.create_network and pass arguments with **kwargs","commit_id":"45497629ed84c749be76a58191b099523b4768d8"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"7598c92c7e3837dd53449d701b14188e6823605b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                        provider_physical_network\u003dNone,"},{"line_number":73,"context_line":"                        provider_segmentation_id\u003dNone):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        network_name \u003d data_utils.rand_name(\u0027test-network-\u0027)"},{"line_number":76,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if shared is not None:"},{"line_number":79,"context_line":"            post_body[\u0027shared\u0027] \u003d shared"},{"line_number":80,"context_line":"        if router_external is not None:"},{"line_number":81,"context_line":"            post_body[\u0027router:external\u0027] \u003d router_external"},{"line_number":82,"context_line":"        if router_private is not None:"},{"line_number":83,"context_line":"            post_body[\u0027router:private\u0027] \u003d router_private"},{"line_number":84,"context_line":"        if provider_network_type is not None:"},{"line_number":85,"context_line":"            post_body[\u0027provider:network_type\u0027] \u003d provider_network_type"},{"line_number":86,"context_line":"        if provider_physical_network is not None:"},{"line_number":87,"context_line":"            post_body[\u0027provider:physical_network\u0027] \u003d provider_physical_network"},{"line_number":88,"context_line":"        if provider_segmentation_id is not None:"},{"line_number":89,"context_line":"            post_body[\u0027provider:segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        body \u003d self.networks_client.create_network(**post_body)"},{"line_number":92,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_60c06ae1","line":91,"range":{"start_line":75,"start_character":0,"end_line":91,"end_character":63},"in_reply_to":"5a3905b3_60786a90","updated":"2017-01-20 19:39:41.000000000","message":"Agreed.","commit_id":"45497629ed84c749be76a58191b099523b4768d8"}]}
