)]}'
{"patrole_tempest_plugin/tests/api/volume/test_volume_metadata_rbac.py":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"c9fda0bfc8622d1134adbdd3dfcd5641385711b3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":37,"context_line":"        super(VolumeMetadataRbacTest, self).tearDown()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _create_volume(self):"},{"line_number":40,"context_line":"        # Create a volume"},{"line_number":41,"context_line":"        volume \u003d self.create_volume()"},{"line_number":42,"context_line":"        return volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _add_metadata(self, volume):"},{"line_number":45,"context_line":"        # Create metadata for the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_5ff49486","line":42,"range":{"start_line":39,"start_character":4,"end_line":42,"end_character":21},"updated":"2017-01-18 21:59:06.000000000","message":"This seems pointless.  What does this gain us over calling  self.create_volume directly in the test.","commit_id":"ea5c26f547a61cecea630fcd98ccfb8fdcbc7b93"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"c9fda0bfc8622d1134adbdd3dfcd5641385711b3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            self._add_metadata(volume)"},{"line_number":61,"context_line":"        except exceptions.NotFound as e:"},{"line_number":62,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @rbac_rule_validation.action(component\u003d\"Volume\",  service\u003d\"cinder\","},{"line_number":65,"context_line":"                                 rule\u003d\"volume:get\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7f4870cd","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":53},"updated":"2017-01-18 21:59:06.000000000","message":"Do we need these?  If yes, add an explanation of why.  If no, remove.","commit_id":"ea5c26f547a61cecea630fcd98ccfb8fdcbc7b93"}]}