)]}'
{"patrole_tempest_plugin/tests/api/murano/application_catalog/test_categories.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8b25b41328273717b76250af11d35b4dfd457a1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class RbacCategoriesTest(base.BaseMuranoAdminRbacTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":30,"context_line":"        super(RbacCategoriesTest, self).setUp()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d973324c","line":29,"updated":"2017-01-25 22:31:56.000000000","message":"Why is this being called?","commit_id":"eddf2cf36135cbe12616c7b71abfb4075ef7acfa"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8b25b41328273717b76250af11d35b4dfd457a1b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":42,"context_line":"        category \u003d self.application_catalog_client.get_category("},{"line_number":43,"context_line":"            self.category[\u0027id\u0027])"},{"line_number":44,"context_line":"        self.assertEqual(self.category[\u0027id\u0027], category[\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(self.category[\u0027name\u0027], category[\u0027name\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @rbac_rule_validation.action(service\u003d\"murano\","},{"line_number":48,"context_line":"                                 rule\u003d\"list_categories\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d9aa5270","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":65},"updated":"2017-01-25 22:31:56.000000000","message":"Are these necessary?","commit_id":"eddf2cf36135cbe12616c7b71abfb4075ef7acfa"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8b25b41328273717b76250af11d35b4dfd457a1b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def test_list_categories_rbac(self):"},{"line_number":51,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":52,"context_line":"        categories_list \u003d self.application_catalog_client.list_categories()"},{"line_number":53,"context_line":"        self.assertIsInstance(categories_list, list)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @rbac_rule_validation.action(service\u003d\"murano\","},{"line_number":56,"context_line":"                                 rule\u003d\"create_category\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_19bbfac5","line":53,"updated":"2017-01-25 22:31:56.000000000","message":"See L44-45 comment","commit_id":"eddf2cf36135cbe12616c7b71abfb4075ef7acfa"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"833be5b29d5dfe07762e78d6c61517ade94a6ecb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#    Copyright (c) 2017 AT\u0026T"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_14657f44","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":28},"updated":"2017-01-25 23:01:18.000000000","message":"AT\u0026T Corporation.","commit_id":"b7254c431aa007925c90dc8695a6e45582ff763e"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"833be5b29d5dfe07762e78d6c61517ade94a6ecb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class RbacCategoriesTest(base.BaseMuranoAdminRbacTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_b44e6bbf","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":55},"updated":"2017-01-25 23:01:18.000000000","message":"Please have the filename end with _rbac.py to keep it consistent.  Also, is there a reason for the extra application_catalog folder?","commit_id":"b7254c431aa007925c90dc8695a6e45582ff763e"}],"patrole_tempest_plugin/tests/api/murano/clients.py":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"833be5b29d5dfe07762e78d6c61517ade94a6ecb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApplicationCatalogClient(rest_client.RestClient):"},{"line_number":29,"context_line":"    \"\"\"Tempest REST client for Murano Application Catalog\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, auth_provider):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_746de331","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":55},"updated":"2017-01-25 23:01:18.000000000","message":"Is this client just copied from the murano plugin?  If yes, it might be worth it to look into a way to re-use theirs rather than creating our own or a way to have these tests exist within the murano plugin.","commit_id":"b7254c431aa007925c90dc8695a6e45582ff763e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"728dd1084715ce018dde6a854626663ed49997f5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApplicationCatalogClient(rest_client.RestClient):"},{"line_number":29,"context_line":"    \"\"\"Tempest REST client for Murano Application Catalog\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, auth_provider):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_73f3360b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":55},"in_reply_to":"3a461143_746de331","updated":"2017-01-26 00:58:50.000000000","message":"Yes, it\u0027s copied from Murano. It might be possible to add Patrole as a plugin in Murano and do the RBAC tests there -- but I highly doubt such design would be welcomed by most projects, because Patrole is meant to be a plugin.\n\nI did try adding Murano to test-requirements.txt, but Zuul cross-references any proposed changes therein against global-requirements.txt, located the main requirements folder. Since murano is not in global-requirements.txt, it is not possible to reference the Murano Tempest tests directly.\n\nI can\u0027t think of any palatable alternative here. It\u0027d be nice if all OS projects included their clients in Tempest, then implemented their own Tempest tests in their project namespace. But that\u0027s not what the QA folks decided to do, for whatever reason.\n\nI think the only thing that can be done is to copy/paste the clients not in Tempest into Patrole.","commit_id":"b7254c431aa007925c90dc8695a6e45582ff763e"}],"patrole_tempest_plugin/tests/api/murano/rbac_base.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8b25b41328273717b76250af11d35b4dfd457a1b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def get_configured_isolated_creds(cls, type_of_creds\u003d\u0027admin\u0027):"},{"line_number":44,"context_line":"        identity_version \u003d CONF.identity.auth_version"},{"line_number":45,"context_line":"        if identity_version \u003d\u003d \u0027v3\u0027:"},{"line_number":46,"context_line":"            cls.admin_role \u003d CONF.identity.admin_role"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            cls.admin_role \u003d \u0027admin\u0027"},{"line_number":49,"context_line":"        if not hasattr(cls, \u0027dynamic_cred\u0027):"},{"line_number":50,"context_line":"            cls.dynamic_cred \u003d dynamic_creds.DynamicCredentialProvider("},{"line_number":51,"context_line":"                identity_version\u003dCONF.identity.auth_version,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d9efb2ae","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":36},"updated":"2017-01-25 22:31:56.000000000","message":"Is there a reason for this \"if\" statement?","commit_id":"eddf2cf36135cbe12616c7b71abfb4075ef7acfa"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"833be5b29d5dfe07762e78d6c61517ade94a6ecb","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @classmethod"},{"line_number":66,"context_line":"    def skip_checks(cls):"},{"line_number":67,"context_line":"        super(BaseMuranoAdminRbacTest, cls).skip_checks()"},{"line_number":68,"context_line":"        if not CONF.rbac.rbac_flag:"},{"line_number":69,"context_line":"            raise cls.skipException("},{"line_number":70,"context_line":"                \"%s skipped as RBAC Flag not enabled\" % cls.__name__)"},{"line_number":71,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":72,"context_line":"            raise cls.skipException("},{"line_number":73,"context_line":"                \"%s skipped because tempest roles is not admin\" % cls.__name__)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"},{"line_number":76,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_14f3bf74","line":73,"range":{"start_line":65,"start_character":4,"end_line":73,"end_character":79},"updated":"2017-01-25 23:01:18.000000000","message":"Is there a way to include a skip check that covers the case where a system does not include Murano.  Most of the Tempest base test classes do this.","commit_id":"b7254c431aa007925c90dc8695a6e45582ff763e"}]}
