)]}'
{"patrole_tempest_plugin/tests/api/identity/v2/rbac_base.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"b2b3f1b77d094dc3d19ecf224e00f41c5e7c32d9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_61422b12","line":15,"updated":"2017-01-27 17:27:07.000000000","message":"The base from tempest.api.identity needs to be imported, but it doesn\u0027t necessarily need to be renamed","commit_id":"de1e49904fee99032652f813f7ab45799a6e3688"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"7115061296a4fd0d5c1bc9030da900dbd91faa03","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_e1f37b9c","line":15,"in_reply_to":"3a461143_61422b12","updated":"2017-01-27 17:36:01.000000000","message":"woops! I deleted this by mistake. thanks for the catch","commit_id":"de1e49904fee99032652f813f7ab45799a6e3688"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"b2b3f1b77d094dc3d19ecf224e00f41c5e7c32d9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cls.auth_provider \u003d cls.os.auth_provider"},{"line_number":41,"context_line":"        cls.admin_client \u003d cls.os_adm.identity_client"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_service(self):"},{"line_number":44,"context_line":"        name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":45,"context_line":"        type \u003d data_utils.rand_name(\u0027type\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_e1561bd1","line":43,"updated":"2017-01-27 17:27:07.000000000","message":"Is this function going to be used for other RBAC tests?","commit_id":"de1e49904fee99032652f813f7ab45799a6e3688"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"7115061296a4fd0d5c1bc9030da900dbd91faa03","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cls.auth_provider \u003d cls.os.auth_provider"},{"line_number":41,"context_line":"        cls.admin_client \u003d cls.os_adm.identity_client"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_service(self):"},{"line_number":44,"context_line":"        name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":45,"context_line":"        type \u003d data_utils.rand_name(\u0027type\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_212ca301","line":43,"in_reply_to":"3a461143_e1561bd1","updated":"2017-01-27 17:36:01.000000000","message":"yup used by multiple tests","commit_id":"de1e49904fee99032652f813f7ab45799a6e3688"}],"patrole_tempest_plugin/tests/api/identity/v2/rbac_v2_base.py":[{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"30daaafdfefc06d15781db614817ba37b7eff056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a461143_e0d63526","updated":"2017-01-27 00:56:24.000000000","message":"Change the name of the base file to rbac_base","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 ATT Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_74cbd11e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":20},"updated":"2017-01-27 14:21:27.000000000","message":"Should be \"AT\u0026T\" for consistency across files","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.identity import base as identity_base"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_f4d7c1bc","line":16,"range":{"start_line":16,"start_character":37,"end_line":16,"end_character":54},"updated":"2017-01-27 14:21:27.000000000","message":"This is fine, but in this case it isn\u0027t really necessary","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        cls.auth_provider \u003d cls.os.auth_provider"},{"line_number":42,"context_line":"        cls.admin_client \u003d cls.os_adm.identity_client"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_service(self):"},{"line_number":45,"context_line":"        name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":46,"context_line":"        type \u003d data_utils.rand_name(\u0027type\u0027)"},{"line_number":47,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_3a005301","line":44,"updated":"2017-01-27 14:21:27.000000000","message":"Will this be used for one test or multiple tests? If only one test, it would probably be better to keep it closer to where it\u0027s being used","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def _create_service(self):"},{"line_number":45,"context_line":"        name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":46,"context_line":"        type \u003d data_utils.rand_name(\u0027type\u0027)"},{"line_number":47,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        service \u003d self.services_client.create_service("},{"line_number":50,"context_line":"            name\u003dname, type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_fa35ebd9","line":47,"updated":"2017-01-27 14:21:27.000000000","message":"nit: Don\u0027t think the description is necessary or you can just do something like \"my description\" rather than running this","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        type \u003d data_utils.rand_name(\u0027type\u0027)"},{"line_number":47,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        service \u003d self.services_client.create_service("},{"line_number":50,"context_line":"            name\u003dname, type\u003dtype,"},{"line_number":51,"context_line":"            description\u003ddescription)[\u0027OS-KSADM:service\u0027]"},{"line_number":52,"context_line":"        service_id \u003d service[\u0027id\u0027]"},{"line_number":53,"context_line":"        self.addCleanup(self.services_client.delete_service, service_id)"},{"line_number":54,"context_line":"        return service_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_5a2a7f7f","line":52,"range":{"start_line":49,"start_character":0,"end_line":52,"end_character":34},"updated":"2017-01-27 14:21:27.000000000","message":"If all you want is the service id, these lines can be consolidated","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"}],"patrole_tempest_plugin/tests/api/identity/v2/test_endpoints_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"4c25947de9651e173b6b97cea4238e729d9185d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 ATT Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9a5b072e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":20},"updated":"2017-01-27 14:21:27.000000000","message":"Should be \"AT\u0026T\" for consistency across files","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"30daaafdfefc06d15781db614817ba37b7eff056","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_00b181e1","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":13},"updated":"2017-01-27 00:56:24.000000000","message":"dont need logging","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"30daaafdfefc06d15781db614817ba37b7eff056","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from patrole_tempest_plugin.tests.api.identity.v2 import rbac_v2_base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class IdentityEndpointsV2AdminRbacTest(rbac_v2_base.BaseIdentityV2RbacTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_20b4bdcf","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":4},"updated":"2017-01-27 00:56:24.000000000","message":"dont need logging","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"e31a61dd57191d625b3b4ea4cb9fcfe12d6bdd4e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":39,"context_line":"        super(IdentityEndpointsV2AdminRbacTest, self).tearDown()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    region \u003d data_utils.rand_name(\u0027region\u0027)"},{"line_number":42,"context_line":"    public_url \u003d data_utils.rand_url()"},{"line_number":43,"context_line":"    admin_url \u003d data_utils.rand_url()"},{"line_number":44,"context_line":"    internal_url \u003d data_utils.rand_url()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":47,"context_line":"                                 rule\u003d\"identity:create_endpoint\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_0ee44b0b","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":40},"updated":"2017-01-27 08:33:53.000000000","message":"Instead of making it a class variable, it\u0027ll be good if we make it instance variables in a constructor method.","commit_id":"8bfaf270c225f2c38206a1e870379a87d6fc5e01"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"b2b3f1b77d094dc3d19ecf224e00f41c5e7c32d9","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        service_id \u003d self._create_service()"},{"line_number":55,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":56,"context_line":"        self.endpoints_client.create_endpoint("},{"line_number":57,"context_line":"            service_id\u003dservice_id,"},{"line_number":58,"context_line":"            region\u003dself.region,"},{"line_number":59,"context_line":"            publicurl\u003dself.public_url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_c16e7f95","line":56,"updated":"2017-01-27 17:27:07.000000000","message":"Where is this being cleaned up?","commit_id":"de1e49904fee99032652f813f7ab45799a6e3688"}]}