)]}'
{"patrole_tempest_plugin/tests/api/volume/test_snapshots_metadata_rbac.py":[{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_bf2f3ff5","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":11},"updated":"2017-02-03 01:11:24.000000000","message":"unused","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest import config"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_bfbadfbe","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":14},"updated":"2017-02-03 01:11:24.000000000","message":"unused loggin","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from patrole_tempest_plugin.tests.api.volume import rbac_base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class SnapshotMetadataRbacTest(rbac_base.BaseVolumeRbacTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_1fca1350","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"updated":"2017-02-03 01:11:24.000000000","message":"unused","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            raise cls.skipException(\"Cinder snapshot feature disabled\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"},{"line_number":40,"context_line":"        super(SnapshotMetadataRbacTest, cls).setup_clients()"},{"line_number":41,"context_line":"        cls.client \u003d cls.os.snapshots_client"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_7fc1572e","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":21},"updated":"2017-02-03 01:11:24.000000000","message":"shouldnt this be in the base?","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"087bca9380ba97808c6700c6ed616d99367687e6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            raise cls.skipException(\"Cinder snapshot feature disabled\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"},{"line_number":40,"context_line":"        super(SnapshotMetadataRbacTest, cls).setup_clients()"},{"line_number":41,"context_line":"        cls.client \u003d cls.os.snapshots_client"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_eb9ad2c4","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":21},"in_reply_to":"1a430d35_7fc1572e","updated":"2017-02-03 16:27:51.000000000","message":"I\u0027ve shortened the name of the snapshots client for this specific test, but it\u0027s not a name I\u0027m using for other tests.","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            self.snapshot_id, metadata)[\u0027metadata\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @rbac_rule_validation.action("},{"line_number":65,"context_line":"        service\u003d\"cinder\","},{"line_number":66,"context_line":"        rule\u003d\"volume_extension:extended_snapshot_attributes\")"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027c9cbec1c-edfe-46b8-825b-7b6ac0a58c25\u0027)"},{"line_number":68,"context_line":"    def test_create_snapshot_metadata(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_ffeb87ae","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":15},"updated":"2017-02-03 01:11:24.000000000","message":"pep8: alignment","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        # Get metadata for the snapshot"},{"line_number":80,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":81,"context_line":"        self.client.show_snapshot_metadata("},{"line_number":82,"context_line":"            self.snapshot_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @rbac_rule_validation.action("},{"line_number":85,"context_line":"        service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_9f036376","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":16},"updated":"2017-02-03 01:11:24.000000000","message":"pep8: alignment","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.snapshot_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @rbac_rule_validation.action("},{"line_number":85,"context_line":"        service\u003d\"cinder\","},{"line_number":86,"context_line":"        rule\u003d\"volume_extension:volume_tenant_attribute\")"},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027e2c73b00-0c19-4bb7-8c61-d84b1a223ed1\u0027)"},{"line_number":88,"context_line":"    def test_get_snapshot_metadata_for_volume_tenant(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_dffdeb6f","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":15},"updated":"2017-02-03 01:11:24.000000000","message":"pep8 alignment","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":93,"context_line":"        # Get the metadata of the snapshot"},{"line_number":94,"context_line":"        self.client.show_snapshot_metadata("},{"line_number":95,"context_line":"            self.snapshot_id)[\u0027metadata\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class SnapshotMetadataV3RbacTest(SnapshotMetadataRbacTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_3ff50f83","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":16},"updated":"2017-02-03 01:11:24.000000000","message":"pep8","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23625,"name":"Nicolas Helgeson","email":"nh202b@att.com","username":"nhelgeson"},"change_message_id":"1f75917ec8c350608e44e100945af621fea63190","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self.snapshot_id)[\u0027metadata\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class SnapshotMetadataV3RbacTest(SnapshotMetadataRbacTest):"},{"line_number":99,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_9f2a83e6","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":32},"updated":"2017-02-03 01:11:24.000000000","message":"unused class","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ab9a6337e2b507c6dd6ecb3320f441a588e0c045","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self.snapshot_id)[\u0027metadata\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class SnapshotMetadataV3RbacTest(SnapshotMetadataRbacTest):"},{"line_number":99,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_0b79de93","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":32},"in_reply_to":"1a430d35_9f2a83e6","updated":"2017-02-03 16:27:00.000000000","message":"It is used; this runs the tests above using the v3 api instead of the v2 api","commit_id":"c733d3768114f1a6136471fecc1998a71e5a7263"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"953aaec1f52e20e363a5be865d56b59c92644ba9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"},{"line_number":36,"context_line":"        super(SnapshotMetadataRbacTest, cls).setup_clients()"},{"line_number":37,"context_line":"        cls.client \u003d cls.os.snapshots_client"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def tearDown(self):"},{"line_number":40,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_421d7b72","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":44},"updated":"2017-02-03 23:17:57.000000000","message":"Do we think it is better to make this a reference to the cls.os.snapshots_client or the cls.snapshots_client created in the tempest base class?  I am leaning towards copying the one in the tempest base class since it can vary in the base class based on the api_version, and just for consistency.","commit_id":"e3dbe4e933afeaf6e4dbf3f8f8997980695ee3fa"}]}