)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b352c82ea50e7c2b4d48e26fcdf642144cc5ca3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- get_all_transfers tested twice instead of get_transfer"},{"line_number":10,"context_line":"  and get_all_transfers"},{"line_number":11,"context_line":"- delete_transfers not tested"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If81ed8c6173714d1b50746829b1be141d75b7a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_7f164ea8","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":18},"updated":"2017-02-06 18:10:27.000000000","message":"As we are testing single transfer delete, use \"delete_transfer\" instead \"delete_transfers\"","commit_id":"1f0ef41652328be49e3fd88bdb44e290badb0e75"}],"patrole_tempest_plugin/tests/api/volume/test_volume_transfers_rbac.py":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b352c82ea50e7c2b4d48e26fcdf642144cc5ca3f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                 rule\u003d\"volume:delete_transfer\")"},{"line_number":96,"context_line":"    @decorators.idempotent_id(\u00274672187e-7fff-454b-832a-5c8865dda868\u0027)"},{"line_number":97,"context_line":"    def test_delete_volume_transfer(self):"},{"line_number":98,"context_line":"        transfer \u003d self.client.create_volume_transfer("},{"line_number":99,"context_line":"            volume_id\u003dself.volume[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":100,"context_line":"        self.addCleanup(self._delete_transfer, transfer)"},{"line_number":101,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":102,"context_line":"        self.client.delete_volume_transfer(transfer[\u0027id\u0027])"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_9f45ba71","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":56},"updated":"2017-02-06 18:10:27.000000000","message":"In almost all the tests, these lines are repeated, better is to put this in private method and use created private method in each testcase.","commit_id":"1f0ef41652328be49e3fd88bdb44e290badb0e75"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"e4eea1df844abfd1913ad51e9956d243ea0a3321","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        waiters.wait_for_volume_status(self.client, self.volume[\u0027id\u0027],"},{"line_number":55,"context_line":"                                       \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _create_cleanup_transfer(self):"},{"line_number":58,"context_line":"        transfer \u003d self.client.create_volume_transfer("},{"line_number":59,"context_line":"            volume_id\u003dself.volume[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":60,"context_line":"        self.addCleanup(self._delete_transfer, transfer)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_5951ad0d","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":32},"updated":"2017-02-06 19:02:49.000000000","message":"method name should be changed to \"_create_transfer\" or \"_create_volume_transfer\". And if using _create_volume_transfer, \"_delete_transfer\" should also be changed to \"_delete_volume_tranfer\"","commit_id":"8478c0d457c8d319e8128954a8dbd6a4c9c603db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"67b4c5a4bcf828d9cb4e70f5fd3bcf53ba990dd7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002725413af4-468d-48ff-94ca-4436f8526b3e\u0027)"},{"line_number":66,"context_line":"    def test_create_volume_transfer(self):"},{"line_number":67,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":68,"context_line":"        self._create_cleanup_transfer()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","},{"line_number":71,"context_line":"                                 rule\u003d\"volume:get_transfer\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_9f485589","line":68,"range":{"start_line":68,"start_character":13,"end_line":68,"end_character":37},"updated":"2017-02-06 20:35:32.000000000","message":"change it to _create_transfer","commit_id":"129a069064869f3f20e6327598e863555f0ad437"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"67b4c5a4bcf828d9cb4e70f5fd3bcf53ba990dd7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                 rule\u003d\"volume:get_transfer\")"},{"line_number":72,"context_line":"    @decorators.idempotent_id(\u00277a0925d3-ed97-4c25-8299-e5cdabe2eb55\u0027)"},{"line_number":73,"context_line":"    def test_get_volume_transfer(self):"},{"line_number":74,"context_line":"        transfer \u003d self._create_cleanup_transfer()"},{"line_number":75,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":76,"context_line":"        self.client.show_volume_transfer(transfer[\u0027id\u0027])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_3f320111","line":74,"range":{"start_line":74,"start_character":24,"end_line":74,"end_character":48},"updated":"2017-02-06 20:35:32.000000000","message":"ditto","commit_id":"129a069064869f3f20e6327598e863555f0ad437"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"67b4c5a4bcf828d9cb4e70f5fd3bcf53ba990dd7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                 rule\u003d\"volume:accept_transfer\")"},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027987f2a11-d657-4984-a6c9-28f06c1cd014\u0027)"},{"line_number":88,"context_line":"    def test_accept_volume_transfer(self):"},{"line_number":89,"context_line":"        transfer \u003d self._create_cleanup_transfer()"},{"line_number":90,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":91,"context_line":"        self.client.accept_volume_transfer(transfer[\u0027id\u0027],"},{"line_number":92,"context_line":"                                           auth_key\u003dtransfer[\u0027auth_key\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_5f350df5","line":89,"range":{"start_line":89,"start_character":24,"end_line":89,"end_character":48},"updated":"2017-02-06 20:35:32.000000000","message":"ditto","commit_id":"129a069064869f3f20e6327598e863555f0ad437"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"67b4c5a4bcf828d9cb4e70f5fd3bcf53ba990dd7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                 rule\u003d\"volume:delete_transfer\")"},{"line_number":96,"context_line":"    @decorators.idempotent_id(\u00274672187e-7fff-454b-832a-5c8865dda868\u0027)"},{"line_number":97,"context_line":"    def test_delete_volume_transfer(self):"},{"line_number":98,"context_line":"        transfer \u003d self._create_cleanup_transfer()"},{"line_number":99,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":100,"context_line":"        self.client.delete_volume_transfer(transfer[\u0027id\u0027])"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_bf26f1cb","line":98,"range":{"start_line":98,"start_character":24,"end_line":98,"end_character":48},"updated":"2017-02-06 20:35:32.000000000","message":"ditto","commit_id":"129a069064869f3f20e6327598e863555f0ad437"}]}