)]}'
{"patrole_tempest_plugin/tests/api/volume/admin/test_volume_types_extra_specs_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f92978504f9f84af75bbb66b6147ecb9036b8b94","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setup_clients(cls):"},{"line_number":35,"context_line":"        super(VolumeTypesExtraSpecsAdminRbacTest, cls).setup_clients()"},{"line_number":36,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":37,"context_line":"            cls.client \u003d cls.os.volume_types_client"},{"line_number":38,"context_line":"        elif cls._api_version \u003d\u003d 2:"},{"line_number":39,"context_line":"            cls.client \u003d cls.os.volume_types_v2_client"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def tearDown(self):"},{"line_number":42,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_1eeccc8e","line":39,"range":{"start_line":36,"start_character":8,"end_line":39,"end_character":54},"updated":"2017-02-09 19:20:08.000000000","message":"See comment in https://review.openstack.org/#/c/431645/3/patrole_tempest_plugin/tests/api/volume/admin/test_volume_hosts_rbac.py.\n\nSame logic applies there here.","commit_id":"f2a61d8a4d624a08cec3fa51bac8ca3a7a041b49"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7f794e4bf89aa061e37e17f2b744c1245d32733f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def tearDown(self):"},{"line_number":29,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":30,"context_line":"        self.clear_volume_types()"},{"line_number":31,"context_line":"        super(VolumeTypesExtraSpecsAdminRbacTest, self).tearDown()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_ea166754","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":33},"updated":"2017-02-09 20:53:11.000000000","message":"Is this needed as part of the tearDown? According to tempest.api.volume.base, this function is called in resource_cleanup already. Even if there were many tests, a class-level clean up for volume types should be OK.","commit_id":"2f1720cbf590a362436032679538e7d292a8f402"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"73e1e8a37b76dc8586e817926933c80c78929882","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":40,"context_line":"        self.volume_types_client.create_volume_type_extra_specs("},{"line_number":41,"context_line":"            vol_type[\u0027id\u0027], extra_specs)"},{"line_number":42,"context_line":"        self.volume_types.append(vol_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_6f9b1373","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":48},"updated":"2017-02-13 02:17:28.000000000","message":"this is not needed as base method create_volume_type at L36 take of it.\n\nWith this it will unnecessary go for duplicate delete on cinder side and wait function call.","commit_id":"be1c30a228c09324054f98de3d31720e6a19b099"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"effff2689a26866ab8c2d405a0a0c4e4391cbdd4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 AT\u0026T Corp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_119c5c68","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":26},"updated":"2017-02-13 16:32:01.000000000","message":"Nit: Consistent copyright please.","commit_id":"d019270298f0c5cacf4d09118c6aeeddb7423cf6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cf019fb15726552e105ff52349b8cd72d1479bee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def test_volume_type_extra_specs_list(self):"},{"line_number":36,"context_line":"        vol_type \u003d self.create_volume_type()"},{"line_number":37,"context_line":"        # List Volume types extra specs."},{"line_number":38,"context_line":"        extra_specs \u003d {\"spec1\": \"val1\"}"},{"line_number":39,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":40,"context_line":"        self.volume_types_client.create_volume_type_extra_specs("},{"line_number":41,"context_line":"            vol_type[\u0027id\u0027], extra_specs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_7a7009dd","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":39},"updated":"2017-02-13 19:54:40.000000000","message":"Nit: In other places you did data_utils.rand_name() for this, here you don\u0027t.","commit_id":"4305263524c5ad711fc7c5e32460fc7a24eadcbf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7704344d494a36ab7dedd61390617cf34ad92a3a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def test_volume_type_extra_specs_list(self):"},{"line_number":36,"context_line":"        vol_type \u003d self.create_volume_type()"},{"line_number":37,"context_line":"        # List Volume types extra specs."},{"line_number":38,"context_line":"        extra_specs \u003d {\"spec1\": \"val1\"}"},{"line_number":39,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":40,"context_line":"        self.volume_types_client.create_volume_type_extra_specs("},{"line_number":41,"context_line":"            vol_type[\u0027id\u0027], extra_specs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_4676ffa4","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":39},"in_reply_to":"fa31d9ce_7a7009dd","updated":"2017-02-14 04:22:21.000000000","message":"I think it is fine for extra spec as it is key value pair.","commit_id":"4305263524c5ad711fc7c5e32460fc7a24eadcbf"}]}
