)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6d8a33f9373630fa0a8070442d70f75c1f7dee3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The extensions_client\u0027s list API returns the list of all the nova"},{"line_number":10,"context_line":"extensions defined in nova.policies. All of the :discoverable"},{"line_number":11,"context_line":"policy actions are invoked. Meaning that each :discoverable policy"},{"line_number":12,"context_line":"action can be covered using extensions_client.list_exteions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Currently, in Nova, show_extension also enforces all discoverable"},{"line_number":15,"context_line":"policy actions, which might be considered a bug [0]; def index"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_42206ff7","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":59},"updated":"2017-02-15 08:49:59.000000000","message":"extensions","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6d8a33f9373630fa0a8070442d70f75c1f7dee3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"in nova list-extensions, show_extension(extension_alias) is"},{"line_number":22,"context_line":"used; otherwise list_extensions() is used as a fallback."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Ideally show_extension should be fixed to work with all"},{"line_number":25,"context_line":"discoverable policy actions and only enforce a single policy"},{"line_number":26,"context_line":"action."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[0] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extension_info.py"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_6249f3b6","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":7},"updated":"2017-02-15 08:49:59.000000000","message":"yea that is nice catch, i will check this on nova side if we can fix this.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_access_ips_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6d8a33f9373630fa0a8070442d70f75c1f7dee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa31d9ce_62f73359","updated":"2017-02-15 08:49:59.000000000","message":"so this is no more there, you need rebase.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"15cae236c00c9d637907fcd9912e1d41fb3dd0d0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        rule\u003d\"os_compute_api:os-access-ips:discoverable\")"},{"line_number":51,"context_line":"    def test_access_ips_discoverable(self):"},{"line_number":52,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_6535d6f5","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":46},"updated":"2017-02-13 15:31:58.000000000","message":"show_extension","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c0e4f5980432b44a27da39f3b95caebf599eb5b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        rule\u003d\"os_compute_api:os-access-ips:discoverable\")"},{"line_number":51,"context_line":"    def test_access_ips_discoverable(self):"},{"line_number":52,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_ab26bfcb","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":46},"in_reply_to":"fa31d9ce_6535d6f5","updated":"2017-02-13 16:07:27.000000000","message":"The commit message explains why this is done.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"7302ffbf7410e79041d90d764862da4ef3649b43","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        rule\u003d\"os_compute_api:os-access-ips:discoverable\")"},{"line_number":51,"context_line":"    def test_access_ips_discoverable(self):"},{"line_number":52,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_96ce82b2","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":46},"in_reply_to":"fa31d9ce_ab26bfcb","updated":"2017-02-13 16:11:21.000000000","message":"Got it; my bad for not reading. Although, isn\u0027t the plan to delete this file?","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_instance_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6d8a33f9373630fa0a8070442d70f75c1f7dee3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @rbac_rule_validation.action("},{"line_number":67,"context_line":"        service\u003d\"nova\","},{"line_number":68,"context_line":"        rule\u003d\"os_compute_api:os-instance-actions:discoverable\")"},{"line_number":69,"context_line":"    def test_hypervisor_discoverable(self):"},{"line_number":70,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":71,"context_line":"        self.extensions_client.show_extension(\u0027os-instance-actions\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_824d079c","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":23},"updated":"2017-02-15 08:49:59.000000000","message":"instance_action","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_limits_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"15cae236c00c9d637907fcd9912e1d41fb3dd0d0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        rule\u003d\"os_compute_api:limits:discoverable\")"},{"line_number":53,"context_line":"    def test_limits_discoverable(self):"},{"line_number":54,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":55,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_c52682cd","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":46},"updated":"2017-02-13 15:31:58.000000000","message":"show_extension","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c0e4f5980432b44a27da39f3b95caebf599eb5b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        rule\u003d\"os_compute_api:limits:discoverable\")"},{"line_number":53,"context_line":"    def test_limits_discoverable(self):"},{"line_number":54,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":55,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_cb2133b6","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":46},"in_reply_to":"fa31d9ce_c52682cd","updated":"2017-02-13 16:07:27.000000000","message":"The commit message explains why this is done.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ffbca1f89422f5fe3ce7fcc4e83cb688e8f693c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        rule\u003d\"os_compute_api:limits:discoverable\")"},{"line_number":53,"context_line":"    def test_limits_discoverable(self):"},{"line_number":54,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":55,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_78a9177b","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":46},"in_reply_to":"fa31d9ce_cb2133b6","updated":"2017-03-16 09:30:00.000000000","message":"i am not sure why show_extension does not work here.\n\nOn nova side, show_extensions checks for all extension discovery policy but did not fail if any other extension is disabled. it will just filter out that extension and no affect on show_extensions(xyz).\n\n\nwe use fetal\u003dFalse while checking the discovery policy for any extensions\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/extension_info.py#n226\n\nOverall from user point of view show_extension works fine its just internal implementation which does extra policy checks on other extensions and ignore if any extensions fails to pass the policy.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_security_groups_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6d8a33f9373630fa0a8070442d70f75c1f7dee3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @rbac_rule_validation.action("},{"line_number":39,"context_line":"        service\u003d\"nova\","},{"line_number":40,"context_line":"        rule\u003d\"os_compute_api:os-security-groups:discoverable\")"},{"line_number":41,"context_line":"    def test_rescue_discoverable(self):"},{"line_number":42,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":43,"context_line":"        self.extensions_client.show_extension(\u0027os-security-groups\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_6253b339","line":41,"range":{"start_line":41,"start_character":13,"end_line":41,"end_character":20},"updated":"2017-02-15 08:49:59.000000000","message":"security_groups","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_server_usage_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"15cae236c00c9d637907fcd9912e1d41fb3dd0d0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        rule\u003d\"os_compute_api:os-server-usage:discoverable\")"},{"line_number":61,"context_line":"    def test_server_usage_discoverable(self):"},{"line_number":62,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":63,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_4519b287","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":46},"updated":"2017-02-13 15:31:58.000000000","message":"show_extension","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c0e4f5980432b44a27da39f3b95caebf599eb5b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        rule\u003d\"os_compute_api:os-server-usage:discoverable\")"},{"line_number":61,"context_line":"    def test_server_usage_discoverable(self):"},{"line_number":62,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":63,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_6b13e766","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":46},"in_reply_to":"fa31d9ce_4519b287","updated":"2017-02-13 16:07:27.000000000","message":"The commit message explains why this is done.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}],"patrole_tempest_plugin/tests/api/compute/test_server_volume_attachments_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"15cae236c00c9d637907fcd9912e1d41fb3dd0d0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        rule\u003d\"os_compute_api:os-volumes-attachments:discoverable\")"},{"line_number":137,"context_line":"    def test_volumes_attachment_discoverable(self):"},{"line_number":138,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":139,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_8513aa65","line":139,"range":{"start_line":139,"start_character":31,"end_line":139,"end_character":46},"updated":"2017-02-13 15:31:58.000000000","message":"show_extension","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c0e4f5980432b44a27da39f3b95caebf599eb5b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        rule\u003d\"os_compute_api:os-volumes-attachments:discoverable\")"},{"line_number":137,"context_line":"    def test_volumes_attachment_discoverable(self):"},{"line_number":138,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":139,"context_line":"        self.extensions_client.list_extensions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_ab0ddf3f","line":139,"range":{"start_line":139,"start_character":31,"end_line":139,"end_character":46},"in_reply_to":"fa31d9ce_8513aa65","updated":"2017-02-13 16:07:27.000000000","message":"The commit message explains why this is done.","commit_id":"c1202b9da09d18568b4e9833ffbd9f4cb631cb5d"}]}