)]}'
{"patrole_tempest_plugin/tests/api/identity/v3/test_endpoints_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"57725b74b5acce066aef869d40c3e2135634ce68","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                        interface\u003dinterface,"},{"line_number":40,"context_line":"                                        url\u003durl)[\u0027endpoint\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.addCleanup(self.endpoints_client.delete_endpoint, endpoint[\u0027id\u0027])"},{"line_number":43,"context_line":"        return (service, endpoint)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_f7af00e1","line":42,"range":{"start_line":42,"start_character":7,"end_line":42,"end_character":78},"updated":"2017-02-10 18:28:54.000000000","message":"This should use test_utils.call_func_and_ignore_not_found_exc. This is because test_delete_endpoint calls _create_endpoint, then deletes the endpoint, and since the deletion of the endpoint will usually succeed, when addCleanup calls this function following the function and tearDown, a Not Found exception will be thrown.","commit_id":"89646cab20266eff161242086108e6dac92ad394"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"0fb816210a14f470d60f3b46a4b3749588e7efa0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                        url\u003durl)[\u0027endpoint\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.addCleanup(self.endpoints_client.delete_endpoint, endpoint[\u0027id\u0027])"},{"line_number":43,"context_line":"        return (service, endpoint)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def tearDown(self):"},{"line_number":46,"context_line":"        \"\"\"Reverts user back to admin for cleanup.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_1a003b34","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":23},"updated":"2017-02-10 19:16:13.000000000","message":"it looks like service isn\u0027t used anywhere in the testcases below except for creating the endpoint itself. Is there a reason this is being returned?","commit_id":"89646cab20266eff161242086108e6dac92ad394"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"0fb816210a14f470d60f3b46a4b3749588e7efa0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        new_url \u003d data_utils.rand_url()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":73,"context_line":"        self.endpoints_client.update_endpoint(endpoint[\"id\"],"},{"line_number":74,"context_line":"                                              service_id\u003dservice[\u0027id\u0027],"},{"line_number":75,"context_line":"                                              url\u003dnew_url)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_7ac77712","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":29},"updated":"2017-02-10 19:16:13.000000000","message":"is this os or os_adm?","commit_id":"89646cab20266eff161242086108e6dac92ad394"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"a828e5e1d0f026b037d9d010598ccf4be9d10016","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":50,"context_line":"                                 rule\u003d\"identity:create_endpoint\")"},{"line_number":51,"context_line":"    @test.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd127\u0027)"},{"line_number":52,"context_line":"    def test_create_endpoint(self):"},{"line_number":53,"context_line":"        \"\"\"Create an endpoint."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_dbca224f","line":51,"range":{"start_line":51,"start_character":5,"end_line":51,"end_character":9},"updated":"2017-02-10 22:09:39.000000000","message":"I believe you should be using decorators, not tempest test","commit_id":"09b05fe003ed6644258fd27ae99934f65fce0f19"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"c6a215b6b728537da670ded26645600c1f48058e","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":50,"context_line":"                                 rule\u003d\"identity:create_endpoint\")"},{"line_number":51,"context_line":"    @test.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd127\u0027)"},{"line_number":52,"context_line":"    def test_create_endpoint(self):"},{"line_number":53,"context_line":"        \"\"\"Create an endpoint."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_7b369604","line":51,"range":{"start_line":51,"start_character":5,"end_line":51,"end_character":9},"in_reply_to":"fa31d9ce_dbca224f","updated":"2017-02-10 22:21:07.000000000","message":"test just redirects to the decorators for idempotent_id, so there is extra baggage if you import test","commit_id":"09b05fe003ed6644258fd27ae99934f65fce0f19"}]}
