)]}'
{"patrole_tempest_plugin/tests/api/compute/test_flavor_extra_specs_rbac.py":[{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"354d003001363d1d43729412ddddf441d3ed9103","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def resource_cleanup(cls):"},{"line_number":47,"context_line":"        cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":48,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":49,"context_line":"        super(FlavorExtraSpecsAdminRbacTest, cls).resource_cleanup()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_3b5d0fed","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":50},"updated":"2017-02-17 00:23:11.000000000","message":"wait_for_resource_deletion would catch exceptions for time out but are we good just calling delete or should we be deleting class level resources with test_utils? eg) test_utils.call_and_ignore_notfound_exc(cls.client.delete_flavor, flavor[\u0027id\u0027])","commit_id":"f6ee09808b78cb882348ebcc2012fd82a35f9917"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d42e09c8a034885a3735882d121ff700f194753f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def resource_cleanup(cls):"},{"line_number":47,"context_line":"        cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":48,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":49,"context_line":"        super(FlavorExtraSpecsAdminRbacTest, cls).resource_cleanup()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_95f14ed0","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":50},"in_reply_to":"fa31d9ce_3b5d0fed","updated":"2017-02-17 14:56:16.000000000","message":"If resource_setup fails to create a flavor, then as soon as the first test is run, cls.flavor[\u0027id\u0027] will throw an exception anyway; assuming resource_cleanup is still executed, it\u0027ll also throw an exception. Either way, an exception will already have been thrown by the time it reaches this point. Also see https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_flavors_extra_specs.py where they do the same thing.\n\nThe main reason for using test_utils.call_and_ignore_notfound_exc is (as far as I can tell):\n1) Cleaning up after a test is run, because the resource was already deleted\n2) Ensuring that each test is atomic\n\nBecause this is a class-level resource that is never deleted, neither case applies.","commit_id":"f6ee09808b78cb882348ebcc2012fd82a35f9917"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"6b8a4b80bb65e39028bfdf6b5e00f5bd5afd59f4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def resource_cleanup(cls):"},{"line_number":47,"context_line":"        cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":48,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":49,"context_line":"        super(FlavorExtraSpecsAdminRbacTest, cls).resource_cleanup()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_39fed86b","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":50},"in_reply_to":"fa31d9ce_95f14ed0","updated":"2017-02-17 17:57:19.000000000","message":"ok. sounds reasonable :) thanks for the response","commit_id":"f6ee09808b78cb882348ebcc2012fd82a35f9917"}]}