)]}'
{"patrole_tempest_plugin/tests/api/identity/v2/test_users_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        \"\"\"Create User Test"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        (keystone user-create)"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        tenant \u003d self._create_tenant()"},{"line_number":43,"context_line":"        user_name \u003d data_utils.rand_name(\u0027test_create_user\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_4fa3ef9e","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":30},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        \"\"\"Update User Test"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        (keystone user-update)"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        user \u003d self._create_user()"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_8fc88776","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":30},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        \"\"\"Set User Enabled Test"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        (keystone)"},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        user \u003d self._create_user()"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_efa583b5","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":18},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary and non-descriptive.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        \"\"\"Delete User Test"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        (keystone user-delete)"},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        user \u003d self._create_user()"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_0fabb78a","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":30},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        \"\"\"Get Users Test"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        (keystone user-list)"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":100,"context_line":"        self.users_client.list_users()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_2fb07bf4","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":28},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        \"\"\"Get User Test"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        (keystone user-get)"},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        user \u003d self._create_user()"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_8f9fa75e","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":27},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        \"\"\"Admin Change Password Test (keystone user-password-update)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        PUT /v2.0/users/{userId}/OS-KSADM/password HTTP/1.1"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        user \u003d self._create_user()"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_2f879b10","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":59},"updated":"2017-02-28 22:37:39.000000000","message":"Unnecessary.","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7a0818b407c54f8f093f5607d3934b7f14bb0d29","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":128,"context_line":"        self.users_client.update_user_password(user[\u0027id\u0027],"},{"line_number":129,"context_line":"                                               password\u003d\"newPassword\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_8f76c73c","line":129,"range":{"start_line":129,"start_character":57,"end_line":129,"end_character":68},"updated":"2017-02-28 22:37:39.000000000","message":"data_utils.rand_password()","commit_id":"57073b0bc77e85e3f8f964617b605bc190a437f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9185bbc745d811c39e674ff1365c325fed6d6fff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        user_name \u003d data_utils.rand_name(\u0027test_create_user\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":41,"context_line":"        self._create_user(name\u003duser_name, tenantid\u003dtenant[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":44,"context_line":"                                 rule\u003d\"identity:update_user\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_fdffda31","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":64},"updated":"2017-03-01 14:51:53.000000000","message":"Nit: is it really needed to create a tenant and user_name to create a user? Elsewhere you\u0027re not doing that. If it\u0027s not really necessary, then don\u0027t bother with a tenant, because it\u0027s just an unnecessary resource creation at that point.","commit_id":"e589c596b2130ef91b0e0cf2a0eb83d088023710"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"8e5387d99f92b33389ed692ad31e55473533c91d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        user_name \u003d data_utils.rand_name(\u0027test_create_user\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":41,"context_line":"        self._create_user(name\u003duser_name, tenantid\u003dtenant[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":44,"context_line":"                                 rule\u003d\"identity:update_user\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_e4049a7f","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":64},"in_reply_to":"ba2be162_fdffda31","updated":"2017-03-01 18:38:34.000000000","message":"i kept it because the co-author structured it that way, but i feel like theres no need to create tenant and user name.. if the user can get a success response back that should be enough. agreed. ill change it","commit_id":"e589c596b2130ef91b0e0cf2a0eb83d088023710"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bb8c8327d9a0b9ed56fde44c667bb3f9011af47f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_ed747a9d","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"updated":"2017-03-01 20:50:09.000000000","message":"Unused.","commit_id":"9716e2c8d4e23e31d6fe982c57e11d541feeb7ca"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bb8c8327d9a0b9ed56fde44c667bb3f9011af47f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from patrole_tempest_plugin.rbac_utils import rbac_utils"},{"line_number":22,"context_line":"from patrole_tempest_plugin.tests.api.identity.v2 import rbac_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class IdentityUserV2AdminRbacTest(rbac_base.BaseIdentityV2AdminRbacTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_8d3dbebd","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":18},"updated":"2017-03-01 20:50:09.000000000","message":"Unused.","commit_id":"9716e2c8d4e23e31d6fe982c57e11d541feeb7ca"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"55c06eacfb6e8b4b1e9fb3a7e5400b1508e74bed","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class IdentityUserV2AdminRbacTest(rbac_base.BaseIdentityV2AdminRbacTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def tearDown(self):"},{"line_number":27,"context_line":"        super(IdentityUserV2AdminRbacTest, self).tearDown()"},{"line_number":28,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_9b4ce643","line":27,"updated":"2017-03-02 14:55:09.000000000","message":"Call to super goes last for tearDown","commit_id":"90efcdba91290557db97dcc792b7bc098a64a86a"}]}