)]}'
{"patrole_tempest_plugin/tests/api/network/test_subnetpools_rbac.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"1af907da56d5295122c5dd477765f4c85378a3fa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class RbacSubnetPoolsTest(base.BaseNetworkRbacTest):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_b8d0c9f7","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":25},"updated":"2017-03-02 16:24:45.000000000","message":"Following the naming convention we have been using for classes, it should be SubnetPoolsRbacTest","commit_id":"abccf3e14019bce4a7c658f9baa296e914fbc435"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"a77cc32e9a1f75be75aedee3a378ac4e5010408b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class RbacSubnetPoolsTest(base.BaseNetworkRbacTest):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_4c89cf74","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":25},"in_reply_to":"ba2be162_b8d0c9f7","updated":"2017-03-02 17:27:59.000000000","message":"Will fix","commit_id":"abccf3e14019bce4a7c658f9baa296e914fbc435"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e26685d6fd623595f6dc5f3124fd61f5e274634b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        subnetpool \u003d self._create_subnetpool()"},{"line_number":113,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":114,"context_line":"        self.subnetpools_client.update_subnetpool(subnetpool[\u0027id\u0027],"},{"line_number":115,"context_line":"                                                  min_prefixlen\u003d24)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":118,"context_line":"                                 rule\u003d\"delete_subnetpool\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_f701986b","line":115,"range":{"start_line":115,"start_character":50,"end_line":115,"end_character":66},"updated":"2017-03-02 03:58:29.000000000","message":"Does it matter whether this is the same value that was used during creation?","commit_id":"abccf3e14019bce4a7c658f9baa296e914fbc435"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b20dd1aa4ce90057f27793abd0bdd2eadf26f4b4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        subnetpool \u003d self._create_subnetpool()"},{"line_number":113,"context_line":"        rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":114,"context_line":"        self.subnetpools_client.update_subnetpool(subnetpool[\u0027id\u0027],"},{"line_number":115,"context_line":"                                                  min_prefixlen\u003d24)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":118,"context_line":"                                 rule\u003d\"delete_subnetpool\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_88f73ef4","line":115,"range":{"start_line":115,"start_character":50,"end_line":115,"end_character":66},"in_reply_to":"ba2be162_f701986b","updated":"2017-03-02 14:38:28.000000000","message":"No, it doesn\u0027t matter.  I tested it both ways. The update is hitting the update_subnetpool policy either way.","commit_id":"abccf3e14019bce4a7c658f9baa296e914fbc435"}]}