)]}'
{"patrole_tempest_plugin/tests/api/network/test_networks_multiprovider_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2f16dd5c6a70ee9195dcdc6cd8cbdc7bfd4d140b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_0bae61e7","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":26},"updated":"2017-03-06 16:29:33.000000000","message":"Unused.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_175d9e48","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":26},"in_reply_to":"ba2be162_0bae61e7","updated":"2017-03-06 18:06:35.000000000","message":"Will fix.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2f16dd5c6a70ee9195dcdc6cd8cbdc7bfd4d140b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":25,"context_line":"from patrole_tempest_plugin.tests.api.network import rbac_base as base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_7a5c0819","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":18},"updated":"2017-03-06 16:29:33.000000000","message":"Unused.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":25,"context_line":"from patrole_tempest_plugin.tests.api.network import rbac_base as base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_77541a21","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":18},"in_reply_to":"ba2be162_7a5c0819","updated":"2017-03-06 18:06:35.000000000","message":"Will fix.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"c228ae2c4a0adf28cad5f1b988f534ea87a412a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from patrole_tempest_plugin.tests.api.network import rbac_base as base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class NetworksMultiProviderRbacTest(base.BaseNetworkRbacTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_7ac24854","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":29},"updated":"2017-03-06 15:57:33.000000000","message":"unused.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from patrole_tempest_plugin.tests.api.network import rbac_base as base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class NetworksMultiProviderRbacTest(base.BaseNetworkRbacTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_1724bec4","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":29},"in_reply_to":"ba2be162_7ac24854","updated":"2017-03-06 18:06:35.000000000","message":"Will fix.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2f16dd5c6a70ee9195dcdc6cd8cbdc7bfd4d140b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_network_segments(self):"},{"line_number":45,"context_line":"        segments \u003d [{\"provider:network_type\": \"gre\"},"},{"line_number":46,"context_line":"                    {\"provider:network_type\": \"gre\"}]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        body \u003d self.networks_client.create_network("},{"line_number":49,"context_line":"            name\u003ddata_utils.rand_name(self.__class__.__name__),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_1a6b0cb8","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":52},"updated":"2017-03-06 16:29:33.000000000","message":"Redundant.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"52615e532f64a0350386ca595dc222f1b3ef84dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_network_segments(self):"},{"line_number":45,"context_line":"        segments \u003d [{\"provider:network_type\": \"gre\"},"},{"line_number":46,"context_line":"                    {\"provider:network_type\": \"gre\"}]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        body \u003d self.networks_client.create_network("},{"line_number":49,"context_line":"            name\u003ddata_utils.rand_name(self.__class__.__name__),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_324aad28","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":52},"in_reply_to":"ba2be162_02455e16","updated":"2017-03-06 18:57:18.000000000","message":"I thought it was typo. That\u0027s fine.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_network_segments(self):"},{"line_number":45,"context_line":"        segments \u003d [{\"provider:network_type\": \"gre\"},"},{"line_number":46,"context_line":"                    {\"provider:network_type\": \"gre\"}]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        body \u003d self.networks_client.create_network("},{"line_number":49,"context_line":"            name\u003ddata_utils.rand_name(self.__class__.__name__),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_02455e16","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":52},"in_reply_to":"ba2be162_1a6b0cb8","updated":"2017-03-06 18:06:35.000000000","message":"This is not redundant. This is to create 2 segments of the same network type. Without doing that, the network created will not have a segment attribute when doing the show/get command.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f795487a9a4583e57d70b284c45eb8bae471646b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        segments \u003d [{\"provider:network_type\": \"gre\"},"},{"line_number":46,"context_line":"                    {\"provider:network_type\": \"gre\"}]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        body \u003d self.networks_client.create_network("},{"line_number":49,"context_line":"            name\u003ddata_utils.rand_name(self.__class__.__name__),"},{"line_number":50,"context_line":"            segments\u003dsegments)"},{"line_number":51,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":53,"context_line":"                        self.networks_client.delete_network,"},{"line_number":54,"context_line":"                        network[\u0027id\u0027])"},{"line_number":55,"context_line":"        return network"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_3a87f0b5","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":38},"updated":"2017-03-06 16:06:21.000000000","message":"This can be replaced with Tempest\u0027s create_network","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        segments \u003d [{\"provider:network_type\": \"gre\"},"},{"line_number":46,"context_line":"                    {\"provider:network_type\": \"gre\"}]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        body \u003d self.networks_client.create_network("},{"line_number":49,"context_line":"            name\u003ddata_utils.rand_name(self.__class__.__name__),"},{"line_number":50,"context_line":"            segments\u003dsegments)"},{"line_number":51,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":53,"context_line":"                        self.networks_client.delete_network,"},{"line_number":54,"context_line":"                        network[\u0027id\u0027])"},{"line_number":55,"context_line":"        return network"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_621ffab7","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":38},"in_reply_to":"ba2be162_3a87f0b5","updated":"2017-03-06 18:06:35.000000000","message":"The difference between doing this way vs the cls.create_network is that, the cleanup will be triggered right after each test case is executed. This is my preference.  With the cls.create_network approach, the networks will be removed after all the test cases in the test class is completed.  If there isn\u0027t a strong reason, I will prefer leave it this way","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2f16dd5c6a70ee9195dcdc6cd8cbdc7bfd4d140b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # no NotFound or Forbidden exception are thrown.  Instead,"},{"line_number":100,"context_line":"        # the response will have an empty network body only."},{"line_number":101,"context_line":"        if len(response_network) \u003d\u003d 0:"},{"line_number":102,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_dfe5e6db","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":50},"updated":"2017-03-06 16:29:33.000000000","message":"May we provide a meaningful message here for the user?","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"c228ae2c4a0adf28cad5f1b988f534ea87a412a4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # If user does not have access to the network segments attribute,"},{"line_number":99,"context_line":"        # no NotFound or Forbidden exception are thrown.  Instead,"},{"line_number":100,"context_line":"        # the response will have an empty network body only."},{"line_number":101,"context_line":"        if len(response_network) \u003d\u003d 0:"},{"line_number":102,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_5a190421","line":102,"range":{"start_line":101,"start_character":8,"end_line":102,"end_character":50},"updated":"2017-03-06 15:57:33.000000000","message":"This is terrible (on Neutron\u0027s part, not yours).  It may be worthwhile to bring this up as a bug.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"c803a48fd51eed72c010ea2ee33a8049f1e1a74e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # no NotFound or Forbidden exception are thrown.  Instead,"},{"line_number":100,"context_line":"        # the response will have an empty network body only."},{"line_number":101,"context_line":"        if len(response_network) \u003d\u003d 0:"},{"line_number":102,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_a22f32a6","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":50},"in_reply_to":"ba2be162_02a39e50","updated":"2017-03-06 18:08:26.000000000","message":"Just some kind of debug message saying the same thing that your comment says.  Would be nice for them to not need to look at source code to get the message.","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ad220f88e10575af059fc07adbb23cbc654a62fb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # no NotFound or Forbidden exception are thrown.  Instead,"},{"line_number":100,"context_line":"        # the response will have an empty network body only."},{"line_number":101,"context_line":"        if len(response_network) \u003d\u003d 0:"},{"line_number":102,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_02a39e50","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":50},"in_reply_to":"ba2be162_dfe5e6db","updated":"2017-03-06 18:06:35.000000000","message":"I could but what kind of message you would like to put in here?","commit_id":"62d0539463f9a222212e59725e054ad614101dc5"}]}
