)]}'
{"patrole_tempest_plugin/tests/api/volume/test_volume_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ec8fa442b5f67cedaed0904be30c396acd25c0e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_d4118205","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"updated":"2017-03-10 18:17:02.000000000","message":"May we add a space above this and make this import testtools instead?\n\nI grepped through Tempest and found no occurrence of unittest.skipUnless being used, but found many, many such occurrences of testtools.skipUnless.","commit_id":"56d87a1c9c7b87df3e73196822c58df6cc8c8e98"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"da1a26a1faa17b361995c9d05291d122449155cf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_21b274e5","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"9a30ddce_d4118205","updated":"2017-03-13 14:06:14.000000000","message":"I\u0027ll make those changes.","commit_id":"56d87a1c9c7b87df3e73196822c58df6cc8c8e98"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ec8fa442b5f67cedaed0904be30c396acd25c0e7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_server(self):"},{"line_number":47,"context_line":"        body, _ \u003d compute.create_test_server(self.os, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":49,"context_line":"                        self.servers_client.delete_server, body[\u0027id\u0027])"},{"line_number":50,"context_line":"        return body"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _attach_volume(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_f4a686ac","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":70},"updated":"2017-03-10 18:17:02.000000000","message":"I don\u0027t have a problem with doing it like this, but I looked at the default implementation of create_server in volume base and it does the same thing:\n\n    def create_server(self, **kwargs):\n        name \u003d kwargs.pop(\n            \u0027name\u0027,\n            data_utils.rand_name(self.__class__.__name__ + \u0027-instance\u0027))\n\n        tenant_network \u003d self.get_tenant_network()\n        body, _ \u003d compute.create_test_server(\n            self.os,\n            tenant_network\u003dtenant_network,\n            name\u003dname,\n            **kwargs)","commit_id":"56d87a1c9c7b87df3e73196822c58df6cc8c8e98"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3a3c3e5f01dedac6048ac568ff6a02899fac379f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_server(self):"},{"line_number":47,"context_line":"        body, _ \u003d compute.create_test_server(self.os, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":49,"context_line":"                        self.servers_client.delete_server, body[\u0027id\u0027])"},{"line_number":50,"context_line":"        return body"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _attach_volume(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_8157a024","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":70},"in_reply_to":"9a30ddce_c1d5181c","updated":"2017-03-13 14:13:03.000000000","message":"That\u0027s fine.","commit_id":"56d87a1c9c7b87df3e73196822c58df6cc8c8e98"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"da1a26a1faa17b361995c9d05291d122449155cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_server(self):"},{"line_number":47,"context_line":"        body, _ \u003d compute.create_test_server(self.os, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":49,"context_line":"                        self.servers_client.delete_server, body[\u0027id\u0027])"},{"line_number":50,"context_line":"        return body"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _attach_volume(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_c1d5181c","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":70},"in_reply_to":"9a30ddce_f4a686ac","updated":"2017-03-13 14:06:14.000000000","message":"I was encountering an issue with volume base\u0027s create_server during cleanup; instead of deleting the server, it would enter an ERROR state after a few seconds and the tests would fail. This issue may have been resolved, but if it hasn\u0027t, then I think for now this should stay.","commit_id":"56d87a1c9c7b87df3e73196822c58df6cc8c8e98"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"18c514824e9a2d6bd61309a9321b2a59f1d52f6b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Get attachment"},{"line_number":97,"context_line":"        self.client.show_volume(self.volume[\u0027id\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @testtools.skipTest(\"Patrole bug #1672799\")"},{"line_number":100,"context_line":"    # @testtools.skipUnless(CONF.service_available.glance,"},{"line_number":101,"context_line":"    #                       \"Glance is needed to create an image\")"},{"line_number":102,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":17,"id":"3a1ff146_a4d2d732","line":99,"range":{"start_line":99,"start_character":3,"end_line":99,"end_character":47},"updated":"2017-03-14 17:31:37.000000000","message":"@testtools.skipIf(True, ...)","commit_id":"9f3642d34f15b15e6cbb1d754b1514ff50e41034"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6c0548e062ff9400ea085a80b03e7724b83b0d4c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.client.show_volume(self.volume[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @testtools.skipIf(True, \"Patrole bug #1672799\")"},{"line_number":96,"context_line":"    # @testtools.skipUnless(CONF.service_available.glance,"},{"line_number":97,"context_line":"    #                       \"Glance is needed to create an image\")"},{"line_number":98,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","},{"line_number":99,"context_line":"                                 rule\u003d\"volume:copy_volume_to_image\")"},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u0027b0d0da46-903c-4445-893e-20e680d68b50\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a1ff146_a95a8781","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":66},"updated":"2017-03-15 14:39:24.000000000","message":"May we remove this?","commit_id":"498fdf3e5e5facda03624231996348a24364a101"}]}
