)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"2bd552738ceee5ce3c7f6026abb3857c28852e60","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-02-19 13:45:41 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RBAC test cases for the following server actions:"},{"line_number":8,"context_line":"os_compute_api:servers:index"},{"line_number":9,"context_line":"os_compute_api:servers:index:get_all_tenants"},{"line_number":10,"context_line":"os_compute_api:servers:detail"},{"line_number":11,"context_line":"os_compute_api:servers:detail:get_all_tenants"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1ff146_156f1ec6","line":8,"updated":"2017-03-15 19:19:35.000000000","message":"missing double new line between ln 7 and 8.","commit_id":"b72786be3fa93b4687c9c5c60a81e18480c507cd"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e277570c2462013952ed1109acd9b871dcc14c50","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chi Lo \u003ccl566n@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-19 15:36:27 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RBAC test cases for the following server actions:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_compute_api:servers:index"},{"line_number":10,"context_line":"os_compute_api:servers:index:get_all_tenants"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a1ff146_690dda3d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"updated":"2017-03-15 23:05:47.000000000","message":"Can we keep this line and instead use a title like this instead:\n\n\"Enhance test_server_actions_rbac with index/detail/show server actions.\"","commit_id":"2377843f3c246128cf3993a6338b98e12508e479"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"c1bd121fd4087ffb5fd7bbe61dc3328ab4281312","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chi Lo \u003ccl566n@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-19 15:36:27 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RBAC test cases for the following server actions:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_compute_api:servers:index"},{"line_number":10,"context_line":"os_compute_api:servers:index:get_all_tenants"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a1ff146_2acbb773","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"3a1ff146_690dda3d","updated":"2017-03-16 14:44:38.000000000","message":"Yes, added this line in the latest submit.","commit_id":"2377843f3c246128cf3993a6338b98e12508e479"}],"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8410bbbe6ed8d984c4f4e42450fca97f81d91f1c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(ServerActionsRbacTest, cls).skip_checks()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_20213aa0","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":55},"updated":"2017-03-15 19:45:46.000000000","message":"Unnecessary since all you\u0027re doing is calling super-class method.\n\nWhile other compute test classes might do something like test.is_extension_enabled(\u0027rule\u0027, \u0027compute\u0027), this doesn\u0027t apply here this this test consists of many different tests that have different dependencies (so @testtools.skipUnless(CONF....) is better.","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e343dbcdc52c654db46dfcc08db0f2a847f03b31","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(ServerActionsRbacTest, cls).skip_checks()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_80c66e47","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":55},"in_reply_to":"3a1ff146_20213aa0","updated":"2017-03-15 19:59:39.000000000","message":"Will fix","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8410bbbe6ed8d984c4f4e42450fca97f81d91f1c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":69,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def tearDown(self):"},{"line_number":72,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":73,"context_line":"        super(ServerActionsRbacTest, self).tearDown()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _test_start_server(self):"},{"line_number":76,"context_line":"        self.client.start_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_752132b4","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":53},"updated":"2017-03-15 19:45:46.000000000","message":"Remove this (very recent change), because of this recently merged patch: https://review.openstack.org/#/c/444994/","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e343dbcdc52c654db46dfcc08db0f2a847f03b31","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":69,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def tearDown(self):"},{"line_number":72,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":73,"context_line":"        super(ServerActionsRbacTest, self).tearDown()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _test_start_server(self):"},{"line_number":76,"context_line":"        self.client.start_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_4002b670","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":53},"in_reply_to":"3a1ff146_752132b4","updated":"2017-03-15 19:59:39.000000000","message":"Will fix","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8410bbbe6ed8d984c4f4e42450fca97f81d91f1c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    # This class has test case(s) that requires at least version 2.16."},{"line_number":221,"context_line":"    #"},{"line_number":222,"context_line":"    # See the following link for details:"},{"line_number":223,"context_line":"    # https://developer.openstack.org/api-ref/compute/"},{"line_number":224,"context_line":"    # ?expanded\u003dshow-server-details-detail"},{"line_number":225,"context_line":"    min_microversion \u003d \u00272.16\u0027"},{"line_number":226,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_604c1243","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":42},"updated":"2017-03-15 19:45:46.000000000","message":"May we change this to:\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html#show-server-details\n\nIt\u0027s how QA likes to format it in Tempest.","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e343dbcdc52c654db46dfcc08db0f2a847f03b31","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    # This class has test case(s) that requires at least version 2.16."},{"line_number":221,"context_line":"    #"},{"line_number":222,"context_line":"    # See the following link for details:"},{"line_number":223,"context_line":"    # https://developer.openstack.org/api-ref/compute/"},{"line_number":224,"context_line":"    # ?expanded\u003dshow-server-details-detail"},{"line_number":225,"context_line":"    min_microversion \u003d \u00272.16\u0027"},{"line_number":226,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_a0fd2a3c","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":42},"in_reply_to":"3a1ff146_604c1243","updated":"2017-03-15 19:59:39.000000000","message":"Will fix","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8410bbbe6ed8d984c4f4e42450fca97f81d91f1c","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":255,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def tearDown(self):"},{"line_number":258,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":259,"context_line":"        super(ServerActionsV216RbacTest, self).tearDown()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @rbac_rule_validation.action("},{"line_number":262,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_e05e42e8","line":259,"range":{"start_line":257,"start_character":0,"end_line":259,"end_character":57},"updated":"2017-03-15 19:45:46.000000000","message":"Remove for same reason as mentioned before.","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e343dbcdc52c654db46dfcc08db0f2a847f03b31","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":255,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def tearDown(self):"},{"line_number":258,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dFalse)"},{"line_number":259,"context_line":"        super(ServerActionsV216RbacTest, self).tearDown()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @rbac_rule_validation.action("},{"line_number":262,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_a0944ae2","line":259,"range":{"start_line":257,"start_character":0,"end_line":259,"end_character":57},"in_reply_to":"3a1ff146_e05e42e8","updated":"2017-03-15 19:59:39.000000000","message":"Will fix","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8410bbbe6ed8d984c4f4e42450fca97f81d91f1c","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        if \u0027host_status\u0027 not in server:"},{"line_number":270,"context_line":"            LOG.info(\"host_status attribute not returned when role doesn\u0027t \""},{"line_number":271,"context_line":"                     \"have privilege to access it.\")"},{"line_number":272,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_c068668a","line":271,"range":{"start_line":271,"start_character":27,"end_line":271,"end_character":36},"updated":"2017-03-15 19:45:46.000000000","message":"May we change this to \"permissions\"?","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e343dbcdc52c654db46dfcc08db0f2a847f03b31","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        if \u0027host_status\u0027 not in server:"},{"line_number":270,"context_line":"            LOG.info(\"host_status attribute not returned when role doesn\u0027t \""},{"line_number":271,"context_line":"                     \"have privilege to access it.\")"},{"line_number":272,"context_line":"            raise rbac_exceptions.RbacActionFailed"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_0067de25","line":271,"range":{"start_line":271,"start_character":27,"end_line":271,"end_character":36},"in_reply_to":"3a1ff146_c068668a","updated":"2017-03-15 19:59:39.000000000","message":"Will fix","commit_id":"64986a267d3218a65970ad4dedee197d116deb40"}]}