)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"20b240679d74a193e59ab9f269874b938cd83215","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for Keystone OS-FEDERATION API v3 roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- migrate out common clients and internal methods to the base"},{"line_number":10,"context_line":"- fixes to projects rbac test to use tempest base instead"},{"line_number":11,"context_line":"- using the setups in tempest identity base instead of internals"},{"line_number":12,"context_line":"- Migrating the identity roles rbac tempest test to Patrole"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: REDDY, HEMACHANDRA \u003chr858f@att.com\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_562a792d","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":59},"updated":"2017-03-15 22:01:48.000000000","message":"This commit message is somewhat confusing.  It implies that you are migrating and fixing things, but the tests added are entirely new to Patrole.  I would remove the extra details, and just say \"adds new tests to Patrole\" and describe what the tests do or what they are for.","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3f32d85c2c0581d6b219ce002fa4658b58dc4f36","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- using the setups in tempest identity base instead of internals"},{"line_number":12,"context_line":"- Migrating the identity roles rbac tempest test to Patrole"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: REDDY, HEMACHANDRA \u003chr858f@att.com\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie3fba56b3532e9c43579e28ac151b2a869380644"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_2c5930ff","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":51},"updated":"2017-03-15 23:16:39.000000000","message":"Hemachandra Reddy \u003chr858f@att.com\u003e","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"ae43989bebb1c4b923d6727b37076fc022822235","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a1ced50_3087e562","updated":"2017-03-17 14:56:35.000000000","message":"Please include a depends on tag.\n\nPlease refer to this example:\nhttps://review.openstack.org/gitweb?p\u003dopenstack/patrole.git;a\u003dcommit;h\u003d8deb578d6cd216c6c1b0a8c59d275242c82400b4","commit_id":"3b8de4a2fa920d320e1b5a1a8fbaa78fe0a93771"}],"patrole_tempest_plugin/tests/api/identity/v3/test_mappings_rbac.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7a7d049a391972805f72004813f67b4c9890e225","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 ATT Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_d3e11b9c","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":20},"updated":"2017-03-15 21:53:02.000000000","message":"AT\u0026T","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9b68644a58c944b085b0c51218e2d0ab4b424250","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":21,"context_line":"from patrole_tempest_plugin.tests.api.identity.v3 import rbac_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IdentityMappingsV3AdminRbacTest("},{"line_number":25,"context_line":"        rbac_base.BaseIdentityV3RbacAdminTest):"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_2c585032","line":23,"updated":"2017-03-15 23:08:12.000000000","message":"May we add @decorators.skip_because(bug\u003d\"1672817\") here instead since we\u0027re skipping the entire test class? And then remove @decorators.skip_because(bug\u003d\"1672817\") from above each individual test.","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7a7d049a391972805f72004813f67b4c9890e225","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd132\u0027)"},{"line_number":46,"context_line":"    def test_create_mapping(self):"},{"line_number":47,"context_line":"        \"\"\"Create Mapping Test.\"\"\""},{"line_number":48,"context_line":"        federation_unique_id \u003d data_utils.rand_uuid()"},{"line_number":49,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":50,"context_line":"        self._create_mapping(federation_unique_id, self.rules)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_937323e7","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":53},"updated":"2017-03-15 21:53:02.000000000","message":"this can be included in  _create_mapping()","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7a7d049a391972805f72004813f67b4c9890e225","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd133\u0027)"},{"line_number":56,"context_line":"    def test_update_mapping(self):"},{"line_number":57,"context_line":"        \"\"\"Update Mapping Test.\"\"\""},{"line_number":58,"context_line":"        federation_unique_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"        mapping \u003d self._create_mapping(federation_unique_id, self.rules)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        updated_local_rule \u003d [{\"user\": {\"name\": \"{0}\"}},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_33134f68","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":53},"updated":"2017-03-15 21:53:02.000000000","message":"this can be included in _create_mapping()","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7a7d049a391972805f72004813f67b4c9890e225","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd134\u0027)"},{"line_number":74,"context_line":"    def test_delete_mapping(self):"},{"line_number":75,"context_line":"        \"\"\"Delete Mapping Test.\"\"\""},{"line_number":76,"context_line":"        federation_unique_id \u003d data_utils.rand_uuid()"},{"line_number":77,"context_line":"        mapping \u003d self._create_mapping(federation_unique_id, self.rules)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_7614d543","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":53},"updated":"2017-03-15 21:53:02.000000000","message":"this can be included in _create_mapping()","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7a7d049a391972805f72004813f67b4c9890e225","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd135\u0027)"},{"line_number":86,"context_line":"    def test_get_mapping(self):"},{"line_number":87,"context_line":"        \"\"\"Get Mapping Test.\"\"\""},{"line_number":88,"context_line":"        federation_unique_id \u003d data_utils.rand_uuid()"},{"line_number":89,"context_line":"        mapping \u003d self._create_mapping(federation_unique_id, self.rules)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_36217da0","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":53},"updated":"2017-03-15 21:53:02.000000000","message":"this can be included in _create_mapping()","commit_id":"76f4c27dc697863cbe19450511ccc2cf0e6a1480"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"ae43989bebb1c4b923d6727b37076fc022822235","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from patrole_tempest_plugin.tests.api.identity.v3 import rbac_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@decorators.skip_because(bug\u003d\"1672817\")"},{"line_number":25,"context_line":"class IdentityMappingsV3AdminRbacTest("},{"line_number":26,"context_line":"        rbac_base.BaseIdentityV3RbacAdminTest):"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_50caa1a2","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"updated":"2017-03-17 14:56:35.000000000","message":"I don\u0027t think we should merge tests without the clients being ready for these two reasons:\nA) we can\u0027t verify if the tests are all passing\nB) we will have to remember to go back to remove this skip_becuase","commit_id":"3b8de4a2fa920d320e1b5a1a8fbaa78fe0a93771"}]}