)]}'
{"patrole_tempest_plugin/tests/api/identity/v3/test_domains.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8d8af22667a535c2835412dcb4827c5547565d0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_update_domain(self):"},{"line_number":35,"context_line":"        domain \u003d self.setup_test_domain()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        new_domain_name \u003d self.rbac_random_name(\u0027test_update_domain\u0027)"},{"line_number":38,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.domains_client.update_domain(domain[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_8f1a586d","line":37,"range":{"start_line":37,"start_character":31,"end_line":37,"end_character":47},"updated":"2017-03-16 19:41:41.000000000","message":"I saw this in your refactor and forgot to mention it. Just use data_utils.rand_name. Also remove this from your refactor. Plus this is throwing an AttributeError here since your refactor hasn\u0027t been merged.","commit_id":"08d341ba7c98d27e5531f15b9a74020ab1e958c7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8d8af22667a535c2835412dcb4827c5547565d0b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":71,"context_line":"        self.domains_client.list_domains()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# TODO(nhelgeson): The below tests require client support missing in tempest"},{"line_number":74,"context_line":"# (originally found in mos-tempesnt identity_client)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":77,"context_line":"    #                              rule\u003d\"identity:create_domain_config\")"},{"line_number":78,"context_line":"    # @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd115\u0027)"},{"line_number":79,"context_line":"    # def test_create_domain_config(self):"},{"line_number":80,"context_line":"    #     \"\"\"Create a Credential."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    #     RBAC test for Keystone: identity:create_credential"},{"line_number":83,"context_line":"    #     \"\"\""},{"line_number":84,"context_line":"    #     domain_name \u003d self.rbac_random_name(\u0027test_create_domain_config\u0027)"},{"line_number":85,"context_line":"    #     domain \u003d self._create_domain(domain_name)"},{"line_number":86,"context_line":"    #     identity \u003d {\"driver\": \"ldap\"}"},{"line_number":87,"context_line":"    #     ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":88,"context_line":"    #             \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":89,"context_line":"    #     self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":90,"context_line":"    #     self.client.create_domain_config(domain[\u0027id\u0027], identity\u003didentity,"},{"line_number":91,"context_line":"    #                                          ldap\u003dldap)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":94,"context_line":"    #                              rule\u003d\"identity:update_domain_config\")"},{"line_number":95,"context_line":"    # @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd116\u0027)"},{"line_number":96,"context_line":"    # def test_update_domain_config(self):"},{"line_number":97,"context_line":"    #     \"\"\"Create a Credential."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    #     RBAC test for Keystone: identity:create_credential"},{"line_number":100,"context_line":"    #     \"\"\""},{"line_number":101,"context_line":"    #     domain_name \u003d self.rbac_random_name(\u0027test_update_domain_config\u0027)"},{"line_number":102,"context_line":"    #     domain \u003d self._create_domain(domain_name)"},{"line_number":103,"context_line":"    #     identity \u003d {\"driver\": \"ldap\"}"},{"line_number":104,"context_line":"    #     ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":105,"context_line":"    #             \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":106,"context_line":"    #     self.client.create_domain_config(domain[\u0027id\u0027], identity\u003didentity,"},{"line_number":107,"context_line":"    #                                      ldap\u003dldap)"},{"line_number":108,"context_line":"    #     new_ldap \u003d {\"url\": \"ldap://myldap-new.com:389/\","},{"line_number":109,"context_line":"    #                 \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":110,"context_line":"    #     self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":111,"context_line":"    #     self.client.update_domain_config(domain[\u0027id\u0027], ldap\u003dnew_ldap)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":114,"context_line":"    #                              rule\u003d\"identity:delete_domain_config\")"},{"line_number":115,"context_line":"    # @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd117\u0027)"},{"line_number":116,"context_line":"    # def test_delete_domain_config(self):"},{"line_number":117,"context_line":"    #     \"\"\"Create a Credential."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    #     RBAC test for Keystone: identity:create_credential"},{"line_number":120,"context_line":"    #     \"\"\""},{"line_number":121,"context_line":"    #     domain_name \u003d self.rbac_random_name(\u0027test_delete_domain_config\u0027)"},{"line_number":122,"context_line":"    #     domain \u003d self._create_domain(domain_name)"},{"line_number":123,"context_line":"    #     identity \u003d {\"driver\": \"ldap\"}"},{"line_number":124,"context_line":"    #     ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":125,"context_line":"    #             \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":126,"context_line":"    #     self.client.create_domain_config(domain[\u0027id\u0027], identity\u003didentity,"},{"line_number":127,"context_line":"    #                                      ldap\u003dldap)"},{"line_number":128,"context_line":"    #     self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":129,"context_line":"    #     self.client.delete_domain_config(domain[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":132,"context_line":"    #                              rule\u003d\"identity:get_domain_config\")"},{"line_number":133,"context_line":"    # @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd118\u0027)"},{"line_number":134,"context_line":"    # def test_get_domain_config(self):"},{"line_number":135,"context_line":"    #     \"\"\"Create a Credential."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    #     RBAC test for Keystone: identity:create_credential"},{"line_number":138,"context_line":"    #     \"\"\""},{"line_number":139,"context_line":"    #     domain_name \u003d self.rbac_random_name(\u0027test_create_domain_config\u0027)"},{"line_number":140,"context_line":"    #     domain \u003d self._create_domain(domain_name)"},{"line_number":141,"context_line":"    #     identity \u003d {\"driver\": \"ldap\"}"},{"line_number":142,"context_line":"    #     ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":143,"context_line":"    #             \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":144,"context_line":"    #     self.client.create_domain_config(domain[\u0027id\u0027], identity\u003didentity,"},{"line_number":145,"context_line":"    #                                      ldap\u003dldap)"},{"line_number":146,"context_line":"    #     self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":147,"context_line":"    #     self.client.get_domain_config(domain[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_6c060a22","line":147,"range":{"start_line":73,"start_character":0,"end_line":147,"end_character":53},"updated":"2017-03-16 19:41:41.000000000","message":"Don\u0027t comment this all out. Use @testtools.skipIf(True, \"You reasoning here\") or @decorators.skip_because(bug\u003d\"Your bug number if you have one\")","commit_id":"08d341ba7c98d27e5531f15b9a74020ab1e958c7"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"6a187b0294a62909b5d8c80f00a439c7a6c6dd1b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        identity \u003d {\"driver\": \"ldap\"}"},{"line_number":28,"context_line":"        ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":29,"context_line":"                \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":30,"context_line":"        self.client.create_domain_config(domain[\u0027id\u0027], identity\u003didentity,"},{"line_number":31,"context_line":"                                         ldap\u003dldap)"},{"line_number":32,"context_line":"        return domain[\u0027id\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":35,"context_line":"                                 rule\u003d\"identity:create_domain\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_70bd3ed7","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":27},"updated":"2017-03-22 14:25:57.000000000","message":"Is this something that needs to be cleaned up or is it deleted automatically when the domain is deleted?","commit_id":"136f412305faadb602df971ec58c9c8f3599842b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"06149f438fdd2c273ab87550be1dcbe3d629ad39","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":81,"context_line":"        self.domains_client.list_domains()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.skip_because(bug\u003d1673858)"},{"line_number":84,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":85,"context_line":"                                 rule\u003d\"identity:create_domain_config\")"},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd115\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_c7f93082","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":41},"updated":"2017-03-20 21:12:28.000000000","message":"This is throwing an AttributeError -- \"AttributeError: \u0027int\u0027 object has no attribute \u0027isdigit\u0027\" -- in the logs. Check Tempest to see how this should be used.\n\nThe bug should be a string, not an int.","commit_id":"136f412305faadb602df971ec58c9c8f3599842b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9779dba779949768e3761dc2ef8926c1ec7a37b7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd111\u0027)"},{"line_number":48,"context_line":"    def test_update_domain(self):"},{"line_number":49,"context_line":"        domain \u003d self.setup_test_domain()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        new_domain_name \u003d data_utils.rand_name(\u0027test_update_domain\u0027)"},{"line_number":52,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.domains_client.update_domain(domain[\u0027id\u0027],"},{"line_number":55,"context_line":"                                          domain\u003ddomain,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_6cb8bdc7","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":64},"updated":"2017-03-24 18:14:48.000000000","message":"nit: New lines are inconsistent here with your other tests.","commit_id":"2d13a498c18c2e651317a82eff6116d5e170fb8c"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9779dba779949768e3761dc2ef8926c1ec7a37b7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        ldap \u003d {\"url\": \"ldap://myldap.com:389/\","},{"line_number":95,"context_line":"                \"user_tree_dn\": \"ou\u003dUsers,dc\u003dmy_new_root,dc\u003dorg\"}"},{"line_number":96,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":97,"context_line":"        self.client.create_domain_config(domain[\u0027id\u0027],"},{"line_number":98,"context_line":"                                         identity\u003didentity,"},{"line_number":99,"context_line":"                                         ldap\u003dldap)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @decorators.skip_because(bug\u003d\u00271673858\u0027)"},{"line_number":102,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_4c94d937","line":99,"range":{"start_line":97,"start_character":8,"end_line":99,"end_character":51},"updated":"2017-03-24 18:14:48.000000000","message":"Add\n\nself.addCleanup(test_utils.call_and_ignore_notfound_exc,\n                self.client.delete_domain_config,\n                domain[\u0027id\u0027])\nbelow this.\n\nI assume you need it because your _create_domain_config function has it.","commit_id":"2d13a498c18c2e651317a82eff6116d5e170fb8c"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"aa291757ac6ca9001859ae50c2a9b452bbcda33b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":81,"context_line":"        self.domains_client.list_domains()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.skip_because(bug\u003d\u00271673858\u0027)"},{"line_number":84,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":85,"context_line":"                                 rule\u003d\"identity:create_domain_config\")"},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00276bdaecd4-0843-4ed6-ab64-3a57ab0cd115\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_44406008","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":43},"updated":"2017-03-30 17:31:46.000000000","message":"Marking as WIP because of this. This will introduce future technical debt if these tests don\u0027t pass even after the endpoints are added to Tempest.","commit_id":"3341e978334a894e005f8418b5e5dc00faaaf32c"}]}
