)]}'
{"patrole_tempest_plugin/tests/api/network/test_ports_rbac.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35e61f40bf97989ad5691c4a231748f8fe1d611b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":174,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        except exceptions.NotFound as e:"},{"line_number":177,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":178,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":179,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":180,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":183,"context_line":"                                 rule\u003d\"get_port:binding:vif_details\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_268654db","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":53},"updated":"2017-03-21 20:21:56.000000000","message":"This commit will go into merge conflict once the decorator enhancement is merged. Having said that do you plan on having a difference except block as you are not looking for NotFound here?","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2691b398e0d866f5f4ad7e0ed67eba0cb0866b27","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":174,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        except exceptions.NotFound as e:"},{"line_number":177,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":178,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":179,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":180,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":183,"context_line":"                                 rule\u003d\"get_port:binding:vif_details\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_2a27eeca","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":53},"in_reply_to":"1a1ced50_268654db","updated":"2017-03-22 02:11:37.000000000","message":"What\u0027s a \"difference except block\"? But you\u0027re right: the expected_exception\u003d404 doesn\u0027t apply in this case, and can be removed. Actually the rbac_rule_validation.action decorator will skip over \"except expected_exception\" and go to the \"except RbacActionFailed\" section in the try/except block. Speaking of which, the two blocks are identical and can be merged together.","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"f91fee9886c6662866b934a6b279c39b6b959337","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":174,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        except exceptions.NotFound as e:"},{"line_number":177,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":178,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":179,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":180,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":183,"context_line":"                                 rule\u003d\"get_port:binding:vif_details\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_f0fcceb9","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":53},"in_reply_to":"1a1ced50_2a27eeca","updated":"2017-03-22 14:22:55.000000000","message":"Sorry I had a typo, I meant \"different except block\"... I was under the impression that you were going to keep the \"try\" block, so my thought process was that if you still had the try, then you should update the exception you are trying to catch. Looking at your newest patch set, it looks like there is no \"try\" so please ignore this original comment.","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35e61f40bf97989ad5691c4a231748f8fe1d611b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":195,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        except exceptions.NotFound as e:"},{"line_number":198,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":199,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":200,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":201,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":204,"context_line":"                                 rule\u003d\"get_port:binding:host_id\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_265d7479","line":201,"range":{"start_line":197,"start_character":8,"end_line":201,"end_character":53},"updated":"2017-03-21 20:21:56.000000000","message":"same as above","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35e61f40bf97989ad5691c4a231748f8fe1d611b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":219,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        except exceptions.NotFound as e:"},{"line_number":222,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":223,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":224,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":225,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_864c68c9","line":224,"range":{"start_line":221,"start_character":8,"end_line":224,"end_character":62},"updated":"2017-03-21 20:21:56.000000000","message":"same as above","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35e61f40bf97989ad5691c4a231748f8fe1d611b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            if fields[0] not in retrieved_port:"},{"line_number":244,"context_line":"                raise rbac_exceptions.RbacActionFailed"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        except exceptions.NotFound as e:"},{"line_number":247,"context_line":"            LOG.info(\"NotFound exception caught. Exception is thrown when \""},{"line_number":248,"context_line":"                     \"role doesn\u0027t have access to the endpoint.\""},{"line_number":249,"context_line":"                     \"This is irregular and should be fixed.\")"},{"line_number":250,"context_line":"            raise rbac_exceptions.RbacActionFailed(e)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":253,"context_line":"                                 rule\u003d\"update_port\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_06cf9829","line":250,"range":{"start_line":246,"start_character":8,"end_line":250,"end_character":53},"updated":"2017-03-21 20:21:56.000000000","message":"same as above","commit_id":"8f8128f7e4ef4ca49bb4a8505e6275b658495b60"}]}
