)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"c4bc63d9e1348d437c4f6a8f87dbc40f976b8525","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-28 03:35:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_f5f9bbc7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2017-03-28 14:39:25.000000000","message":"Perhaps to rephrase to:\n\nCompute test for adding fixed IP","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"c4bc63d9e1348d437c4f6a8f87dbc40f976b8525","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"},{"line_number":11,"context_line":"also causes os-multinic policy action to be enforced."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Felipe Monteiro \u003cfm577c@att.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Michael Sliem \u003cms272s@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_35b3a30c","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"updated":"2017-03-28 14:39:25.000000000","message":"Perhaps mention why os_compute_api:os-fixed-ips action is being used and not os_compute_api:os-fixed-ips action","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c90f8ddd0eb814f09d45fb8cd49fc36c66e543aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"},{"line_number":11,"context_line":"also causes os-multinic policy action to be enforced."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Felipe Monteiro \u003cfm577c@att.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Michael Sliem \u003cms272s@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_78648222","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"ffe62b97_35b3a30c","updated":"2017-03-28 15:00:27.000000000","message":"I don\u0027t understand what that means. You repeated \"os_compute_api:os-fixed-ips\" twice. May you please clarify? Do you mean mention why os_compute_api:os-multinic is enforced instead of os_compute_api:os-fixed-ips?","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"f5ad3f9b7a7c3e44243a95c7c3734af0b663d06c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"},{"line_number":11,"context_line":"also causes os-multinic policy action to be enforced."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Felipe Monteiro \u003cfm577c@att.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Michael Sliem \u003cms272s@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_8b16ce48","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"ffe62b97_78648222","updated":"2017-03-28 15:05:02.000000000","message":"Do you mean mention why os_compute_api:os-multinic is enforced instead of os_compute_api:os-fixed-ips?\n\n-Yes, sorry for the confusion. In the original commit message, it says that the \u0027addFixedIp\u0027 action is exercised, so if that is indeed the case then I am just wondering why the test case wouldn\u0027t use that action.","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9b28d08ced2416b34e0b897c63a5e7c57d8d2915","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"},{"line_number":11,"context_line":"also causes os-multinic policy action to be enforced."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Felipe Monteiro \u003cfm577c@att.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Michael Sliem \u003cms272s@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_2ba222fd","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"ffe62b97_78648222","updated":"2017-03-28 15:04:47.000000000","message":"To answer the question I think you meant to ask, see: _add_fixed_ip in\n\nhttps://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/api/openstack/compute/multinic.py\n\nShould be self-explanatory. But a link to that resource should be added to this commit message.","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"e73bb4aea5089c5a808cca42f94c5dbaab137832","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Roles RBAC test for compute extension api os-multinic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027addFixedIp\u0027 action is exercised in this test case,"},{"line_number":10,"context_line":"which adds a fixed IP to the server instance. It"},{"line_number":11,"context_line":"also causes os-multinic policy action to be enforced."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Felipe Monteiro \u003cfm577c@att.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Michael Sliem \u003cms272s@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_cbda9676","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"ffe62b97_8b16ce48","updated":"2017-03-28 15:06:23.000000000","message":"ignore the last comment","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"}],"patrole_tempest_plugin/tests/api/compute/test_multinic_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"325af7a287199b3063c388bc04208b5f77b2064f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setup_clients(cls):"},{"line_number":28,"context_line":"        super(MultinicV21RbacTest, cls).setup_clients()"},{"line_number":29,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":30,"context_line":"        cls.ifc \u003d cls.interfaces_client"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ca754c64","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":39},"updated":"2017-03-22 21:39:40.000000000","message":"Not necessary.","commit_id":"c38c491c9d47e4272b2139472a5b0079dfe32dc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"325af7a287199b3063c388bc04208b5f77b2064f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        super(MultinicV21RbacTest, cls).resource_setup()"},{"line_number":42,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_server_get_interfaces(self):"},{"line_number":45,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        ifs \u003d (self.ifc.list_interfaces(server[\u0027id\u0027])"},{"line_number":47,"context_line":"               [\u0027interfaceAttachments\u0027])"},{"line_number":48,"context_line":"        return server, ifs"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @rbac_rule_validation.action("},{"line_number":51,"context_line":"        service\u003d\"nova\", rule\u003d\"os_compute_api:os-multinic\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ca4e2c3a","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":26},"updated":"2017-03-22 21:39:40.000000000","message":"This isn\u0027t needed since you already create a class-level server above.","commit_id":"c38c491c9d47e4272b2139472a5b0079dfe32dc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"325af7a287199b3063c388bc04208b5f77b2064f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027bd3e2c74-130a-40f0-8085-124d93fe67da\u0027)"},{"line_number":53,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":54,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":55,"context_line":"        server, ifs \u003d self._create_server_get_interfaces()"},{"line_number":56,"context_line":"        network_id \u003d ifs[0][\u0027net_id\u0027]"},{"line_number":57,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":58,"context_line":"        self.client.add_fixed_ip(server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_8a40b408","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":58},"updated":"2017-03-22 21:39:40.000000000","message":"Just do\n\ninterfaces \u003d self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])\n\nhere.\n\nAlso use interfaces, not ifs, because it\u0027s a better variable name.","commit_id":"c38c491c9d47e4272b2139472a5b0079dfe32dc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"325af7a287199b3063c388bc04208b5f77b2064f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":54,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":55,"context_line":"        server, ifs \u003d self._create_server_get_interfaces()"},{"line_number":56,"context_line":"        network_id \u003d ifs[0][\u0027net_id\u0027]"},{"line_number":57,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":58,"context_line":"        self.client.add_fixed_ip(server[\u0027id\u0027],"},{"line_number":59,"context_line":"                                 networkId\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_8a0ef4e2","line":56,"range":{"start_line":56,"start_character":21,"end_line":56,"end_character":24},"updated":"2017-03-22 21:39:40.000000000","message":"interfaces","commit_id":"c38c491c9d47e4272b2139472a5b0079dfe32dc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a391561cfe759209a1e657a8e76789011fa54cd3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(MultinicV21RbacTest, cls).setup_clients()"},{"line_number":29,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(MultinicV21RbacTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.compute_feature_enabled.api_extensions:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027%s skipped as no compute extensions enabled\u0027 % cls.__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_0093c5fa","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":77},"updated":"2017-03-22 23:15:45.000000000","message":"Please follow the skip_checks present here: https://github.com/openstack/tempest/blob/6a826ab61b88d94cfeadaf998d0c17327d1cba9c/tempest/api/compute/servers/test_attach_interfaces.py\n\nWe need:\n\nif not CONF.service_available.neutron:\n    raise cls.skipException(\"Neutron is required\")\nif not CONF.compute_feature_enabled.interface_attach:\n    raise cls.skipException(\"Interface attachment is not available.\")\n\nAnd get rid of the current skip.","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a391561cfe759209a1e657a8e76789011fa54cd3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        if not CONF.compute_feature_enabled.api_extensions:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027%s skipped as no compute extensions enabled\u0027 % cls.__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def resource_setup(cls):"},{"line_number":40,"context_line":"        super(MultinicV21RbacTest, cls).resource_setup()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_6069d9f8","line":37,"updated":"2017-03-22 23:15:45.000000000","message":"Add\n\n    @classmethod\n    def setup_credentials(cls):\n        # This test class requires network and subnet\n        cls.set_network_resources(network\u003dTrue, subnet\u003dTrue)\n        super(AttachInterfacesTestJSON, cls).setup_credentials()","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a391561cfe759209a1e657a8e76789011fa54cd3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_2001a106","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"updated":"2017-03-22 23:15:45.000000000","message":"You probably need to create a port interface if one isn\u0027t present.\n\nWe should never not do an API call without throwing an exception. This test should not silently pass.","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":20809,"name":"Adnan Khan","email":"rk221s@att.com","username":"rao.adnan.khan"},"change_message_id":"4a237fe1039349147a43e8ff46749517e20d7bb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_c5a431bb","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"in_reply_to":"1a1ced50_2001a106","updated":"2017-03-23 19:26:24.000000000","message":"In my dev stack, the iface was already associated with the port, so I never ran into a case where the list it empty. Even if we consider the corner case, I think we should throw skipException, as opposed to adding an iface as create iface usecase is harnessed by test_interface_rbac.","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"9dea77900e43d9494371f25a86791b1a44579743","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_55d8dc51","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"in_reply_to":"1a1ced50_c5a431bb","updated":"2017-03-24 19:18:33.000000000","message":"I agree with Felipe in that we shouldn\u0027t have a test case that may or may not run based on the existence of some resource. I do not like the idea of a silent test pass if \u0027if interfaces\u0027 is false. I think we could do one of the following:\n\n1) figure out a way not to have this conditional check - possibly create a port interface in the test\n2) skip the test if no interface exists and give reason for the skip\n3) throw some kind of RBAC exception if the resource isn\u0027t present","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"739597984489dd6776ccd44eae84174ded787577","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_80c62067","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"in_reply_to":"ffe62b97_20ccf4ba","updated":"2017-03-24 19:50:43.000000000","message":"For #3, we could possibly use this?\nclass RbacResourceSetupFailed (exceptions.TempestException):\n    message \u003d \"Rbac resource setup failed\"","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":20809,"name":"Adnan Khan","email":"rk221s@att.com","username":"rao.adnan.khan"},"change_message_id":"29e08f88b7c7ba356eaddfedb50a8de38f024805","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_20ccf4ba","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"in_reply_to":"ffe62b97_55d8dc51","updated":"2017-03-24 19:47:28.000000000","message":"I vote to go with #2 to handle the exception case. \n\nOption #1 in my mind is not needed (based on my devstack testing) and #3 is not relevant as, even if this happens, it\u0027s not related to any RBAC related failure.","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":20809,"name":"Adnan Khan","email":"rk221s@att.com","username":"rao.adnan.khan"},"change_message_id":"24c6d17359af1c6df890a024b691378252da538b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":48,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":49,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":50,"context_line":"        if interfaces:"},{"line_number":51,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":52,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":53,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_61955ee4","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"in_reply_to":"ffe62b97_80c62067","updated":"2017-03-24 21:23:52.000000000","message":"Agreed! This seems more appropriate than skip!","commit_id":"ef2efcef47bc999eee92d840e6e8616b2227b952"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"1b216d5c3d37acfd94dbe70a519ae928cd10e728","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \"\"\"Add fixed IP to server.\"\"\""},{"line_number":55,"context_line":"        interfaces \u003d (self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])"},{"line_number":56,"context_line":"                      [\u0027interfaceAttachments\u0027])"},{"line_number":57,"context_line":"        if interfaces:"},{"line_number":58,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":59,"context_line":"            self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":60,"context_line":"            self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_f58810c7","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":22},"updated":"2017-03-24 19:31:29.000000000","message":"To me this should always evaluate to True, since in order to even boot a vm you have to have network attached to the vm.","commit_id":"f9e2f45ad7512e3492b7336f13b15cd42cdcdf83"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c90f8ddd0eb814f09d45fb8cd49fc36c66e543aa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class MultinicRbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_58f65e65","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":22},"updated":"2017-03-28 15:00:27.000000000","message":"This should be MultinicV210RbacTest","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":20809,"name":"Adnan Khan","email":"rk221s@att.com","username":"rao.adnan.khan"},"change_message_id":"5afdeda3bfed0b3ddab44717810ba873dcf6a32d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class MultinicRbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_a9d4fae9","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":22},"in_reply_to":"ffe62b97_58f65e65","updated":"2017-03-28 15:49:05.000000000","message":"I originally submitted as xxV21Rabc... not sure why it was reverted to this","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9cfa76f995cff92a496ac8a992227ca287475c4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class MultinicRbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_044ceb3f","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":22},"in_reply_to":"ffe62b97_a9d4fae9","updated":"2017-03-28 15:56:40.000000000","message":"It\u0027s only being changed to this name because of the minimum microversion that it corresponds to. It was deprecated in the 2.36 microversion, so this distinction is important.\n\nIn any case, it should be V210 not V21 (according to the convention I see throughout Tempest).","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c90f8ddd0eb814f09d45fb8cd49fc36c66e543aa","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class MultinicRbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"},{"line_number":29,"context_line":"        super(MultinicRbacTest, cls).setup_clients()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_f83f7222","line":26,"updated":"2017-03-28 15:00:27.000000000","message":"Actually, we need:\n\nmin_microversion \u003d \u00272.10\u0027\nmax_microversion \u003d \u00272.36\u0027 \n\nbeneath the class name.\n\nSee note in: https://developer.openstack.org/api-ref/compute/?expanded\u003dadd-associate-fixed-ip-addfixedip-action-detail","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"c4bc63d9e1348d437c4f6a8f87dbc40f976b8525","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        interfaces \u003d self.interfaces_client.list_interfaces(self.server[\u0027id\u0027])["},{"line_number":57,"context_line":"            \u0027interfaceAttachments\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if interfaces:"},{"line_number":60,"context_line":"            network_id \u003d interfaces[0][\u0027net_id\u0027]"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            network_id \u003d self.interfaces_client.create_interface("},{"line_number":63,"context_line":"                self.server[\u0027id\u0027])[\u0027interfaceAttachment\u0027][\u0027net_id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":66,"context_line":"        self.client.add_fixed_ip(self.server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_758b6b1e","line":63,"range":{"start_line":59,"start_character":7,"end_line":63,"end_character":67},"updated":"2017-03-28 14:39:25.000000000","message":"I believe this approach is much better as the test will always properly execute","commit_id":"f3548d1400e87d2ed95acd95c36a2741cebae814"}]}
