)]}'
{"contrib/post_test_hook.sh":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"68be39b7ebf827b5ce93a01f6aadd724b925b4d5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# Set rbac_test_role\u003d$RBAC_ROLE under [rbac] section in tempest.conf"},{"line_number":59,"context_line":"iniset $TEMPEST_CONFIG rbac rbac_test_role $RBAC_ROLE"},{"line_number":60,"context_line":"# Set strict_policy_check\u003dFalse under [rbac] section in tempest.conf"},{"line_number":61,"context_line":"iniset $TEMPEST_CONFIG rbac strict_policy_check False"},{"line_number":62,"context_line":"# Set additional, necessary CONF values"},{"line_number":63,"context_line":"iniset $TEMPEST_CONFIG auth use_dynamic_credentials True"},{"line_number":64,"context_line":"iniset $TEMPEST_CONFIG auth tempest_roles Member"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffe62b97_32832ecf","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":53},"updated":"2017-03-24 18:54:04.000000000","message":"This is a good workaround temporarily for certain services not including all their policy actions in their policy file. And I agree that it should be True by default in the config file, which it is.","commit_id":"0d88008a1ec99474b48c58856d6015a8a97ae6e0"}],"doc/source/installation.rst":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b6c2d9b898050ee08c992bdd79cce12dc3ee3b0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#. [rbac] section updates ::"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"       # The role that you want the RBAC tests to use for RBAC testing"},{"line_number":51,"context_line":"       # This needs to be edited to run the test as a different role. "},{"line_number":52,"context_line":"       rbac_test_role \u003d _member_"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"       # Enables RBAC Tempest tests if set to True. Otherwise, they are"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_cfab3bd4","line":51,"range":{"start_line":51,"start_character":69,"end_line":51,"end_character":70},"updated":"2017-03-24 18:29:33.000000000","message":"Extra space.","commit_id":"52373b734c5e667210b4646611752c67372fa418"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b6c2d9b898050ee08c992bdd79cce12dc3ee3b0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"       # The role that you want the RBAC tests to use for RBAC testing"},{"line_number":51,"context_line":"       # This needs to be edited to run the test as a different role. "},{"line_number":52,"context_line":"       rbac_test_role \u003d _member_"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"       # Enables RBAC Tempest tests if set to True. Otherwise, they are"},{"line_number":55,"context_line":"       # skipped."},{"line_number":56,"context_line":"       enable_rbac \u003d True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_4f896b73","line":53,"updated":"2017-03-24 18:29:33.000000000","message":"Include description for the new config option you made.","commit_id":"52373b734c5e667210b4646611752c67372fa418"}],"patrole_tempest_plugin/config.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"01b7b635097e1e07a58f21f684c2f036582f0997","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                default\u003dTrue,"},{"line_number":28,"context_line":"                help\u003d\"Enables RBAC tests.\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027strict_policy_check\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"If true, throws RbacParsingException for\""},{"line_number":32,"context_line":"                     \" policies which don\u0027t exist. If false, \""},{"line_number":33,"context_line":"                     \"throws skipException.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_a149e38b","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":29},"updated":"2017-03-27 17:54:12.000000000","message":"Felipe made a comment in post_test_hook.sh that this should be set to True by default. Just wondering if that is indeed the case?","commit_id":"0d88008a1ec99474b48c58856d6015a8a97ae6e0"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"dbc9e5a33bed62c31bce4a16eb822f5f972b1cb4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                default\u003dTrue,"},{"line_number":28,"context_line":"                help\u003d\"Enables RBAC tests.\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027strict_policy_check\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"If true, throws RbacParsingException for\""},{"line_number":32,"context_line":"                     \" policies which don\u0027t exist. If false, \""},{"line_number":33,"context_line":"                     \"throws skipException.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_9012a708","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":29},"in_reply_to":"ffe62b97_a149e38b","updated":"2017-03-27 19:10:39.000000000","message":"Currently, there are some policies that don\u0027t exist in a service\u0027s policy.json that we have tests for. For now, I think it\u0027s best to have this default to false, and then once those issues are resolved, change the default to true.","commit_id":"0d88008a1ec99474b48c58856d6015a8a97ae6e0"}],"patrole_tempest_plugin/tests/unit/test_rbac_rule_validation.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b6c2d9b898050ee08c992bdd79cce12dc3ee3b0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertIsNone(wrapper(self.mock_args))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @mock.patch.object(rbac_auth, \u0027rbac_policy_parser\u0027, autospec\u003dTrue)"},{"line_number":173,"context_line":"    def test_invalid_policy_rule_throws_parsiing_exception("},{"line_number":174,"context_line":"            self, mock_rbac_policy_parser):"},{"line_number":175,"context_line":"        mock_rbac_policy_parser.RbacPolicyParser.return_value.allowed.\\"},{"line_number":176,"context_line":"            side_effect \u003d rbac_exceptions.RbacParsingException"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_0f0ec333","line":173,"range":{"start_line":173,"start_character":40,"end_line":173,"end_character":48},"updated":"2017-03-24 18:29:33.000000000","message":"parsing","commit_id":"52373b734c5e667210b4646611752c67372fa418"}]}
