)]}'
{"patrole_tempest_plugin/tests/api/orchestration/test_events_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"38e3a63197152cdfc0f3d12e3f58580fd96d48e7","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return stack_identifier"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u002756c06e92-df96-47b5-bcf2-0104e74e2511\u0027)"},{"line_number":63,"context_line":"    @rbac_rule_validation.action(service\u003d\"heat\","},{"line_number":64,"context_line":"                                 rule\u003d\"events:index\")"},{"line_number":65,"context_line":"    def test_list_resource_types(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_307cc61d","line":62,"updated":"2017-03-28 19:19:53.000000000","message":"All idempotent ids in this file are the same","commit_id":"8f6052eca59cc7465c33e0c88d47ffa29d8d3b19"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dfa503764687582380748c3acfaab8721d55b51c","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return stack_identifier"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u002756c06e92-df96-47b5-bcf2-0104e74e2511\u0027)"},{"line_number":63,"context_line":"    @rbac_rule_validation.action(service\u003d\"heat\","},{"line_number":64,"context_line":"                                 rule\u003d\"events:index\")"},{"line_number":65,"context_line":"    def test_list_resource_types(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b9155342","line":62,"in_reply_to":"ffe62b97_307cc61d","updated":"2017-03-29 04:04:30.000000000","message":"Copy/paste for the win.","commit_id":"8f6052eca59cc7465c33e0c88d47ffa29d8d3b19"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"38e3a63197152cdfc0f3d12e3f58580fd96d48e7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                 rule\u003d\"events:index\")"},{"line_number":65,"context_line":"    def test_list_resource_types(self):"},{"line_number":66,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":67,"context_line":"        self.client.list_events(self.stack_identifier)[\u0027events\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u002756c06e92-df96-47b5-bcf2-0104e74e2511\u0027)"},{"line_number":70,"context_line":"    @rbac_rule_validation.action(service\u003d\"heat\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_709b6e65","line":67,"updated":"2017-03-28 19:19:53.000000000","message":"Would it be too confusing to have both list functions under the same switch_role and rename the test to something like test_list_resource_types_and_events? Since they test the same rule","commit_id":"8f6052eca59cc7465c33e0c88d47ffa29d8d3b19"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dfa503764687582380748c3acfaab8721d55b51c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                 rule\u003d\"events:index\")"},{"line_number":65,"context_line":"    def test_list_resource_types(self):"},{"line_number":66,"context_line":"        self.rbac_utils.switch_role(self, switchToRbacRole\u003dTrue)"},{"line_number":67,"context_line":"        self.client.list_events(self.stack_identifier)[\u0027events\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u002756c06e92-df96-47b5-bcf2-0104e74e2511\u0027)"},{"line_number":70,"context_line":"    @rbac_rule_validation.action(service\u003d\"heat\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_99396fd8","line":67,"in_reply_to":"ffe62b97_709b6e65","updated":"2017-03-29 04:04:30.000000000","message":"That\u0027s an interesting idea. This approach would be new. There are plenty of other places where such a design could be adopted. I\u0027m not opposed to it.","commit_id":"8f6052eca59cc7465c33e0c88d47ffa29d8d3b19"}]}
