)]}'
{"patrole_tempest_plugin/tests/api/identity/v3/test_policies_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ef2a1700176e27662790e75b9c308b811abfa3d3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u00279cfed3c6-0b27-4d15-be67-e06e0cfb01b9\u0027)"},{"line_number":35,"context_line":"    def test_update_policy(self):"},{"line_number":36,"context_line":"        policy \u003d self.setup_test_policy()"},{"line_number":37,"context_line":"        new_policy_type \u003d data_utils.rand_name(\u0027policy_type\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":40,"context_line":"        self.policies_client.update_policy(policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_8ec70a65","line":37,"updated":"2017-04-10 17:33:21.000000000","message":"nit: This name is a little confusing","commit_id":"5d2d02fbc23a6a6560f5eb1e72109a67c1707c41"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"90a2a28301824f8f4a026dfc3e04596085136466","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u00279cfed3c6-0b27-4d15-be67-e06e0cfb01b9\u0027)"},{"line_number":35,"context_line":"    def test_update_policy(self):"},{"line_number":36,"context_line":"        policy \u003d self.setup_test_policy()"},{"line_number":37,"context_line":"        new_policy_type \u003d data_utils.rand_name(\u0027policy_type\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":40,"context_line":"        self.policies_client.update_policy(policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_95003203","line":37,"in_reply_to":"bff0334d_8ec70a65","updated":"2017-04-10 17:39:22.000000000","message":"This change is out of scope. We can do that in a follow up patch.\n\nWhile correcting imports is fairly trivial, so I went ahead and did that, if we want to refactor tests to make them cleaner/clearer, we should submit another patch with those changes. Good to make a note of them here though (rather than nowhere).","commit_id":"5d2d02fbc23a6a6560f5eb1e72109a67c1707c41"}],"patrole_tempest_plugin/tests/api/identity/v3/test_roles_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ef2a1700176e27662790e75b9c308b811abfa3d3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.role[\u0027id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":112,"context_line":"                                 rule\u003d\"identity:revoke_grant\")"},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u00270f148510-63bf-11e6-1395-080044d0d90a\u0027)"},{"line_number":114,"context_line":"    def test_delete_role_from_user_on_project(self):"},{"line_number":115,"context_line":"        self.roles_client.create_user_role_on_project("}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_12fb1879","line":112,"updated":"2017-04-10 17:33:21.000000000","message":"There are multiple functions in this file that test the same policy (see L155). It would be nice if they were grouped and perhaps a comment emphasizing the way each function is slightly different (for example, this deletes a role from a user whereas the function on L155 deletes a role from a group).","commit_id":"5d2d02fbc23a6a6560f5eb1e72109a67c1707c41"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"90a2a28301824f8f4a026dfc3e04596085136466","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.role[\u0027id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":112,"context_line":"                                 rule\u003d\"identity:revoke_grant\")"},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u00270f148510-63bf-11e6-1395-080044d0d90a\u0027)"},{"line_number":114,"context_line":"    def test_delete_role_from_user_on_project(self):"},{"line_number":115,"context_line":"        self.roles_client.create_user_role_on_project("}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_122678cf","line":112,"in_reply_to":"bff0334d_12fb1879","updated":"2017-04-10 17:39:22.000000000","message":"This change is out of scope. We can do that in a follow up patch.","commit_id":"5d2d02fbc23a6a6560f5eb1e72109a67c1707c41"}]}