)]}'
{"patrole_tempest_plugin/tests/api/volume/test_volume_actions_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"cd4a03d4db16b1c0277786a7ebf3d9e390648213","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027b0d0da46-903c-4445-893e-20e680d68b50\u0027)"},{"line_number":88,"context_line":"    def test_volume_upload(self):"},{"line_number":89,"context_line":"        # TODO(felipemonteiro): The policy action \"volume:copy_volume_to_image\""},{"line_number":90,"context_line":"        # is currently not included in Cinder\u0027s policy.json and so must be. In"},{"line_number":91,"context_line":"        # addition, this API should be moved somewhere else, as it is not"},{"line_number":92,"context_line":"        # included in Cinder\u0027s volume actions API."},{"line_number":93,"context_line":"        self.image_client \u003d self.os.image_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_537a5524","line":90,"range":{"start_line":90,"start_character":59,"end_line":90,"end_character":74},"updated":"2017-04-14 19:06:43.000000000","message":"nit: This can be removed to make the message a little clearer.","commit_id":"0b4f860116a28c3d996623538f2b396a93c66175"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f65a302e8044d4250f389311b3697343ac71e525","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027b0d0da46-903c-4445-893e-20e680d68b50\u0027)"},{"line_number":88,"context_line":"    def test_volume_upload(self):"},{"line_number":89,"context_line":"        # TODO(felipemonteiro): The policy action \"volume:copy_volume_to_image\""},{"line_number":90,"context_line":"        # is currently not included in Cinder\u0027s policy.json and so must be. In"},{"line_number":91,"context_line":"        # addition, this API should be moved somewhere else, as it is not"},{"line_number":92,"context_line":"        # included in Cinder\u0027s volume actions API."},{"line_number":93,"context_line":"        self.image_client \u003d self.os.image_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_132bad94","line":90,"range":{"start_line":90,"start_character":59,"end_line":90,"end_character":74},"in_reply_to":"7ffa3b31_537a5524","updated":"2017-04-14 19:43:56.000000000","message":"Done","commit_id":"0b4f860116a28c3d996623538f2b396a93c66175"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"8497d393a895617bd49b8ee308fcb7e15f432ea6","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    @rbac_rule_validation.action("},{"line_number":140,"context_line":"        service\u003d\"cinder\","},{"line_number":141,"context_line":"        rule\u003d\"volume_extension:volume_unmanage\")"},{"line_number":142,"context_line":"    def test_unmanage_volume(self):"},{"line_number":143,"context_line":"        volume \u003d self.create_volume()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_c5d9da83","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":28},"updated":"2017-04-17 14:22:02.000000000","message":"should there be a addCleanup to toggle this volume back to being managed?","commit_id":"195f30ddbd7b58b94b73fcd29a79922e8f3e3db0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d5901486e410f7d43a53f845f918250537dcdd1b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    @rbac_rule_validation.action("},{"line_number":140,"context_line":"        service\u003d\"cinder\","},{"line_number":141,"context_line":"        rule\u003d\"volume_extension:volume_unmanage\")"},{"line_number":142,"context_line":"    def test_unmanage_volume(self):"},{"line_number":143,"context_line":"        volume \u003d self.create_volume()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_b5b8462a","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":28},"in_reply_to":"7ffa3b31_c5d9da83","updated":"2017-04-25 01:55:19.000000000","message":"I\u0027m creating a local volume, so no. I didn\u0027t want to use the class volume to do unmanage then manage because it seems overly complicated when a local volume can just be created.","commit_id":"195f30ddbd7b58b94b73fcd29a79922e8f3e3db0"}],"patrole_tempest_plugin/tests/api/volume/test_volume_basic_crud_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"cd4a03d4db16b1c0277786a7ebf3d9e390648213","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rbac_rule_validation.action("},{"line_number":59,"context_line":"        service\u003d\"cinder\","},{"line_number":60,"context_line":"        rule\u003d\"volume_extension:volume_image_metadata\")"},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":62,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":63,"context_line":"        # Get a list of Volumes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_93b69dd9","side":"PARENT","line":60,"updated":"2017-04-14 19:06:43.000000000","message":"So we won\u0027t be testing this at all? Or are you planning to propose a more meaningful way of testing it?","commit_id":"4fc9a6b4bcbad1df306a7f08f84860e5abe22213"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f65a302e8044d4250f389311b3697343ac71e525","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rbac_rule_validation.action("},{"line_number":59,"context_line":"        service\u003d\"cinder\","},{"line_number":60,"context_line":"        rule\u003d\"volume_extension:volume_image_metadata\")"},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":62,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":63,"context_line":"        # Get a list of Volumes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_730d513d","side":"PARENT","line":60,"in_reply_to":"7ffa3b31_93b69dd9","updated":"2017-04-14 19:43:56.000000000","message":"You\u0027re right: we should keep it. I added it back in next patch. However, I was thinking it\u0027d be possible to change \"rule\" to \"rules\" in a blueprint to allow multiple rules to be processed for APIs that enforce multiple rules, but I\u0027m also thinking that that just might make things even harder to maintain without congress integration, so I don\u0027t think I\u0027ll do it.","commit_id":"4fc9a6b4bcbad1df306a7f08f84860e5abe22213"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"add472c3c84b065339e89acfbbe5757c68738af5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.volumes_client.show_volume(volume[\u0027id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","},{"line_number":51,"context_line":"                                 rule\u003d\"volume:get_all\")"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027e3ab7906-b04b-4c45-aa11-1104d302f940\u0027)"},{"line_number":53,"context_line":"    def test_volume_list(self):"},{"line_number":54,"context_line":"        # Get a list of Volumes"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_96820b4f","side":"PARENT","line":51,"updated":"2017-04-14 20:03:42.000000000","message":"Did you mean to remove this test?","commit_id":"4fc9a6b4bcbad1df306a7f08f84860e5abe22213"}]}