)]}'
{"patrole_tempest_plugin/tests/api/identity/v3/test_domain_configuration_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"a3b824ab529b8f10becf3d9096a08b481e38fecb","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027590c774d-a294-44f8-866e-aac9f4ab3809\u0027)"},{"line_number":94,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":95,"context_line":"                                 rule\u003d\"identity:get_domain_config\")"},{"line_number":96,"context_line":"    def test_show_domain_group_option_config(self):"},{"line_number":97,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":98,"context_line":"        self.client.show_domain_group_option_config(self.domain_id, \u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f013ff3_2832a6f2","line":95,"updated":"2017-05-15 18:15:50.000000000","message":"nit: I\u0027d prefer if tests involving the same policy actions were grouped together.","commit_id":"5b8fa8cd580c71f575559d69696f9d33b341a9de"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"680e127773112426c16655772e54208048a1a79c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027590c774d-a294-44f8-866e-aac9f4ab3809\u0027)"},{"line_number":94,"context_line":"    @rbac_rule_validation.action(service\u003d\"keystone\","},{"line_number":95,"context_line":"                                 rule\u003d\"identity:get_domain_config\")"},{"line_number":96,"context_line":"    def test_show_domain_group_option_config(self):"},{"line_number":97,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":98,"context_line":"        self.client.show_domain_group_option_config(self.domain_id, \u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f013ff3_08312a0c","line":95,"in_reply_to":"1f013ff3_2832a6f2","updated":"2017-05-15 18:43:26.000000000","message":"Done","commit_id":"5b8fa8cd580c71f575559d69696f9d33b341a9de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7958c6d3b69aa136e713e05ac0d0f8732198a7bd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"},{"line_number":40,"context_line":"        super(DomainConfigurationV3RbacTest, cls).setup_clients()"},{"line_number":41,"context_line":"        cls.client \u003d cls.domain_config_client"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_f43eac27","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":45},"updated":"2017-05-17 02:47:08.000000000","message":"doing such alias not good for long term and readability. Tempest doing this from starting and which we should be cleaning up sometime. \n\nwe can direct use cls.domain_config_client","commit_id":"4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"82dfeb29796581d16abbba061e3704fd1ae4c090","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"},{"line_number":40,"context_line":"        super(DomainConfigurationV3RbacTest, cls).setup_clients()"},{"line_number":41,"context_line":"        cls.client \u003d cls.domain_config_client"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_c830ed0a","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":45},"in_reply_to":"1f013ff3_f43eac27","updated":"2017-05-17 18:34:57.000000000","message":"Bug report here: https://bugs.launchpad.net/patrole/+bug/1691528","commit_id":"4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7958c6d3b69aa136e713e05ac0d0f8732198a7bd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _create_domain_config(self, domain_id):"},{"line_number":53,"context_line":"        domain_config \u003d self.client.create_domain_config("},{"line_number":54,"context_line":"            domain_id, identity\u003dself.identity, ldap\u003dself.ldap)[\u0027config\u0027]"},{"line_number":55,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":56,"context_line":"                        self.client.delete_domain_config,"},{"line_number":57,"context_line":"                        domain_id)"},{"line_number":58,"context_line":"        return domain_config"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_14d478bc","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":63},"updated":"2017-05-17 02:47:08.000000000","message":"i prefer not to ignore NotFound exception. here we create domain config and expect delete to be successful.","commit_id":"4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"82dfeb29796581d16abbba061e3704fd1ae4c090","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _create_domain_config(self, domain_id):"},{"line_number":53,"context_line":"        domain_config \u003d self.client.create_domain_config("},{"line_number":54,"context_line":"            domain_id, identity\u003dself.identity, ldap\u003dself.ldap)[\u0027config\u0027]"},{"line_number":55,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":56,"context_line":"                        self.client.delete_domain_config,"},{"line_number":57,"context_line":"                        domain_id)"},{"line_number":58,"context_line":"        return domain_config"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_08594559","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":63},"in_reply_to":"1f013ff3_14d478bc","updated":"2017-05-17 18:34:57.000000000","message":"I\u0027d need to discuss this further with you.\n\n``test_delete_domain_config`` deletes the domain config if the test passes (e.g. when role is admin).\n\nOnly way to remove ``call_and_ignore_notfound_exc`` is to not use this helper in ``test_delete_domain_config``.","commit_id":"4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b"}]}