)]}'
{"patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd54978fb42d5520ae1e5cd6d387e7baa0af127d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _create_volume_type_encryption(self):"},{"line_number":37,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":38,"context_line":"        self.client.create_encryption_type("},{"line_number":39,"context_line":"            vol_type_id,"},{"line_number":40,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":41,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":42,"context_line":"        return vol_type_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cf8220c9","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":23},"updated":"2017-04-24 23:17:59.000000000","message":"nit: This is an optional kwarg according to docs.","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"6b2577b15eaa100cccac3d323303f17017e2b2b0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _create_volume_type_encryption(self):"},{"line_number":37,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":38,"context_line":"        self.client.create_encryption_type("},{"line_number":39,"context_line":"            vol_type_id,"},{"line_number":40,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":41,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":42,"context_line":"        return vol_type_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_52a6b8c3","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":23},"in_reply_to":"5ff73747_cf8220c9","updated":"2017-04-25 01:18:11.000000000","message":"The Tempest client requires it.","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd54978fb42d5520ae1e5cd6d387e7baa0af127d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.client.create_encryption_type("},{"line_number":39,"context_line":"            vol_type_id,"},{"line_number":40,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":41,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":42,"context_line":"        return vol_type_id"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u0027ffd94ce5-c24b-4b6c-84c9-c5aad8c3010c\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cfe90081","line":41,"range":{"start_line":41,"start_character":55,"end_line":41,"end_character":72},"updated":"2017-04-24 23:17:59.000000000","message":"nit: Can remove [\u0027encryption_id\u0027]","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd54978fb42d5520ae1e5cd6d387e7baa0af127d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.client.create_encryption_type("},{"line_number":39,"context_line":"            vol_type_id,"},{"line_number":40,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":41,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":42,"context_line":"        return vol_type_id"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u0027ffd94ce5-c24b-4b6c-84c9-c5aad8c3010c\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_ef7ddce7","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":40},"updated":"2017-04-24 23:17:59.000000000","message":"nit: This is an optional kwarg: https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dcreate-an-encryption-type-detail","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"6b2577b15eaa100cccac3d323303f17017e2b2b0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.client.create_encryption_type("},{"line_number":39,"context_line":"            vol_type_id,"},{"line_number":40,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":41,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":42,"context_line":"        return vol_type_id"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u0027ffd94ce5-c24b-4b6c-84c9-c5aad8c3010c\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_6f8f8b23","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":40},"in_reply_to":"5ff73747_ef7ddce7","updated":"2017-04-25 01:18:11.000000000","message":"Creation fails if this is not present.","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd54978fb42d5520ae1e5cd6d387e7baa0af127d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        service\u003d\"cinder\","},{"line_number":47,"context_line":"        rule\u003d\"volume_extension:volume_type_encryption\")"},{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_4f9290f8","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":53},"updated":"2017-04-24 23:17:59.000000000","message":"If this is absolutely necessary (see above), then this can be created once in resource_setup.","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"6b2577b15eaa100cccac3d323303f17017e2b2b0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        service\u003d\"cinder\","},{"line_number":47,"context_line":"        rule\u003d\"volume_extension:volume_type_encryption\")"},{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_92b56034","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":53},"in_reply_to":"5ff73747_4f9290f8","updated":"2017-04-25 01:18:11.000000000","message":"It is necessary. Also, each volume type can only have one encryption associated with it, and since volume types are relatively small and quick to set up, I think this might be simpler.","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd54978fb42d5520ae1e5cd6d387e7baa0af127d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"},{"line_number":53,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":54,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027][\u0027encryption_id\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00276599e72e-acef-4c0d-a9b2-463fca30d1da\u0027)"},{"line_number":57,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cfb7c086","line":54,"range":{"start_line":51,"start_character":8,"end_line":54,"end_character":72},"updated":"2017-04-24 23:17:59.000000000","message":"If you get rid of self.create_volume_type in _create_volume_type_encryption, then self._create_volume_type_encryption() here","commit_id":"ee8d28f5fa7252f7dac641166dd9e3501e4d5761"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"46d59a09df025b3ee8880609b3ee322a8baabebe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"},{"line_number":53,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":54,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_1bea490e","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":42},"updated":"2017-04-26 15:13:51.000000000","message":"why not call the helper method ``_create_volume_type_encryption``","commit_id":"6704253b0d692ab4b3d453c9ccf35af25f498608"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"402452bfdbe16a9aaaa71a53b554f8a5341e80b3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"},{"line_number":53,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":54,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_3ba74552","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":42},"in_reply_to":"5ff73747_1bea490e","updated":"2017-04-26 15:19:36.000000000","message":"The helper method also creates a volume type, which is a separate policy action.","commit_id":"6704253b0d692ab4b3d453c9ccf35af25f498608"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"e0c591235456812a0bb62467ce310114c3819345","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_create_volume_type_encryption(self):"},{"line_number":49,"context_line":"        vol_type_id \u003d self.create_volume_type()[\u0027id\u0027]"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        self.client.create_encryption_type("},{"line_number":52,"context_line":"            vol_type_id,"},{"line_number":53,"context_line":"            provider\u003d\"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":54,"context_line":"            control_location\u003d\"front-end\")[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_5008ab2a","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":42},"in_reply_to":"5ff73747_3ba74552","updated":"2017-04-26 16:49:46.000000000","message":"good point","commit_id":"6704253b0d692ab4b3d453c9ccf35af25f498608"}]}