)]}'
{"patrole_tempest_plugin/tests/api/compute/test_volume_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":18,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_97f88e49","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"updated":"2017-04-25 19:31:40.000000000","message":"Unused.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":18,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_379f7a04","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":47},"updated":"2017-04-25 19:31:40.000000000","message":"Unused.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":22,"context_line":"from patrole_tempest_plugin.tests.api.compute import rbac_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumeV235RbacTest(rbac_base.BaseV2ComputeRbacTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_b7fdca3b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":18},"updated":"2017-04-25 19:31:40.000000000","message":"Unused.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(VolumeV235RbacTest, cls).resource_setup()"},{"line_number":48,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def resource_cleanup(cls):"},{"line_number":52,"context_line":"        cls.volumes_client.delete_volume(cls.volume[\u0027id\u0027])"},{"line_number":53,"context_line":"        super(VolumeV235RbacTest, cls).resource_cleanup()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"},{"line_number":56,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_f7035241","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":57},"updated":"2017-04-25 19:31:40.000000000","message":"Not needed because cls.create_volume() calls create_volume in tempest.api.volume.base which does automatic clean up during its resource_cleanup.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        rule\u003d\"volume:create\")"},{"line_number":75,"context_line":"    def test_create_volume(self):"},{"line_number":76,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":77,"context_line":"        self.volumes_client.create_volume(size\u003d1)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @decorators.idempotent_id(\u00276e7870f2-1bb2-4b58-96f8-6782071ef327\u0027)"},{"line_number":80,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_57ca061a","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":49},"updated":"2017-04-25 19:31:40.000000000","message":"You should be using self.create_volume() here instead because it does automatic clean up.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fd8fee8421b6561b1d120a83d973df5e48aa13e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        service\u003d\"cinder\","},{"line_number":82,"context_line":"        rule\u003d\"volume:delete\")"},{"line_number":83,"context_line":"    def test_delete_volume(self):"},{"line_number":84,"context_line":"        self.volumes_client.create_volume(size\u003d1)"},{"line_number":85,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":86,"context_line":"        self.volumes_client.delete_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_77c74214","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":49},"updated":"2017-04-25 19:31:40.000000000","message":"You should be using self.create_volume() here instead because it does automatic clean up.","commit_id":"973a738a0afac13f233a5dcb3a77dd57b7526d56"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8e27b71c089704b58f0d57c3145033cbc6ac1b68","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00274ba0a820-040f-488b-86bb-be2e920ea12c\u0027)"},{"line_number":54,"context_line":"    @rbac_rule_validation.action("},{"line_number":55,"context_line":"        service\u003d\"cinder\","},{"line_number":56,"context_line":"        rule\u003d\"volume:get_volume_metadata\")"},{"line_number":57,"context_line":"    def test_show_volume(self):"},{"line_number":58,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":59,"context_line":"        self.volumes_client.show_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_905bd852","line":56,"updated":"2017-04-26 15:01:34.000000000","message":"This doesn\u0027t seem correct.","commit_id":"97a5e60c26e5d29487d7f92bce18506f85b1e29f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f4294abacdc2454b910e4789bf468d9abd865462","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        service\u003d\"cinder\","},{"line_number":72,"context_line":"        rule\u003d\"volume:delete\")"},{"line_number":73,"context_line":"    def test_delete_volume(self):"},{"line_number":74,"context_line":"        self.create_volume(size\u003d1)"},{"line_number":75,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":76,"context_line":"        self.volumes_client.delete_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_7b3cadbe","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":34},"updated":"2017-04-26 15:04:25.000000000","message":"volume \u003d self.create_volume()","commit_id":"97a5e60c26e5d29487d7f92bce18506f85b1e29f"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8e27b71c089704b58f0d57c3145033cbc6ac1b68","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_delete_volume(self):"},{"line_number":74,"context_line":"        self.create_volume(size\u003d1)"},{"line_number":75,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":76,"context_line":"        self.volumes_client.delete_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_d0bba06f","line":76,"updated":"2017-04-26 15:01:34.000000000","message":"These tests don\u0027t necessarily run in the sequence in this file; therefore, it\u0027s possible for this volume to be deleted before show_volume is called, leading to the not found you\u0027re getting from the gate. For this test, either create a new volume to delete, create a new volume for the show volume test, or check that the volume exists and, if not, create a new one.","commit_id":"97a5e60c26e5d29487d7f92bce18506f85b1e29f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f4294abacdc2454b910e4789bf468d9abd865462","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_delete_volume(self):"},{"line_number":74,"context_line":"        self.create_volume(size\u003d1)"},{"line_number":75,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":76,"context_line":"        self.volumes_client.delete_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_3b5f450f","line":76,"range":{"start_line":76,"start_character":42,"end_line":76,"end_character":59},"updated":"2017-04-26 15:04:25.000000000","message":"volume[\u0027id\u0027]","commit_id":"97a5e60c26e5d29487d7f92bce18506f85b1e29f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c2e3b21fadb0b9caa3a500b5ed2971267f48d44d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_delete_volume(self):"},{"line_number":74,"context_line":"        volume \u003d self.create_volume(size\u003d1)"},{"line_number":75,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":76,"context_line":"        self.volumes_client.delete_volume(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_c0e03c29","line":76,"range":{"start_line":76,"start_character":42,"end_line":76,"end_character":59},"updated":"2017-04-27 18:17:41.000000000","message":"volume[\u0027id\u0027]\n\nThis is causing your test_show_volume test to fail.","commit_id":"05dfcc8c8ce488aa04e77acfb37d6c5a157e4e20"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"},{"line_number":37,"context_line":"        super(VolumeV235RbacTest, cls).setup_clients()"},{"line_number":38,"context_line":"        cls.volumes_client \u003d cls.os.volumes_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00272402013e-a624-43e3-9518-44a5d1dbb32d\u0027)"},{"line_number":41,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_c4b14b49","line":38,"updated":"2017-04-28 16:52:13.000000000","message":"This is unnecessary.","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"},{"line_number":37,"context_line":"        super(VolumeV235RbacTest, cls).setup_clients()"},{"line_number":38,"context_line":"        cls.volumes_client \u003d cls.os.volumes_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00272402013e-a624-43e3-9518-44a5d1dbb32d\u0027)"},{"line_number":41,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_ff113b55","line":38,"in_reply_to":"5ff73747_c4b14b49","updated":"2017-05-03 19:27:43.000000000","message":"We still need setup_clients for create_volume testcase, although we can replace other testcases with self.create_volume()","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":44,"context_line":"    def test_create_volume(self):"},{"line_number":45,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":46,"context_line":"        self.volumes_client.create_volume(size\u003d1)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"},{"line_number":49,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_64b2774b","line":46,"range":{"start_line":46,"start_character":42,"end_line":46,"end_character":48},"updated":"2017-04-28 16:52:13.000000000","message":"Is there a reason this was added back in?","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":44,"context_line":"    def test_create_volume(self):"},{"line_number":45,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":46,"context_line":"        self.volumes_client.create_volume(size\u003d1)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"},{"line_number":49,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_bf34d3df","line":46,"range":{"start_line":46,"start_character":42,"end_line":46,"end_character":48},"in_reply_to":"5ff73747_64b2774b","updated":"2017-05-03 19:27:43.000000000","message":"in the volumes_client.create_volume, we do not have a mechanism to default size to some integer, hence we need to pass this attribute","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        service\u003d\"nova\","},{"line_number":59,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_44ec1b29","line":61,"updated":"2017-04-28 16:52:13.000000000","message":"nit: Add [\u0027volume\u0027] to the end of this line...","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bc1d830c56fa370fab075231c520ee5661379936","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        service\u003d\"nova\","},{"line_number":59,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_623a6799","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":58},"updated":"2017-04-28 17:59:23.000000000","message":"volume \u003d self.create_volume()","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        service\u003d\"nova\","},{"line_number":59,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_7f4c0b76","line":61,"in_reply_to":"5ff73747_44ec1b29","updated":"2017-05-03 19:27:43.000000000","message":"Done","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        service\u003d\"nova\","},{"line_number":59,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_5f514f0e","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":58},"in_reply_to":"5ff73747_623a6799","updated":"2017-05-03 19:27:43.000000000","message":"Done","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00276e7870f2-1bb2-4b58-96f8-6782071ef327\u0027)"},{"line_number":66,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_24efcf1e","line":63,"updated":"2017-04-28 16:52:13.000000000","message":"...and remove it from the volume here (so it\u0027s volume[\u0027id\u0027])","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def test_show_volume(self):"},{"line_number":61,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":62,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":63,"context_line":"        self.volumes_client.show_volume(volume[\u0027volume\u0027][\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00276e7870f2-1bb2-4b58-96f8-6782071ef327\u0027)"},{"line_number":66,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_1f5bc72e","line":63,"in_reply_to":"5ff73747_24efcf1e","updated":"2017-05-03 19:27:43.000000000","message":"Done","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        service\u003d\"nova\","},{"line_number":68,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":69,"context_line":"    def test_delete_volume(self):"},{"line_number":70,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":71,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":72,"context_line":"        self.volumes_client.delete_volume(volume[\u0027volume\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_c4df0b67","line":70,"updated":"2017-04-28 16:52:13.000000000","message":"See L61","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bc1d830c56fa370fab075231c520ee5661379936","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        service\u003d\"nova\","},{"line_number":68,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":69,"context_line":"    def test_delete_volume(self):"},{"line_number":70,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":71,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":72,"context_line":"        self.volumes_client.delete_volume(volume[\u0027volume\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_2240df06","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":58},"updated":"2017-04-28 17:59:23.000000000","message":"volume \u003d self.create_volume()","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        service\u003d\"nova\","},{"line_number":68,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":69,"context_line":"    def test_delete_volume(self):"},{"line_number":70,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":71,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":72,"context_line":"        self.volumes_client.delete_volume(volume[\u0027volume\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_df3c3fc1","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":58},"in_reply_to":"5ff73747_2240df06","updated":"2017-05-03 19:27:43.000000000","message":"Done","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"fe8a76c1864e4d9a78094da7f332a19cfcc586e3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        service\u003d\"nova\","},{"line_number":68,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":69,"context_line":"    def test_delete_volume(self):"},{"line_number":70,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)"},{"line_number":71,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":72,"context_line":"        self.volumes_client.delete_volume(volume[\u0027volume\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_ff3ffbb2","line":70,"in_reply_to":"5ff73747_c4df0b67","updated":"2017-05-03 19:27:43.000000000","message":"Done","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"3efe346ee2c18f4445f43e60c0e358186e831c7a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    min_microversion \u003d \u00272.10\u0027"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"},{"line_number":37,"context_line":"        super(VolumeV235RbacTest, cls).setup_clients()"},{"line_number":38,"context_line":"        cls.volumes_client \u003d cls.os.volumes_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00272402013e-a624-43e3-9518-44a5d1dbb32d\u0027)"},{"line_number":41,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_5f3b8f9b","line":38,"range":{"start_line":35,"start_character":4,"end_line":38,"end_character":50},"updated":"2017-05-03 19:36:05.000000000","message":"(continuing from patch set 7) Sorry, what I meant was including setup_clients in this file is unnecessary as volumes_client is already declared this way in the base class and setup_clients is automatically called.","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"3efe346ee2c18f4445f43e60c0e358186e831c7a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":44,"context_line":"    def test_create_volume(self):"},{"line_number":45,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":46,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)[\u0027volume\u0027]"},{"line_number":47,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"},{"line_number":50,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_7f5f6be5","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":72},"updated":"2017-05-03 19:36:05.000000000","message":"self.create_volume() can be used here instead","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"db75d9d69269b2bc6f22030a4fe5be922b14ac1d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":44,"context_line":"    def test_create_volume(self):"},{"line_number":45,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":46,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)[\u0027volume\u0027]"},{"line_number":47,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"},{"line_number":50,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_629fd2b4","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":72},"in_reply_to":"3f044301_7f5f6be5","updated":"2017-05-03 20:08:16.000000000","message":"I\u0027m fine with this because this provides better \"isolation\" because sometimes the helper methods call \"show\" (to get a status, more details, etc.).","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"3efe346ee2c18f4445f43e60c0e358186e831c7a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        service\u003d\"nova\","},{"line_number":60,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":61,"context_line":"    def test_show_volume(self):"},{"line_number":62,"context_line":"        volume \u003d self.create_volume()[\u0027volume\u0027]"},{"line_number":63,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":64,"context_line":"        self.volumes_client.show_volume(volume[\u0027id\u0027])"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_1f13c70f","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":47},"updated":"2017-05-03 19:36:05.000000000","message":"Unnecessary when using self.create_volume()","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"3efe346ee2c18f4445f43e60c0e358186e831c7a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        service\u003d\"nova\","},{"line_number":69,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":70,"context_line":"    def test_delete_volume(self):"},{"line_number":71,"context_line":"        volume \u003d self.create_volume()[\u0027volume\u0027]"},{"line_number":72,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":73,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_fff7fbd3","line":71,"updated":"2017-05-03 19:36:05.000000000","message":"See L62","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c4ac2e91e574135f360962c2b76b5909feae4b6c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    executed."},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."},{"line_number":32,"context_line":"    min_microversion \u003d \u00272.10\u0027"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_7de733e6","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":71},"updated":"2017-05-05 16:30:58.000000000","message":"# These tests will fail with a 404 starting from microversion 2.36.\n# For more information, see:\n# https://developer.openstack.org/api-ref/compute/#volume-extension-os-volumes-os-snapshots-deprecated","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"1bca03c267e1d1c80d00898947d4cc071c686d7d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    executed."},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."},{"line_number":32,"context_line":"    min_microversion \u003d \u00272.10\u0027"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_99751a35","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":71},"in_reply_to":"3f044301_7de733e6","updated":"2017-05-11 08:08:22.000000000","message":"Done","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7b90b5ac0474ae06f228815a80ba5250a68bd4fb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":39,"context_line":"    def test_create_volume(self):"},{"line_number":40,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":41,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)[\u0027volume\u0027]"},{"line_number":42,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_5ad6ab29","line":41,"range":{"start_line":41,"start_character":51,"end_line":41,"end_character":57},"updated":"2017-05-07 13:14:15.000000000","message":"I also think it\u0027s better to use a fixture in rbac_base for stuff like this. We could override Tempest\u0027s volume_size config option using a fixture. Then we could pass size\u003dCONF.volume.volume_size here. This\u0027ll result in the code being more maintainable longterm, as that\u0027ll allow us to just make code changes to the fixtures we define in one place, rather than having to hunt down stuff like this throughout the code.","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c4ac2e91e574135f360962c2b76b5909feae4b6c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":39,"context_line":"    def test_create_volume(self):"},{"line_number":40,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":41,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)[\u0027volume\u0027]"},{"line_number":42,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_1dccaf5f","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":36},"updated":"2017-05-05 16:30:58.000000000","message":"See below","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"1bca03c267e1d1c80d00898947d4cc071c686d7d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":39,"context_line":"    def test_create_volume(self):"},{"line_number":40,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":41,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1)[\u0027volume\u0027]"},{"line_number":42,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002769b3888c-dff2-47b0-9fa4-0672619c9054\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_b97c561f","line":41,"range":{"start_line":41,"start_character":51,"end_line":41,"end_character":57},"in_reply_to":"3f044301_5ad6ab29","updated":"2017-05-11 08:08:22.000000000","message":"Since we already have volume.volume_size defined in tempest/config.py.I believe we can avoid fixtures. Anyways I have changed it to CONF.volumes.volume_size","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c4ac2e91e574135f360962c2b76b5909feae4b6c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":48,"context_line":"    def test_list_volumes(self):"},{"line_number":49,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":50,"context_line":"        self.volumes_client.list_volumes()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u00274ba0a820-040f-488b-86bb-be2e920ea12c\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_fd77c339","line":50,"range":{"start_line":50,"start_character":13,"end_line":50,"end_character":27},"updated":"2017-05-05 16:30:58.000000000","message":"volumes_extensions_client\n\nvolumes_client is the Cinder client, whereas volumes_extensions_client is the Nova volume client.","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"1bca03c267e1d1c80d00898947d4cc071c686d7d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        rule\u003d\"os_compute_api:os-volumes\")"},{"line_number":48,"context_line":"    def test_list_volumes(self):"},{"line_number":49,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":50,"context_line":"        self.volumes_client.list_volumes()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u00274ba0a820-040f-488b-86bb-be2e920ea12c\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_79724e4b","line":50,"range":{"start_line":50,"start_character":13,"end_line":50,"end_character":27},"in_reply_to":"3f044301_fd77c339","updated":"2017-05-11 08:08:22.000000000","message":"Done","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c4ac2e91e574135f360962c2b76b5909feae4b6c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_show_volume(self):"},{"line_number":57,"context_line":"        volume \u003d self.create_volume()"},{"line_number":58,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":59,"context_line":"        self.volumes_client.show_volume(volume[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00276e7870f2-1bb2-4b58-96f8-6782071ef327\u0027)"},{"line_number":62,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_5dea37ac","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":27},"updated":"2017-05-05 16:30:58.000000000","message":"Ditto","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"1bca03c267e1d1c80d00898947d4cc071c686d7d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_show_volume(self):"},{"line_number":57,"context_line":"        volume \u003d self.create_volume()"},{"line_number":58,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":59,"context_line":"        self.volumes_client.show_volume(volume[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00276e7870f2-1bb2-4b58-96f8-6782071ef327\u0027)"},{"line_number":62,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_5991d246","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":27},"in_reply_to":"3f044301_5dea37ac","updated":"2017-05-11 08:08:22.000000000","message":"Done","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c4ac2e91e574135f360962c2b76b5909feae4b6c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def test_delete_volume(self):"},{"line_number":66,"context_line":"        volume \u003d self.create_volume()"},{"line_number":67,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":68,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_3dd1abfc","line":68,"range":{"start_line":68,"start_character":13,"end_line":68,"end_character":27},"updated":"2017-05-05 16:30:58.000000000","message":"Ditto","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"1bca03c267e1d1c80d00898947d4cc071c686d7d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def test_delete_volume(self):"},{"line_number":66,"context_line":"        volume \u003d self.create_volume()"},{"line_number":67,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":68,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_39960641","line":68,"range":{"start_line":68,"start_character":13,"end_line":68,"end_character":27},"in_reply_to":"3f044301_3dd1abfc","updated":"2017-05-11 08:08:22.000000000","message":"Done","commit_id":"5a1ad984c51354ed5ca31f9dc8d22b7f06344257"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"eee2178526b9f3182dae4a228b217f7e29b0526a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class VolumeV235RbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":27,"context_line":"    \"\"\"RBAC tests for the Nova Volume client."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    These APIs are proxy calls to the Volume service. Consequently, no nova"},{"line_number":30,"context_line":"    policy actions are enforced; instead, only cinder policy actions are"},{"line_number":31,"context_line":"    enforced. As such, these tests check that only cinder policy actions are"},{"line_number":32,"context_line":"    executed."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."}],"source_content_type":"text/x-python","patch_set":12,"id":"3f044301_365e0c76","line":32,"range":{"start_line":29,"start_character":4,"end_line":32,"end_character":13},"updated":"2017-05-11 12:33:35.000000000","message":"This comment is no longer applicable.","commit_id":"a331123a35120901c8c71fb8184d52e9d27420d7"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"3fb580ddefbf21f4fcfc0a6fe59f0b59f86575df","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class VolumeV235RbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":27,"context_line":"    \"\"\"RBAC tests for the Nova Volume client."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    These APIs are proxy calls to the Volume service. Consequently, no nova"},{"line_number":30,"context_line":"    policy actions are enforced; instead, only cinder policy actions are"},{"line_number":31,"context_line":"    enforced. As such, these tests check that only cinder policy actions are"},{"line_number":32,"context_line":"    executed."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."}],"source_content_type":"text/x-python","patch_set":12,"id":"1f013ff3_1e9d0959","line":32,"range":{"start_line":29,"start_character":4,"end_line":32,"end_character":13},"in_reply_to":"3f044301_365e0c76","updated":"2017-05-12 15:11:15.000000000","message":"Agreed, please remove this.","commit_id":"a331123a35120901c8c71fb8184d52e9d27420d7"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"c48edf1914600e0bfdc7b1585fcbc9db4ecf3201","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class VolumeV235RbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":27,"context_line":"    \"\"\"RBAC tests for the Nova Volume client."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    These APIs are proxy calls to the Volume service. Consequently, no nova"},{"line_number":30,"context_line":"    policy actions are enforced; instead, only cinder policy actions are"},{"line_number":31,"context_line":"    enforced. As such, these tests check that only cinder policy actions are"},{"line_number":32,"context_line":"    executed."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."}],"source_content_type":"text/x-python","patch_set":12,"id":"1f013ff3_2ff3daa0","line":32,"range":{"start_line":29,"start_character":4,"end_line":32,"end_character":13},"in_reply_to":"3f044301_365e0c76","updated":"2017-05-15 10:36:59.000000000","message":"Done","commit_id":"a331123a35120901c8c71fb8184d52e9d27420d7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"eee2178526b9f3182dae4a228b217f7e29b0526a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."},{"line_number":36,"context_line":"    # For more information, see:"},{"line_number":37,"context_line":"    # https://developer.openstack.org/api-ref/compute/"},{"line_number":38,"context_line":"    # volume-extension-os-volumes-os-snapshots-deprecated"},{"line_number":39,"context_line":"    min_microversion \u003d \u00272.10\u0027"},{"line_number":40,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f044301_f653046a","line":38,"range":{"start_line":37,"start_character":4,"end_line":38,"end_character":57},"updated":"2017-05-11 12:33:35.000000000","message":"Can be placed on one line. pep8 won\u0027t complain.","commit_id":"a331123a35120901c8c71fb8184d52e9d27420d7"},{"author":{"_account_id":23363,"name":"Pradeep Kumar","email":"pk5294@att.com","username":"pradeepkumarks"},"change_message_id":"dc5caddda404dc171c6a9c3d429c3c4dbefcb541","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # These tests will fail with a 404 starting from microversion 2.36."},{"line_number":36,"context_line":"    # For more information, see:"},{"line_number":37,"context_line":"    # https://developer.openstack.org/api-ref/compute/"},{"line_number":38,"context_line":"    # volume-extension-os-volumes-os-snapshots-deprecated"},{"line_number":39,"context_line":"    min_microversion \u003d \u00272.10\u0027"},{"line_number":40,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f013ff3_ef13b2b7","line":38,"range":{"start_line":37,"start_character":4,"end_line":38,"end_character":57},"in_reply_to":"3f044301_f653046a","updated":"2017-05-15 10:38:32.000000000","message":"It did complain as it crossed 109 characters. Anyways its too long for a single line too. Hence keeping it as it is","commit_id":"a331123a35120901c8c71fb8184d52e9d27420d7"}],"releasenotes/notes/nova_volume_client-75e153a1c84e4ff8.yaml":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8e27b71c089704b58f0d57c3145033cbc6ac1b68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds RBAC tests for the Nova volume client which is to be deprecated "},{"line_number":5,"context_line":"    from microversion 2.36."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5ff73747_5055501c","line":4,"updated":"2017-04-26 15:01:34.000000000","message":"Please remove the extra white space at the end of this line.","commit_id":"97a5e60c26e5d29487d7f92bce18506f85b1e29f"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"47fd0c6dd7278b4c0584cb5b958048bbab3cd2fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds RBAC tests for the Nova volume client which is to be deprecated "},{"line_number":5,"context_line":"    from microversion 2.36."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ff73747_44d53b43","line":4,"range":{"start_line":4,"start_character":72,"end_line":4,"end_character":73},"updated":"2017-04-28 16:52:13.000000000","message":"Please remove this extra white space.","commit_id":"5b7b9f9a970ed8a2869bdc1fd38fce4e22f7c2b5"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"3efe346ee2c18f4445f43e60c0e358186e831c7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds RBAC tests for the Nova volume client which is to be deprecated "},{"line_number":5,"context_line":"    from microversion 2.36."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f044301_7f040bc7","line":4,"updated":"2017-05-03 19:36:05.000000000","message":"Please remove the white space at the end of this line.","commit_id":"445bfc6837cb21ea31b6da0bd65413d696fc3c85"}]}