)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a50687eb74effe957496b9efb47fec96ab5f4ebc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Samantha Blanco \u003csamantha.blanco@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-06 15:37:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Adds server security group tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds server security group RBAC tests and updates Nova"},{"line_number":10,"context_line":"security group RBAC tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"df140735_7850980b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2017-06-06 22:20:04.000000000","message":"Looks ready to go?","commit_id":"5d6aa0ea45f65584158c5f49fc2d00cd5df58560"}],"patrole_tempest_plugin/tests/api/compute/test_security_groups_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9475ed388a949ccbcbad3bc7334449b83040a50d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # Tests in this class will fail with a 404 from microversion 2.36,"},{"line_number":26,"context_line":"    # according to:"},{"line_number":27,"context_line":"    # https://developer.openstack.org/api-ref/compute/#security-groups-os-security-"},{"line_number":28,"context_line":"    # groups-deprecated"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    max_microversion \u003d \u00272.36\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_e0f4d35d","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":23},"updated":"2017-05-04 21:37:50.000000000","message":"nit: Can go on same line.","commit_id":"f03a81c750d7f96d0396645d1ba44b08e7b39ac1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9475ed388a949ccbcbad3bc7334449b83040a50d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    max_microversion \u003d \u00272.36\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rbac_rule_validation.action("},{"line_number":33,"context_line":"        service\u003d\"neutron\","},{"line_number":34,"context_line":"        rule\u003d\"get_security_groups\")"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00274ac58e49-48c1-4fca-a6c3-3f95fb99eb77\u0027)"},{"line_number":36,"context_line":"    def test_list_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_00be9f64","line":33,"range":{"start_line":33,"start_character":17,"end_line":33,"end_character":24},"updated":"2017-05-04 21:37:50.000000000","message":"According to https://github.com/openstack/nova/blob/master/nova/policies/security_groups.py, these are covered by nova\u0027s policy \u0027os_compute_api:os-security-groups\u0027.\n\nI haven\u0027t verified that, but that\u0027s what the docstring there says. I think it\u0027s more important to confirm that the nova-side policy is being enforced here than the neutron policy.","commit_id":"f03a81c750d7f96d0396645d1ba44b08e7b39ac1"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"fe56a079aff66033458ac24acb1e14d0727ecbd9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    max_microversion \u003d \u00272.36\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rbac_rule_validation.action("},{"line_number":33,"context_line":"        service\u003d\"neutron\","},{"line_number":34,"context_line":"        rule\u003d\"get_security_groups\")"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00274ac58e49-48c1-4fca-a6c3-3f95fb99eb77\u0027)"},{"line_number":36,"context_line":"    def test_list_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_5738d63b","line":33,"range":{"start_line":33,"start_character":17,"end_line":33,"end_character":24},"in_reply_to":"3f044301_00be9f64","updated":"2017-05-05 15:47:39.000000000","message":"I tested it, but it doesn\u0027t look like they are. I believe these are more proxy commands (similar to the glance and cinder ones that we have tests for).","commit_id":"f03a81c750d7f96d0396645d1ba44b08e7b39ac1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"edd26deddbc669bca203e3bf947e16dcd398b8b8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def test_create_security_groups(self):"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        sec_group_id \u003d self.create_security_group()[\u0027id\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self.security_groups_client.delete_security_group,"},{"line_number":53,"context_line":"                        sec_group_id)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @rbac_rule_validation.action("},{"line_number":56,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_e53a5396","line":53,"range":{"start_line":52,"start_character":7,"end_line":53,"end_character":37},"updated":"2017-05-09 18:03:17.000000000","message":"nit: create_security_group already implicitly does clean up in resource_cleanup: https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L219","commit_id":"c305f2fca5f895b2041ff878e9818a15891c7fd9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib.common.utils import test_utils"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_01f55383","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":35},"updated":"2017-05-19 19:50:05.000000000","message":"Unused.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"},{"line_number":21,"context_line":"from tempest import test"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_61008f68","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":47},"updated":"2017-05-19 19:50:05.000000000","message":"Unused.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":24,"context_line":"from patrole_tempest_plugin.tests.api.compute import rbac_base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class SecurityGroupsV236RbacTest(rbac_base.BaseV2ComputeRbacTest):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_e1c5bf3d","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":33},"updated":"2017-05-19 19:50:05.000000000","message":"Unused.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class SecurityGroupsV236RbacTest(rbac_base.BaseV2ComputeRbacTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Tests in this class will fail with a 404 from microversion 2.36,"},{"line_number":32,"context_line":"    # according to:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_01e2f301","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":24},"updated":"2017-05-19 19:50:05.000000000","message":"This shouldn\u0027t be here because V236 is reserved for test class with min_microversion of 2.36 (not max_microversion of 2.35).","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @decorators.idempotent_id(\u0027e8fe7f5a-69ee-412d-81d3-a8c7a488b54d\u0027)"},{"line_number":49,"context_line":"    def test_create_security_groups(self):"},{"line_number":50,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":51,"context_line":"        sec_group_id \u003d self.create_security_group()[\u0027id\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @rbac_rule_validation.action("},{"line_number":54,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_01cb1372","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":20},"updated":"2017-05-19 19:50:05.000000000","message":"nit: Unused","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        rule\u003d\"os_compute_api:os-security-groups\")"},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00273de5c6bc-b822-469e-a627-82427d38b067\u0027)"},{"line_number":66,"context_line":"    def test_update_security_groups(self):"},{"line_number":67,"context_line":"        sec_group_id \u003d self.create_security_group()[\u0027id\u0027]"},{"line_number":68,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":69,"context_line":"        new_name \u003d data_utils.rand_name()"},{"line_number":70,"context_line":"        new_desc \u003d data_utils.rand_name()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_4187cb10","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":57},"updated":"2017-05-19 19:50:05.000000000","message":"nit: For this test and the one below a shared class-scoped security group can be created.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        new_desc \u003d data_utils.rand_name()"},{"line_number":71,"context_line":"        self.security_groups_client.update_security_group(sec_group_id,"},{"line_number":72,"context_line":"                                                          name\u003dnew_name,"},{"line_number":73,"context_line":"                                                          description\u003dnew_desc)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @rbac_rule_validation.action("},{"line_number":76,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_41aeab98","line":73,"range":{"start_line":73,"start_character":58,"end_line":73,"end_character":78},"updated":"2017-05-19 19:50:05.000000000","message":"nit: Can just pass the name to update, but doesn\u0027t hurt I guess.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # Tests in this class will fail with a 404 from microversion 2.36,"},{"line_number":26,"context_line":"    # according to:"},{"line_number":27,"context_line":"    # https://developer.openstack.org/api-ref/compute/#security-groups-os-security-groups-deprecated"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_ef22a101","line":28,"updated":"2017-05-25 19:01:12.000000000","message":"nit: extra space","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a50687eb74effe957496b9efb47fec96ab5f4ebc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # Tests in this class will fail with a 404 from microversion 2.36,"},{"line_number":26,"context_line":"    # according to:"},{"line_number":27,"context_line":"    # https://developer.openstack.org/api-ref/compute/#security-groups-os-security-groups-deprecated"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    max_microversion \u003d \u00272.35\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":25,"id":"df140735_9826ccba","line":28,"updated":"2017-06-06 22:20:04.000000000","message":"nit: extra newline","commit_id":"5d6aa0ea45f65584158c5f49fc2d00cd5df58560"}],"patrole_tempest_plugin/tests/api/compute/test_server_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9475ed388a949ccbcbad3bc7334449b83040a50d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    @decorators.idempotent_id(\u00273db159c6-a467-469f-9a25-574197885520\u0027)"},{"line_number":207,"context_line":"    def test_delete_security_group_from_server(self):"},{"line_number":208,"context_line":"        sg_name \u003d self.create_security_group()[\u0027name\u0027]"},{"line_number":209,"context_line":"        self.client.add_security_group(self.server[\u0027id\u0027], name\u003dsg_name)"},{"line_number":210,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":211,"context_line":"        self.client.remove_security_group(self.server[\u0027id\u0027], name\u003dsg_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_20a87b1d","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":71},"updated":"2017-05-04 21:37:50.000000000","message":"Needs clean up.","commit_id":"f03a81c750d7f96d0396645d1ba44b08e7b39ac1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        service\u003d\"nova\","},{"line_number":172,"context_line":"        rule\u003d\"os_compute_api:servers:update\")"},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027077b17cb-5621-43b9-8adf-5725f0d7a863\u0027)"},{"line_number":174,"context_line":"    def test_update_server(self):"},{"line_number":175,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":176,"context_line":"        new_name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":177,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_81ca8317","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":26},"updated":"2017-05-19 19:50:05.000000000","message":"We can use the class-scoped server here (can be done in later patch).","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"08e2ed978aedaf5af90fdf4c913ced3761bc7ad0","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        sg_name \u003d self.create_security_group()[\u0027name\u0027]"},{"line_number":200,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":201,"context_line":"        self.servers_client.add_security_group(self.server[\u0027id\u0027], name\u003dsg_name)"},{"line_number":202,"context_line":"        self.addCleanup(self.client.remove_security_group,"},{"line_number":203,"context_line":"                        self.server[\u0027id\u0027], name\u003dsg_name)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_c11cfbc2","line":202,"updated":"2017-05-19 19:50:05.000000000","message":"This requires test_utils.call_and_ignore_notfound_exc for when the call above throws a Forbidden (but is caught), which would cause this to throw NotFound.","commit_id":"ab9d8aa51794637b6867b7be39cbb41bfbd27e03"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ab4540219db2b50283884a8b86001c3ded9a108","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        service\u003d\"nova\","},{"line_number":208,"context_line":"        rule\u003d\"os_compute_api:os-security-groups\")"},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u00273db159c6-a467-469f-9a25-574197885520\u0027)"},{"line_number":210,"context_line":"    def test_delete_security_group_from_server(self):"},{"line_number":211,"context_line":"        sg \u003d self.create_security_group()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_75b3714e","line":210,"range":{"start_line":210,"start_character":13,"end_line":210,"end_character":19},"updated":"2017-05-23 01:15:40.000000000","message":"I prefer \"remove\" instead of \"delete\" here.","commit_id":"02cc7a636e6700f07c8588f45168ee90bbadf1f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ab4540219db2b50283884a8b86001c3ded9a108","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":220,"context_line":"        self.servers_client.delete_server(server_id)"},{"line_number":221,"context_line":"        waiters.wait_for_server_termination(self.servers_client, server_id)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        self.client.delete_security_group(sg[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_b5ad89ea","line":222,"updated":"2017-05-23 01:15:40.000000000","message":"Looks like switch_role call is missing.","commit_id":"02cc7a636e6700f07c8588f45168ee90bbadf1f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ComputeServersRbacTest, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":40,"context_line":"        cls.networks_client \u003d cls.os_primary.networks_client"},{"line_number":41,"context_line":"        cls.ports_client \u003d cls.os_primary.ports_client"},{"line_number":42,"context_line":"        cls.subnets_client \u003d cls.os_primary.subnets_client"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_4f818dc3","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":39},"updated":"2017-05-25 19:01:12.000000000","message":"Unusued","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Create port"},{"line_number":92,"context_line":"        port \u003d self.ports_client.create_port(network_id\u003dnetwork[\u0027id\u0027])[\u0027port\u0027]"},{"line_number":93,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":94,"context_line":"                        self.ports_client.delete_port, port[\u0027id\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_4fe86d7b","line":93,"range":{"start_line":93,"start_character":23,"end_line":93,"end_character":63},"updated":"2017-05-25 19:01:12.000000000","message":"This can be removed.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        rule\u003d\"os_compute_api:servers:update\")"},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u0027077b17cb-5621-43b9-8adf-5725f0d7a863\u0027)"},{"line_number":187,"context_line":"    def test_update_server(self):"},{"line_number":188,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":189,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"},{"line_number":190,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":191,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_4f9d0d09","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":61},"updated":"2017-05-25 19:01:12.000000000","message":"We can use the class-level server here.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    @decorators.idempotent_id(\u0027ea1ca73f-2d1d-43cb-9a46-900d7927b357\u0027)"},{"line_number":212,"context_line":"    def test_create_security_group_for_server(self):"},{"line_number":213,"context_line":"        sg_name \u003d self.create_security_group()[\u0027name\u0027]"},{"line_number":214,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":215,"context_line":"        port \u003d self._create_network_port()"},{"line_number":216,"context_line":"        self.interfaces_client.create_interface("},{"line_number":217,"context_line":"            server[\u0027id\u0027], port_id\u003dport[\u0027id\u0027])[\u0027interfaceAttachment\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_af8dc9d4","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":61},"updated":"2017-05-25 19:01:12.000000000","message":"Is it really necessary to create entirely new servers for these tests? I\u0027d rather use the class-level server and then add and remove security groups in clean ups as needed.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            server[\u0027id\u0027], port_id\u003dport[\u0027id\u0027])[\u0027interfaceAttachment\u0027]"},{"line_number":218,"context_line":"        self.addCleanup(self.interfaces_client.delete_interface,"},{"line_number":219,"context_line":"                        server[\u0027id\u0027], port[\u0027id\u0027])"},{"line_number":220,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":221,"context_line":"        self.servers_client.add_security_group(server[\u0027id\u0027], name\u003dsg_name)"},{"line_number":222,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":223,"context_line":"                        self.client.remove_security_group,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_6f66912c","line":220,"range":{"start_line":220,"start_character":8,"end_line":220,"end_character":64},"updated":"2017-05-25 19:01:12.000000000","message":"I\u0027d prefer a newline above this (and elsewhere too if you like). My eyes are glazing over just looking at this massive block of code.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    @decorators.idempotent_id(\u00270ad2e856-e2d3-4ac5-a620-f93d0d3d2626\u0027)"},{"line_number":231,"context_line":"    def test_remove_security_group_from_server(self):"},{"line_number":232,"context_line":"        sg_name \u003d self.create_security_group()[\u0027name\u0027]"},{"line_number":233,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":234,"context_line":"        port \u003d self._create_network_port()"},{"line_number":235,"context_line":"        self.interfaces_client.create_interface("},{"line_number":236,"context_line":"            server[\u0027id\u0027], port_id\u003dport[\u0027id\u0027])[\u0027interfaceAttachment\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_cf90fdf0","line":233,"range":{"start_line":233,"start_character":8,"end_line":233,"end_character":61},"updated":"2017-05-25 19:01:12.000000000","message":"See above.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"09973997fd43126d2cd4c24d2118cb65ef7c142f","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":241,"context_line":"                        self.client.remove_security_group,"},{"line_number":242,"context_line":"                        server[\u0027id\u0027], name\u003dsg_name)"},{"line_number":243,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":244,"context_line":"        self.servers_client.remove_security_group(server[\u0027id\u0027], name\u003dsg_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff0f0b1f_cfa91d25","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":64},"updated":"2017-05-25 19:01:12.000000000","message":"See above.","commit_id":"e6051288d1a93e434e351259510528ded19d6831"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d70273ab46eb2e36f97aac9a93c1d50da697bef5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cls.volumes.append(volume)"},{"line_number":61,"context_line":"        cls.volume_id \u003d volume[\u0027id\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls._create_network_resources()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @classmethod"},{"line_number":66,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":21,"id":"df140735_53a4f2a5","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":39},"updated":"2017-06-02 22:50:36.000000000","message":"See below: we should put network resource setup here too.","commit_id":"ce6bbfb194a9af2d75fec3340a1844a7d8b4ae2a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d70273ab46eb2e36f97aac9a93c1d50da697bef5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @classmethod"},{"line_number":66,"context_line":"    def resource_cleanup(cls):"},{"line_number":67,"context_line":"        cls.ports_client.delete_port(cls.port[\u0027id\u0027])"},{"line_number":68,"context_line":"        cls.ports_client.wait_for_resource_deletion(cls.port[\u0027id\u0027])"},{"line_number":69,"context_line":"        cls.subnets_client.delete_subnet(cls.subnet[\u0027id\u0027])"},{"line_number":70,"context_line":"        cls.networks_client.delete_network(cls.network[\u0027id\u0027])"},{"line_number":71,"context_line":"        super(ComputeServersRbacTest, cls).resource_cleanup()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def _create_network_resources(cls):"}],"source_content_type":"text/x-python","patch_set":21,"id":"df140735_93960a3e","line":71,"range":{"start_line":67,"start_character":8,"end_line":71,"end_character":61},"updated":"2017-06-02 22:50:36.000000000","message":"See below.","commit_id":"ce6bbfb194a9af2d75fec3340a1844a7d8b4ae2a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d70273ab46eb2e36f97aac9a93c1d50da697bef5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        network_name \u003d data_utils.rand_name("},{"line_number":77,"context_line":"            cls.__class__.__name__ + \u0027-network\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        cls.network \u003d cls.networks_client.create_network("},{"line_number":80,"context_line":"            name\u003dnetwork_name, port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Create subnet for the network"},{"line_number":83,"context_line":"        subnet_name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-subnet\u0027)"},{"line_number":84,"context_line":"        cls.subnet \u003d cls.subnets_client.create_subnet("},{"line_number":85,"context_line":"            name\u003dsubnet_name,"},{"line_number":86,"context_line":"            network_id\u003dcls.network[\u0027id\u0027],"},{"line_number":87,"context_line":"            cidr\u003dCONF.network.project_network_cidr,"},{"line_number":88,"context_line":"            ip_version\u003d4)[\u0027subnet\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        cls.port \u003d cls.ports_client.create_port("},{"line_number":91,"context_line":"            network_id\u003dcls.network[\u0027id\u0027])[\u0027port\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _create_test_server_with_volume(self, volume_id):"},{"line_number":94,"context_line":"        # Create a server with the volume created earlier"}],"source_content_type":"text/x-python","patch_set":21,"id":"df140735_33ce1e82","line":91,"range":{"start_line":79,"start_character":7,"end_line":91,"end_character":49},"updated":"2017-06-02 22:50:36.000000000","message":"All the base network helpers can be used here instead: create_network, create_subnet and create_port.","commit_id":"ce6bbfb194a9af2d75fec3340a1844a7d8b4ae2a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d70273ab46eb2e36f97aac9a93c1d50da697bef5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":159,"context_line":"                                         networks\u003d[network_id])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # The network resources created is for this test case only. We will"},{"line_number":162,"context_line":"        # clean them up after this test case. In order to do that,"},{"line_number":163,"context_line":"        # we need to clean up the server first."},{"line_number":164,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"}],"source_content_type":"text/x-python","patch_set":21,"id":"df140735_d38b621c","line":161,"range":{"start_line":161,"start_character":40,"end_line":161,"end_character":42},"updated":"2017-06-02 22:50:36.000000000","message":"are","commit_id":"ce6bbfb194a9af2d75fec3340a1844a7d8b4ae2a"}],"releasenotes/notes/add-security-group-tests-ae5c07074e0ac849.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a50687eb74effe957496b9efb47fec96ab5f4ebc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added security groups and server security groups"},{"line_number":5,"context_line":"    tests to Nova RBAC tests."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"df140735_782bf881","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2017-06-06 22:20:04.000000000","message":"Add","commit_id":"5d6aa0ea45f65584158c5f49fc2d00cd5df58560"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a50687eb74effe957496b9efb47fec96ab5f4ebc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    tests to Nova RBAC tests."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Added microversion check to test_security_groups_rbac"},{"line_number":9,"context_line":"    as tests in this file will fail with a 404 after"},{"line_number":10,"context_line":"    2.36."},{"line_number":11,"context_line":"  - Renamed test_server_security_groups to"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"df140735_5820349c","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"updated":"2017-06-06 22:20:04.000000000","message":"Add","commit_id":"5d6aa0ea45f65584158c5f49fc2d00cd5df58560"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a50687eb74effe957496b9efb47fec96ab5f4ebc","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Added microversion check to test_security_groups_rbac"},{"line_number":9,"context_line":"    as tests in this file will fail with a 404 after"},{"line_number":10,"context_line":"    2.36."},{"line_number":11,"context_line":"  - Renamed test_server_security_groups to"},{"line_number":12,"context_line":"    test_list_security_groups to properly reflect the"},{"line_number":13,"context_line":"    test actually being run."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"df140735_382580ac","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"updated":"2017-06-06 22:20:04.000000000","message":"Rename","commit_id":"5d6aa0ea45f65584158c5f49fc2d00cd5df58560"}]}
