)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"19ae46c6cfc95b251a104368beec8f4fc2851485","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove singleton from RbacUtils constructor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the RbacUtils in rbac_utils is a singleton,"},{"line_number":10,"context_line":"which means the constructor is only called once. The problem with"},{"line_number":11,"context_line":"that is when we instantiate rbac_utils in each rbac_base class,"},{"line_number":12,"context_line":"we have to then also call switch_role(toggle_rbac_role\u003dFalse)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_468f2acc","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":27},"updated":"2017-05-04 16:55:21.000000000","message":"class in","commit_id":"76cab14cd7a9d2cfa283fd9f7bb5ee820457e0bc"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"19ae46c6cfc95b251a104368beec8f4fc2851485","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the RbacUtils in rbac_utils is a singleton,"},{"line_number":10,"context_line":"which means the constructor is only called once. The problem with"},{"line_number":11,"context_line":"that is when we instantiate rbac_utils in each rbac_base class,"},{"line_number":12,"context_line":"we have to then also call switch_role(toggle_rbac_role\u003dFalse)."},{"line_number":13,"context_line":"We could do that inside the constructor to simplify the code,"},{"line_number":14,"context_line":"but only if RbacUtils constructor stops being a singleton -- or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_e6b75686","line":11,"range":{"start_line":11,"start_character":28,"end_line":11,"end_character":38},"updated":"2017-05-04 16:55:21.000000000","message":"RbacUtils","commit_id":"76cab14cd7a9d2cfa283fd9f7bb5ee820457e0bc"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"19ae46c6cfc95b251a104368beec8f4fc2851485","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In addition, setting \"rbac_utils \u003d RbacUtils\" at the end of rbac_utils"},{"line_number":19,"context_line":"is pointless and only makes the code harder to read. This patch"},{"line_number":20,"context_line":"removes tha line of code and refactors the imports for rbac_utils where"},{"line_number":21,"context_line":"necessary."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I778ae19b4bd0b71ab77984ae57dd96fd829a1fc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_669226f9","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":11},"updated":"2017-05-04 16:55:21.000000000","message":"that","commit_id":"76cab14cd7a9d2cfa283fd9f7bb5ee820457e0bc"}]}
