)]}'
{"patrole_tempest_plugin/tests/api/volume/rbac_base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"127248a2053b253b225bb0bf31c3db5dccbfc6c0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not CONF.rbac.enable_rbac:"},{"line_number":32,"context_line":"            raise cls.skipException("},{"line_number":33,"context_line":"                \"%s skipped as RBAC testing not enabled\" % cls.__name__)"},{"line_number":34,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":35,"context_line":"            msg \u003d \"%s skipped as image feature is not enabled.\" % cls.__name__"},{"line_number":36,"context_line":"            raise cls.skipException(msg)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_77c3358a","line":36,"range":{"start_line":34,"start_character":8,"end_line":36,"end_character":40},"updated":"2017-06-05 20:49:05.000000000","message":"This belongs in classes that use image_client (i.e. in test_volume_actions_rbac.py and test_volume_metadata_rbac.py), not here, because we shouldn\u0027t skip all the volume tests just for a few tests that need image client.\n\nAlso, to me it makes more sense to do:\n\nif not CONF.image_feature_enabled.api_v2:\n            msg \u003d \"%s skipped as v2 image feature is not enabled.\" % cls.__name__\n            raise cls.skipException(msg)","commit_id":"ef296e11f1a198e6039d2ec06013fc661a5de97d"},{"author":{"_account_id":25101,"name":"Manik Sidana","username":"maniksidana","inactive":true},"change_message_id":"4f398c978f9f6ea3ace0d011e973baf2bf9eb601","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not CONF.rbac.enable_rbac:"},{"line_number":32,"context_line":"            raise cls.skipException("},{"line_number":33,"context_line":"                \"%s skipped as RBAC testing not enabled\" % cls.__name__)"},{"line_number":34,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":35,"context_line":"            msg \u003d \"%s skipped as image feature is not enabled.\" % cls.__name__"},{"line_number":36,"context_line":"            raise cls.skipException(msg)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_8acfae27","line":36,"range":{"start_line":34,"start_character":8,"end_line":36,"end_character":40},"in_reply_to":"df140735_77c3358a","updated":"2017-06-06 08:00:52.000000000","message":"Ok yes, you\u0027re right. I missed this part.","commit_id":"ef296e11f1a198e6039d2ec06013fc661a5de97d"}],"patrole_tempest_plugin/tests/api/volume/test_volume_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8be788d76b5260e7b2172ba02331ce9a1871dcb8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    # TODO(felipemonteiro): \"volume_extension:volume_actions:upload_public\""},{"line_number":33,"context_line":"    # test can be created once volumes v3 client is created in Tempest."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def skip_checks(cls):"},{"line_number":37,"context_line":"        if not CONF.image_feature_enabled.api_v2:"},{"line_number":38,"context_line":"            msg \u003d \"%s skipped as v2 image feature is not \" \\"},{"line_number":39,"context_line":"                \"enabled.\" % cls.__name__"},{"line_number":40,"context_line":"            raise cls.skipException(msg)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_ab69398c","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":40},"updated":"2017-06-09 20:45:23.000000000","message":"I don\u0027t actually think these checks are needed because these tests should still work with the image v1 API. Not only that, but we\u0027re no longer offering support for the glance v1 API so this check isn\u0027t necessary.","commit_id":"a6d42ae3ccf7749212ebef52f9a007c5ae03bcf3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8be788d76b5260e7b2172ba02331ce9a1871dcb8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def setup_clients(cls):"},{"line_number":44,"context_line":"        super(VolumesActionsRbacTest, cls).setup_clients()"},{"line_number":45,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":46,"context_line":"            cls.image_client \u003d cls.os_primary.image_client"},{"line_number":47,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":48,"context_line":"            cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_2b13e90f","line":48,"range":{"start_line":45,"start_character":8,"end_line":48,"end_character":12},"updated":"2017-06-09 20:45:23.000000000","message":"Remove this. Should just be:\n\ncls.image_client \u003d cls.os_primary.image_client_v2","commit_id":"a6d42ae3ccf7749212ebef52f9a007c5ae03bcf3"}],"patrole_tempest_plugin/tests/api/volume/test_volume_metadata_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"65b5d5115fec54e31fe6c7eecaf34b685acf7cf2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setup_clients(cls):"},{"line_number":29,"context_line":"        super(VolumeMetadataRbacTest, cls).setup_clients()"},{"line_number":30,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":31,"context_line":"        cls.image_id \u003d CONF.compute.image_ref"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_3ded1c8b","line":31,"updated":"2017-05-31 19:53:42.000000000","message":"This repeats L37","commit_id":"4c24d416d6c868a258f1057fa909ef118cec72ef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"127248a2053b253b225bb0bf31c3db5dccbfc6c0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumeMetadataRbacTest(rbac_base.BaseVolumeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"},{"line_number":29,"context_line":"        super(VolumeMetadataRbacTest, cls).setup_clients()"},{"line_number":30,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_57903195","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":57},"updated":"2017-06-05 20:49:05.000000000","message":"This entire code block can be removed. image_client isn\u0027t used anywhere in this file.","commit_id":"ef296e11f1a198e6039d2ec06013fc661a5de97d"},{"author":{"_account_id":25101,"name":"Manik Sidana","username":"maniksidana","inactive":true},"change_message_id":"4f398c978f9f6ea3ace0d011e973baf2bf9eb601","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumeMetadataRbacTest(rbac_base.BaseVolumeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"},{"line_number":29,"context_line":"        super(VolumeMetadataRbacTest, cls).setup_clients()"},{"line_number":30,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_aa0b928b","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":57},"in_reply_to":"df140735_57903195","updated":"2017-06-06 08:00:52.000000000","message":"Ok.","commit_id":"ef296e11f1a198e6039d2ec06013fc661a5de97d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8be788d76b5260e7b2172ba02331ce9a1871dcb8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumeMetadataRbacTest(rbac_base.BaseVolumeRbacTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        if not CONF.image_feature_enabled.api_v2:"},{"line_number":30,"context_line":"            msg \u003d \"%s skipped as v2 image feature is not \" \\"},{"line_number":31,"context_line":"                \"enabled.\" % cls.__name__"},{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_6b3201aa","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":40},"updated":"2017-06-09 20:45:23.000000000","message":"We can remove this altogether.","commit_id":"a6d42ae3ccf7749212ebef52f9a007c5ae03bcf3"}]}