)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"60f94c3ffe0b4cd3fb79bd6bb8bd076769eab986","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Samantha Blanco \u003csamantha.blanco@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-24 10:27:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds volume summary test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds test for volumes v3 client show_volume_summary."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia5ab97976a783defb3f129269d105d768db4c54e"},{"line_number":12,"context_line":"Partial-Bug: #1691528"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ff0f0b1f_d44f9868","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":52},"updated":"2017-05-24 20:01:34.000000000","message":"when i see the diff between PS10 and Base, it doesn\u0027t show a new test that is added. Can you confirm if I am seeing this correctly or not?\n\nIf no new test case is added, then please update the commit message and release note.","commit_id":"9d325a1379f697f95928a27ce3b7ed1f1fb9cbfe"}],"patrole_tempest_plugin/tests/api/volume/test_volume_actions_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9590e86e82043dd8b04b533941de458c0687856f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            attachment_id\u003dattachment[\u0027attachment_id\u0027])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class VolumesActionsV3RbacTest(VolumesActionsRbacTest):"},{"line_number":206,"context_line":"    _api_version \u003d 3"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    min_microversion \u003d \u00273.12\u0027"},{"line_number":209,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u0027a654833d-4811-4acd-93ef-5ac4a34c75bc\u0027)"},{"line_number":212,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\", rule\u003d\"volume:get_all\")"},{"line_number":213,"context_line":"    def test_show_volume_summary(self):"},{"line_number":214,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":215,"context_line":"        self.volumes_client.show_volume_summary()[\u0027volume-summary\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a53130a5","line":215,"range":{"start_line":205,"start_character":0,"end_line":215,"end_character":67},"updated":"2017-05-19 02:02:44.000000000","message":"adding microversion tests along with base tests is not good way. Now it will run all VolumesActionsV3RbacTest tests (present in VolumesActionsRbacTest) with version \u00273.12\u0027 not as v3 base version.\nI think that is not you wanted to do. you want all VolumesActionsV3RbacTest tests run with base v3 version and test_show_volume_summary with \u00273.12\u0027.\n\nTo do that we need to have separate class for the microversion tests. i tried to capture that point in https://docs.openstack.org/developer/tempest/microversion_testing.html#step4-separate-test-classes-for-each-microversion\n\nAnother point to care is inherit microversion tests class from base test class so that we do not end up running unnecessary tests for that microversion. \nSomething like below:\n\nclass VolumesActionsV3RbacTest(VolumesActionsRbacTest):\n    _api_version \u003d 3\n\n\nclass VolumesActionsV312RbacTest(rbac_base.BaseVolumeRbacTest):\n    _api_version \u003d 3\n    min_microversion \u003d \u00273.12\u0027\n    max_microversion \u003d \u0027latest\u0027\n\n    @decorators.idempotent_id(\u0027a654833d-4811-4acd-93ef-5ac4a34c75bc\u0027)\n    @rbac_rule_validation.action(service\u003d\"cinder\", rule\u003d\"volume:get_all\")\n    def test_show_volume_summary(self):\n        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)\n        volume_summary \u003d \\\n            self.volumes_client.show_volume_summary()[\u0027volume-summary\u0027]","commit_id":"56ea5a5140bcd8bfda3ac32637b7190bec8e5645"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0d2ea9dcec24cf29f67a364bf14f6bfba1c50ea5","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.volumes_client.force_detach_volume("},{"line_number":199,"context_line":"            self.volume[\u0027id\u0027], connector\u003dNone,"},{"line_number":200,"context_line":"            attachment_id\u003dattachment[\u0027attachment_id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class VolumesActionsV3RbacTest(VolumesActionsRbacTest):"},{"line_number":204,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_daa74ca7","line":201,"updated":"2017-05-19 16:59:18.000000000","message":"Still missing:\n\nclass VolumesActionsV3RbacTest(VolumesActionsRbacTest):\n    _api_version \u003d 3","commit_id":"8f78c47f2c2fcca69e8d3653ef34aab5c64d4880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0d2ea9dcec24cf29f67a364bf14f6bfba1c50ea5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            attachment_id\u003dattachment[\u0027attachment_id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class VolumesActionsV3RbacTest(VolumesActionsRbacTest):"},{"line_number":204,"context_line":"    _api_version \u003d 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    min_microversion \u003d \u00273.12\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_fac9f077","line":203,"range":{"start_line":203,"start_character":31,"end_line":203,"end_character":53},"updated":"2017-05-19 16:59:18.000000000","message":"Should inherit from rbac_base.BaseVolumeRbacTest","commit_id":"8f78c47f2c2fcca69e8d3653ef34aab5c64d4880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0d2ea9dcec24cf29f67a364bf14f6bfba1c50ea5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            attachment_id\u003dattachment[\u0027attachment_id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class VolumesActionsV3RbacTest(VolumesActionsRbacTest):"},{"line_number":204,"context_line":"    _api_version \u003d 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    min_microversion \u003d \u00273.12\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_9abf94cf","line":203,"range":{"start_line":203,"start_character":6,"end_line":203,"end_character":30},"updated":"2017-05-19 16:59:18.000000000","message":"VolumesActionsV312RbacTest","commit_id":"8f78c47f2c2fcca69e8d3653ef34aab5c64d4880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0d2ea9dcec24cf29f67a364bf14f6bfba1c50ea5","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027a654833d-4811-4acd-93ef-5ac4a34c75bc\u0027)"},{"line_number":210,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\", rule\u003d\"volume:get_all\")"},{"line_number":211,"context_line":"    def test_show_volume_summary(self):"},{"line_number":212,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":213,"context_line":"        volume_summary \u003d \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_1a79442e","line":210,"range":{"start_line":210,"start_character":64,"end_line":210,"end_character":71},"updated":"2017-05-19 16:59:18.000000000","message":"Looks correct according to https://github.com/openstack/cinder/blob/eececaa9d17165f7d429830a3243189c67857ff0/cinder/volume/api.py#L576","commit_id":"8f78c47f2c2fcca69e8d3653ef34aab5c64d4880"}]}