)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8e744ec5268b277e3c3da5f21609af9af16cf4f6","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            glance_admin_client \u003d self.os_admin.image_client"},{"line_number":312,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":313,"context_line":"            glance_admin_client \u003d self.os_admin.image_client_v2"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":316,"context_line":"                \u0027Either api_v1 or api_v2 must be True in \u0027"},{"line_number":317,"context_line":"                \u0027[image-feature-enabled].\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_dd3b1fc6","line":314,"updated":"2017-05-25 15:31:23.000000000","message":"Why not a test.service check to see if Glance is enabled?","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b8247b7c66d562490fe950308f5052cb1f7cf720","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            glance_admin_client \u003d self.os_admin.image_client"},{"line_number":312,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":313,"context_line":"            glance_admin_client \u003d self.os_admin.image_client_v2"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":316,"context_line":"                \u0027Either api_v1 or api_v2 must be True in \u0027"},{"line_number":317,"context_line":"                \u0027[image-feature-enabled].\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_ef1ce114","line":314,"in_reply_to":"ff0f0b1f_dd3b1fc6","updated":"2017-05-25 18:46:34.000000000","message":"See L302","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77f1a6b483c0729ed0acda931ce455abee8cf82e","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # Use admin credentials to wait since waiting involves show, which is"},{"line_number":327,"context_line":"        # a different policy."},{"line_number":328,"context_line":"        image_id \u003d data_utils.parse_image_id(resp[\u0027location\u0027])"},{"line_number":329,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":330,"context_line":"                        glance_admin_client.delete_image, image_id)"},{"line_number":331,"context_line":"        waiters.wait_for_image_status(glance_admin_client, image_id, \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_087f05ac","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":62},"updated":"2017-05-26 02:53:39.000000000","message":"this is being changed in microcversion \u00272.45\u0027. from 2.45, image_id is being returned directly in resp body and not in \u0027Location\u0027 header.\n\nLet me try on tempest side by fetching version info from API. similarly we can do here.","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"979fb15825ac5056fb7fc8b59204ed89771afd90","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # Use admin credentials to wait since waiting involves show, which is"},{"line_number":327,"context_line":"        # a different policy."},{"line_number":328,"context_line":"        image_id \u003d data_utils.parse_image_id(resp[\u0027location\u0027])"},{"line_number":329,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":330,"context_line":"                        glance_admin_client.delete_image, image_id)"},{"line_number":331,"context_line":"        waiters.wait_for_image_status(glance_admin_client, image_id, \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_5787d810","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":62},"in_reply_to":"ff0f0b1f_087f05ac","updated":"2017-05-26 04:21:31.000000000","message":"I see that\u0027s the case in Location response docs here: https://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-server-back-up-createbackup-action-detail\n\nI\u0027ll fix in next patch.","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a6ddda76232b4d3fd5ea3f974907e1c60f938300","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # Use admin credentials to wait since waiting involves show, which is"},{"line_number":327,"context_line":"        # a different policy."},{"line_number":328,"context_line":"        image_id \u003d data_utils.parse_image_id(resp[\u0027location\u0027])"},{"line_number":329,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":330,"context_line":"                        glance_admin_client.delete_image, image_id)"},{"line_number":331,"context_line":"        waiters.wait_for_image_status(glance_admin_client, image_id, \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_6491f899","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":62},"in_reply_to":"ff0f0b1f_423f14b5","updated":"2017-05-30 06:34:27.000000000","message":"yes, you will get this. I need to fix on Tempest side. \n\nI was thinking to get api version from response as nova return the honored version in each response. I will try to push Tempest change for this.","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9dfb33c7d756cdb1ef87099819c18f0c60b75ada","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # Use admin credentials to wait since waiting involves show, which is"},{"line_number":327,"context_line":"        # a different policy."},{"line_number":328,"context_line":"        image_id \u003d data_utils.parse_image_id(resp[\u0027location\u0027])"},{"line_number":329,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":330,"context_line":"                        glance_admin_client.delete_image, image_id)"},{"line_number":331,"context_line":"        waiters.wait_for_image_status(glance_admin_client, image_id, \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_423f14b5","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":62},"in_reply_to":"ff0f0b1f_5787d810","updated":"2017-05-26 05:02:00.000000000","message":"In my local env I get the following error if I use min_microversion \u003d \u00272.45\u0027:\n\nDetails: HTTP response body is invalid json or xml\nDetails: HTTP response body should not exist ({u\u0027image_id\u0027: u\u00276817be62-e732-49c7-8922-554fc222635f\u0027}) An unexpected exception has occurred: Expected exception was Forbidden, which was not thrown.\n\nLooks like Tempest doesn\u0027t have schema/logic to handle this yet.","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"8e744ec5268b277e3c3da5f21609af9af16cf4f6","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                               \"Compute host fake-host not found.\","},{"line_number":402,"context_line":"                               self.servers_client.evacuate_server,"},{"line_number":403,"context_line":"                               self.server_id,"},{"line_number":404,"context_line":"                               host\u003d\u0027fake-host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_3df1fb02","line":404,"updated":"2017-05-25 15:31:23.000000000","message":"I think it might be better to randomly generate a name here (that can be done in another commit).","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b8247b7c66d562490fe950308f5052cb1f7cf720","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                               \"Compute host fake-host not found.\","},{"line_number":402,"context_line":"                               self.servers_client.evacuate_server,"},{"line_number":403,"context_line":"                               self.server_id,"},{"line_number":404,"context_line":"                               host\u003d\u0027fake-host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_cfeebdec","line":404,"in_reply_to":"ff0f0b1f_3df1fb02","updated":"2017-05-25 18:46:34.000000000","message":"Yeah I did that, then undid it because the regex on L401 needs to be updated too, so I\u0027ll do in follow up patch.","commit_id":"ebdcbb0f2e47087f6447444d236e201ae1953cfb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dc7c9b10548946b971021d83d8475676094e03db","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        # header. With microversion 2.45+, image_id is returned."},{"line_number":329,"context_line":"        min_version \u003d CONF.compute.min_microversion"},{"line_number":330,"context_line":"        config_min_version \u003d api_version_request.APIVersionRequest(min_version)"},{"line_number":331,"context_line":"        if config_min_version \u003e\u003d api_version_request.APIVersionRequest(\u00272.45\u0027):"},{"line_number":332,"context_line":"            image_id \u003d resp[\u0027image_id\u0027]"},{"line_number":333,"context_line":"        else:"},{"line_number":334,"context_line":"            image_id \u003d data_utils.parse_image_id(resp.response[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_8fc2e584","line":331,"range":{"start_line":331,"start_character":11,"end_line":331,"end_character":29},"updated":"2017-05-30 06:38:25.000000000","message":"humm, this is not always true. config_min_version might be  what service client will use for API request but not always. We have some logic to choose the API version used by service client. \n\nWe should fetch the API version from response header. i think that can be used for API also.\nI will try to put some generic method in lib to handle that which can be used here also.","commit_id":"ac7771665d37ef6e24a50bf2a26fde15e1be9707"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d2b64e93eaf27e99a3009b3f1a6838fd5e628d28","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        # header. With microversion 2.45+, image_id is returned."},{"line_number":329,"context_line":"        min_version \u003d CONF.compute.min_microversion"},{"line_number":330,"context_line":"        config_min_version \u003d api_version_request.APIVersionRequest(min_version)"},{"line_number":331,"context_line":"        if config_min_version \u003e\u003d api_version_request.APIVersionRequest(\u00272.45\u0027):"},{"line_number":332,"context_line":"            image_id \u003d resp[\u0027image_id\u0027]"},{"line_number":333,"context_line":"        else:"},{"line_number":334,"context_line":"            image_id \u003d data_utils.parse_image_id(resp.response[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ddcf697d","line":331,"range":{"start_line":331,"start_character":11,"end_line":331,"end_character":29},"in_reply_to":"df140735_8fc2e584","updated":"2017-05-30 16:43:42.000000000","message":"Thanks, I\u0027ll look out for it until then.","commit_id":"ac7771665d37ef6e24a50bf2a26fde15e1be9707"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e51a8d8cdc84f0cd7dfff9cc9436d0782549b406","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # Prior to microversion 2.45, image ID must be parsed from location"},{"line_number":322,"context_line":"        # header. With microversion 2.45+, image_id is returned."},{"line_number":323,"context_line":"        if api_version_utils.compare_version_header_to_request("},{"line_number":324,"context_line":"                \"X-OpenStack-Nova-API-Version\", \"2.45\", resp, \"lt\"):"},{"line_number":325,"context_line":"            image_id \u003d resp[\u0027image_id\u0027]"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            image_id \u003d data_utils.parse_image_id(resp[\u0027location\u0027])"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        # Use admin credentials to wait since waiting involves show, which is"},{"line_number":330,"context_line":"        # a different policy."}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_87620e09","line":327,"range":{"start_line":323,"start_character":0,"end_line":327,"end_character":66},"updated":"2017-08-30 06:05:58.000000000","message":"looks good, you can change the function name as per https://review.openstack.org/#/c/476263/4","commit_id":"6b723a79bae9d6b3911a4c786b1acde1ce1706ee"}]}
