)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"530831d38bada37db272a00660c03f04158c680f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        with a 400 BadRequest (policy enforcement is done before that happens)."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":261,"context_line":"        if CONF.service_available.neutron:"},{"line_number":262,"context_line":"            msg \u003d \"Listing virtual interfaces is not supported by this cloud.\""},{"line_number":263,"context_line":"            with self.assertRaisesRegex(lib_exc.BadRequest, msg):"},{"line_number":264,"context_line":"                self.servers_client.list_virtual_interfaces(self.server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_69d56d43","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":42},"updated":"2017-07-07 15:31:19.000000000","message":"should this be `if not CONF.service_available.neutron` based on the docstring above \"If Neutron is not available, then call the API and expect it to fail with a 400 BadRequest\"","commit_id":"5dd86615c0860e55985aea637d7554c22b8e1d4d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"89b56e75f54c0de5010b07542083b675dfea9672","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        with a 400 BadRequest (policy enforcement is done before that happens)."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":261,"context_line":"        if CONF.service_available.neutron:"},{"line_number":262,"context_line":"            msg \u003d \"Listing virtual interfaces is not supported by this cloud.\""},{"line_number":263,"context_line":"            with self.assertRaisesRegex(lib_exc.BadRequest, msg):"},{"line_number":264,"context_line":"                self.servers_client.list_virtual_interfaces(self.server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_8a4e46bf","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":42},"in_reply_to":"3f1d235d_69d56d43","updated":"2017-07-10 17:26:34.000000000","message":"Thanks for pointing that out; I think the comment is incorrectly worded. I\u0027ll verify that and recommit.","commit_id":"5dd86615c0860e55985aea637d7554c22b8e1d4d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"60a0f6dbb375baf15f244f8cc784d0bb43ee599c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        with a 400 BadRequest (policy enforcement is done before that happens)."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":261,"context_line":"        if CONF.service_available.neutron:"},{"line_number":262,"context_line":"            msg \u003d \"Listing virtual interfaces is not supported by this cloud.\""},{"line_number":263,"context_line":"            with self.assertRaisesRegex(lib_exc.BadRequest, msg):"},{"line_number":264,"context_line":"                self.servers_client.list_virtual_interfaces(self.server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_ae4b3685","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":42},"in_reply_to":"3f1d235d_8a4e46bf","updated":"2017-07-11 13:51:54.000000000","message":"no, its nova-net only things. If Cloud is using neutron, then it is not implemented and 400 from api service. \n\nhttps://github.com/openstack/nova/blob/86bccc32cb68408cac61a406bafa14017cc3b2af/nova/network/neutronv2/api.py#L1944","commit_id":"5dd86615c0860e55985aea637d7554c22b8e1d4d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"039164214f606660b4f91973b1a0d6cf91705c07","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        with a 400 BadRequest (policy enforcement is done before that happens)."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":261,"context_line":"        if CONF.service_available.neutron:"},{"line_number":262,"context_line":"            msg \u003d \"Listing virtual interfaces is not supported by this cloud.\""},{"line_number":263,"context_line":"            with self.assertRaisesRegex(lib_exc.BadRequest, msg):"},{"line_number":264,"context_line":"                self.servers_client.list_virtual_interfaces(self.server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_49f5bcec","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":42},"in_reply_to":"3f1d235d_ae4b3685","updated":"2017-07-11 13:58:27.000000000","message":"i see, comment was wrong there. nice catch.","commit_id":"5dd86615c0860e55985aea637d7554c22b8e1d4d"}]}