)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f77873dd7fd0194b39adc9b63d5a77b718b7ded2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if server_id:"},{"line_number":69,"context_line":"            self.delete_server(server_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.password \u003d data_utils.rand_password()"},{"line_number":72,"context_line":"        return self.create_test_server("},{"line_number":73,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027, adminPass\u003dself.password)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_73652145","line":71,"updated":"2017-07-25 16:19:12.000000000","message":"Is there a reason the rebuilt server is always being created with a password?","commit_id":"fe5d58e209212044392ff740092f0abd2f7ef3f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b2d704ab722154c758578a17687dd416a0d97878","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if server_id:"},{"line_number":69,"context_line":"            self.delete_server(server_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.password \u003d data_utils.rand_password()"},{"line_number":72,"context_line":"        return self.create_test_server("},{"line_number":73,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027, adminPass\u003dself.password)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_492ca901","line":71,"in_reply_to":"ff346bd7_73652145","updated":"2017-07-25 18:19:55.000000000","message":"Copy/pasted it from Tempest\u0027s implementation here: https://github.com/openstack/tempest/blob/72312d9911b7349c5eeaf8746874086d227a5655/tempest/api/compute/base.py#L333\n\nReason for that is because Tempest\u0027s implementation returns server[\u0027id\u0027] but ``test_show_instance_action`` requires server.response[\u0027x-compute-request-id\u0027] which in turn requires that a reference to the most recent server \"build\" or else an exception is thrown.","commit_id":"fe5d58e209212044392ff740092f0abd2f7ef3f8"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f77873dd7fd0194b39adc9b63d5a77b718b7ded2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            raise rbac_exceptions.RbacMalformedResponse(attribute\u003d\u0027events\u0027)"},{"line_number":198,"context_line":"        # Microversion 2.51+ returns \u0027events\u0027 always, but not \u0027traceback\u0027. If"},{"line_number":199,"context_line":"        # \u0027traceback\u0027 is also present then policy enforcement passed."},{"line_number":200,"context_line":"        if \u0027traceback\u0027 not in instance_action[\u0027events\u0027][0]:"},{"line_number":201,"context_line":"            raise rbac_exceptions.RbacMalformedResponse("},{"line_number":202,"context_line":"                attribute\u003d\u0027events.traceback\u0027)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_0e134a5e","line":200,"updated":"2017-07-25 16:19:12.000000000","message":"Is \u0027traceback\u0027 always present in microversion \u003c2.51? The way this code reads now, an exception will be raised if \u0027traceback\u0027 is missing no matter what.","commit_id":"fe5d58e209212044392ff740092f0abd2f7ef3f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b2d704ab722154c758578a17687dd416a0d97878","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            raise rbac_exceptions.RbacMalformedResponse(attribute\u003d\u0027events\u0027)"},{"line_number":198,"context_line":"        # Microversion 2.51+ returns \u0027events\u0027 always, but not \u0027traceback\u0027. If"},{"line_number":199,"context_line":"        # \u0027traceback\u0027 is also present then policy enforcement passed."},{"line_number":200,"context_line":"        if \u0027traceback\u0027 not in instance_action[\u0027events\u0027][0]:"},{"line_number":201,"context_line":"            raise rbac_exceptions.RbacMalformedResponse("},{"line_number":202,"context_line":"                attribute\u003d\u0027events.traceback\u0027)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_a968b520","line":200,"in_reply_to":"ff346bd7_0e134a5e","updated":"2017-07-25 18:19:55.000000000","message":"[0] doesn\u0027t show micorversion for events.traceback and [1] indicates that it\u0027s been around since 2.1.\n\nIn any case, the tests you\u0027ve provided comments for are unrelated to this patch so if they need to be fixed they\u0027ll have to be down in a separate patchset.\n\n[0] https://developer.openstack.org/api-ref/compute/?expanded\u003dshow-server-action-details-detail#id158\n[1] https://github.com/openstack/tempest/blob/72312d9911b7349c5eeaf8746874086d227a5655/tempest/lib/api_schema/response/compute/v2_1/servers.py#L430","commit_id":"fe5d58e209212044392ff740092f0abd2f7ef3f8"}]}