)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f0fd2ee5f8c4a08fef69012488a50cb00aa5b3e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"},{"line_number":194,"context_line":"        # get_service_list can be used from new location."},{"line_number":195,"context_line":"        #if not test.get_service_list()[\u0027network\u0027]:"},{"line_number":196,"context_line":"        #    raise cls.skipException("},{"line_number":197,"context_line":"        #        \u0027Skipped because the network service is not available\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @classmethod"},{"line_number":200,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8ce3e605","line":197,"range":{"start_line":195,"start_character":8,"end_line":197,"end_character":72},"updated":"2017-08-24 05:32:30.000000000","message":"This was added before I was aware of network always being True... so we do not need this and no point in changing to new version. We should just remove all of skip_checks here.","commit_id":"53add9962f29d3c4179c05f05a36d95fab9fd4ec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"114b489b45f8713d85ae357948a30570a7c97884","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"},{"line_number":194,"context_line":"        # get_service_list can be used from new location."},{"line_number":195,"context_line":"        #if not test.get_service_list()[\u0027network\u0027]:"},{"line_number":196,"context_line":"        #    raise cls.skipException("},{"line_number":197,"context_line":"        #        \u0027Skipped because the network service is not available\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @classmethod"},{"line_number":200,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_4ca97e79","line":197,"range":{"start_line":195,"start_character":8,"end_line":197,"end_character":72},"in_reply_to":"7f287b81_8ce3e605","updated":"2017-08-24 05:43:38.000000000","message":"ok. i can remove that but once nova-network is gone (already deprecated) then, we might need to check \u0027neutron service\u0027 for smooth skipping the tests instead of failing everything and then finding that there is noone to serve network.  \n\nFor that reason only i kept it commented.","commit_id":"53add9962f29d3c4179c05f05a36d95fab9fd4ec"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"11ad1f151ee0d03b72d76a0ef55cd178e5eb7c49","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        cls.set_network_resources(network\u003dTrue, subnet\u003dTrue)"},{"line_number":183,"context_line":"        super(SecurtiyGroupsRbacTest, cls).setup_credentials()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def skip_checks(cls):"},{"line_number":187,"context_line":"        super(SecurtiyGroupsRbacTest, cls).skip_checks()"},{"line_number":188,"context_line":"        # All the tests below require the network service."},{"line_number":189,"context_line":"        # NOTE(gmann) Currently \u0027network\u0027 service is always True in"},{"line_number":190,"context_line":"        # test.get_service_list() SO below check is not much of use."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_1a9e0554","line":187,"range":{"start_line":185,"start_character":4,"end_line":187,"end_character":56},"updated":"2017-08-24 08:25:47.000000000","message":"If we remove all checks this should go away, we don\u0027t need to keep it just for the comment I think.","commit_id":"8b6fee1cc568cc20ef691150dafe37fab23bc8fd"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"11ad1f151ee0d03b72d76a0ef55cd178e5eb7c49","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        super(SecurtiyGroupsRbacTest, cls).skip_checks()"},{"line_number":188,"context_line":"        # All the tests below require the network service."},{"line_number":189,"context_line":"        # NOTE(gmann) Currently \u0027network\u0027 service is always True in"},{"line_number":190,"context_line":"        # test.get_service_list() SO below check is not much of use."},{"line_number":191,"context_line":"        # Commenting the below check as Tempest is moving the get_service_list"},{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_fa9e9961","line":190,"range":{"start_line":190,"start_character":35,"end_line":190,"end_character":36},"updated":"2017-08-24 08:25:47.000000000","message":"o","commit_id":"8b6fee1cc568cc20ef691150dafe37fab23bc8fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ffe7cb886943f29fc3e807187d7ea64cc1b1ae83","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        super(SecurtiyGroupsRbacTest, cls).skip_checks()"},{"line_number":188,"context_line":"        # All the tests below require the network service."},{"line_number":189,"context_line":"        # NOTE(gmann) Currently \u0027network\u0027 service is always True in"},{"line_number":190,"context_line":"        # test.get_service_list() SO below check is not much of use."},{"line_number":191,"context_line":"        # Commenting the below check as Tempest is moving the get_service_list"},{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_1accc55f","line":190,"range":{"start_line":190,"start_character":35,"end_line":190,"end_character":36},"in_reply_to":"7f287b81_fa9e9961","updated":"2017-08-24 08:27:35.000000000","message":"Done","commit_id":"8b6fee1cc568cc20ef691150dafe37fab23bc8fd"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"11ad1f151ee0d03b72d76a0ef55cd178e5eb7c49","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"},{"line_number":194,"context_line":"        # get_service_list can be used from new location."},{"line_number":195,"context_line":"        # if not test.get_service_list()[\u0027network\u0027]:"},{"line_number":196,"context_line":"        #    raise cls.skipException("},{"line_number":197,"context_line":"        #        \u0027Skipped because the network service is not available\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @classmethod"},{"line_number":200,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_3a7e6119","line":197,"range":{"start_line":195,"start_character":0,"end_line":197,"end_character":72},"updated":"2017-08-24 08:25:47.000000000","message":"Why not keeping the check in anyways? When n-net goes away this won\u0027t have to change.","commit_id":"8b6fee1cc568cc20ef691150dafe37fab23bc8fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ffe7cb886943f29fc3e807187d7ea64cc1b1ae83","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # from test.py to utils."},{"line_number":193,"context_line":"        # If we want to check \u0027network\u0027 service availability, then"},{"line_number":194,"context_line":"        # get_service_list can be used from new location."},{"line_number":195,"context_line":"        # if not test.get_service_list()[\u0027network\u0027]:"},{"line_number":196,"context_line":"        #    raise cls.skipException("},{"line_number":197,"context_line":"        #        \u0027Skipped because the network service is not available\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @classmethod"},{"line_number":200,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_7ae749e6","line":197,"range":{"start_line":195,"start_character":0,"end_line":197,"end_character":72},"in_reply_to":"7f287b81_3a7e6119","updated":"2017-08-24 08:27:35.000000000","message":"yea so we keep this checks with comment and fix once we release the tempest new version","commit_id":"8b6fee1cc568cc20ef691150dafe37fab23bc8fd"}]}