)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"93f3486d9269b0b7a22e887560daed9750b6b8dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- making use of RbacMalformedResponse to ensure rxtx_factor"},{"line_number":12,"context_line":"  is included in response body"},{"line_number":13,"context_line":"- adding new flavor_rxtx tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7fb35212fc6bb817a2b04077c983865e1191f214"},{"line_number":16,"context_line":"Closes-Bug: #1712725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_c492a54b","line":14,"updated":"2017-08-25 22:16:32.000000000","message":"I think we should also mention here that we can\u0027t test the POST action (https://github.com/openstack/nova/blob/1080506f16905d16086974eb729ba3d204139566/nova/policies/flavor_rxtx.py#L40) because that enforces os-flavor-manage:create which is admin-only by default so we\u0027d need multi-policy support for that.","commit_id":"6f30f1c0176e34ac07714045ef1ada933879f7b4"}],"patrole_tempest_plugin/tests/api/compute/test_flavor_rxtx_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b58652b15c9d6ca98b1aa07c70d60fea9bd66b2a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @rbac_rule_validation.action("},{"line_number":39,"context_line":"        service\u003d\"nova\","},{"line_number":40,"context_line":"        rule\u003d\"os_compute_api:os-flavor-rxtx\")"},{"line_number":41,"context_line":"    def test_list_flavors_rxtx(self):"},{"line_number":42,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":43,"context_line":"        # Enforces os_compute_api:os-flavor-rxtx"},{"line_number":44,"context_line":"        self.flavors_client.list_flavors()[\u0027flavors\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_131c6e76","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":30},"updated":"2017-08-26 17:57:22.000000000","message":"This test should be removed. It\u0027s not a valid endpoint here: https://github.com/openstack/nova/blob/6119f6ff516c0092ecf17e9da1b05f0f8b7f4193/nova/policies/flavor_rxtx.py#L25","commit_id":"6f30f1c0176e34ac07714045ef1ada933879f7b4"}],"releasenotes/notes/flavor-rxtx-d7aadbb32a9f232c.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"93f3486d9269b0b7a22e887560daed9750b6b8dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Renamed and refactored existing flavor_rxtx test to"},{"line_number":5,"context_line":"    clarify what was occuring during testing"},{"line_number":6,"context_line":"  - Added additional flavor_rxtx tests"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_64d09120","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":44},"updated":"2017-08-25 22:16:32.000000000","message":"I don\u0027t believe this is necessary.","commit_id":"6f30f1c0176e34ac07714045ef1ada933879f7b4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"93f3486d9269b0b7a22e887560daed9750b6b8dd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Renamed and refactored existing flavor_rxtx test to"},{"line_number":5,"context_line":"    clarify what was occuring during testing"},{"line_number":6,"context_line":"  - Added additional flavor_rxtx tests"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_c4a4e5bb","line":6,"updated":"2017-08-25 22:16:32.000000000","message":"We can just say we now have complete coverage for it.\n\n\nTechnically this is also a bug fix given my explanation here: https://review.openstack.org/#/c/496080/5/patrole_tempest_plugin/tests/api/compute/test_flavor_access_rbac.py","commit_id":"6f30f1c0176e34ac07714045ef1ada933879f7b4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9614fc26c18100bdab01c84a2331b10406a3dabe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Renamed and refactored existing flavor_rxtx test to"},{"line_number":5,"context_line":"    clarify what was occuring during testing"},{"line_number":6,"context_line":"  - Added additional flavor_rxtx tests"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_f352023b","line":6,"in_reply_to":"7f287b81_c4a4e5bb","updated":"2017-08-26 17:48:14.000000000","message":"On second thought, I don\u0027t think it\u0027s necessary to keep conveying that we\u0027re fixing up tests. Currently, Patrole is in a very agile, unstable state, so I don\u0027t personally mind release notes for tests. Going forward, once Patrole gets more stable, it\u0027ll be better if we used reno more sparingly, mostly for new features and framework-related bug fixes and the like.","commit_id":"6f30f1c0176e34ac07714045ef1ada933879f7b4"}]}
