)]}'
{"patrole_tempest_plugin/rbac_rule_validation.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4a00e426b6a5f7cb7f65b4c87a19ca98764b0724","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                 \"check for policy action {0}.\".format(rule))"},{"line_number":229,"context_line":"        return rbac_utils.is_admin()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    base_rule_result \u003d _check_rule_is_authorized("},{"line_number":232,"context_line":"        test_obj, service, rule, extra_target_data)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if base_rule_result is True or False:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_51c156e4","line":231,"range":{"start_line":231,"start_character":23,"end_line":231,"end_character":48},"updated":"2017-08-31 16:54:20.000000000","message":"You\u0027ll want to catch the exception here and try using the fallback rule.\n\ni.e.:\n\n    try:\n        rule_result \u003d _check_rule_is_authorized(...)\n    except (rbac_exceptions.RbacParsingException, testtools.TestCase.skipException):\n        pass\n\n    # Pass the fallback rule here if it was passed in;\n    # allow exceptions to bubble up here, because we\u0027re out of options\n    LOG.debug(\u0027Using fallback rule: %s\u0027 % fallback_rule)\n    rule_result \u003d _check_rule_is_authorized(...)\n    return rule_result\n\nSomething like that","commit_id":"e36ee81734e3fb31dd043d29eab5c814fddf2a02"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4a00e426b6a5f7cb7f65b4c87a19ca98764b0724","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if CONF.patrole.strict_policy_check:"},{"line_number":285,"context_line":"            raise e"},{"line_number":286,"context_line":"        else:"},{"line_number":287,"context_line":"            return testtools.TestCase.skipException(str(e))"},{"line_number":288,"context_line":"    return False"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_911c5ec2","line":287,"range":{"start_line":287,"start_character":12,"end_line":287,"end_character":18},"updated":"2017-08-31 16:54:20.000000000","message":"This should still be raise","commit_id":"e36ee81734e3fb31dd043d29eab5c814fddf2a02"}]}
