)]}'
{"patrole_tempest_plugin/tests/api/compute/test_fixed_ips_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2da04483340e5c80c1e0cd3f5ef37a777094d2c6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    cls.ip \u003d ip[\u0027addr\u0027]"},{"line_number":48,"context_line":"                    break"},{"line_number":49,"context_line":"            if cls.ip:"},{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027c89391f7-4844-4a70-a116-37c1336efb99\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_9c25e75e","line":50,"updated":"2017-10-16 16:07:07.000000000","message":"I see this is borrowed from Tempest. Is cls.ip always guaranteed to be initialized?","commit_id":"752d9fa4619837064d0b76ca2f45f4d984a3bf1e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"34dd2fefbb14c94197cc848207ff974b36b532fa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    cls.ip \u003d ip[\u0027addr\u0027]"},{"line_number":48,"context_line":"                    break"},{"line_number":49,"context_line":"            if cls.ip:"},{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027c89391f7-4844-4a70-a116-37c1336efb99\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_aeffcd32","line":50,"in_reply_to":"3f4b6375_7c799d2d","updated":"2017-10-30 20:24:31.000000000","message":"I\u0027d prefer it but would be nice to have Tempest core\u0027s opinion here as if this is a non-issue we can proceed, else we should fix it in Tempest too.","commit_id":"752d9fa4619837064d0b76ca2f45f4d984a3bf1e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"54b6254f91738ef75fef8b4c8c99a654ab63420f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    cls.ip \u003d ip[\u0027addr\u0027]"},{"line_number":48,"context_line":"                    break"},{"line_number":49,"context_line":"            if cls.ip:"},{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027c89391f7-4844-4a70-a116-37c1336efb99\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_6b53fce3","line":50,"in_reply_to":"3f4b6375_aeffcd32","updated":"2017-10-31 02:38:39.000000000","message":"i was searching it on nova code whether each server will have this attribute and did not get any 100% confirmation.\n\nI prefer to skip tests if no ip. ll push the fix on tempest side also.\n\nThanks for pointing it.","commit_id":"752d9fa4619837064d0b76ca2f45f4d984a3bf1e"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"3f88225171ea89ade3f93dce669c0ac9ef28eff2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    cls.ip \u003d ip[\u0027addr\u0027]"},{"line_number":48,"context_line":"                    break"},{"line_number":49,"context_line":"            if cls.ip:"},{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027c89391f7-4844-4a70-a116-37c1336efb99\u0027)"},{"line_number":53,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_7c799d2d","line":50,"in_reply_to":"5f4e5783_9c25e75e","updated":"2017-10-30 10:34:04.000000000","message":"yes it can be uninitialized if no fixed ip, should we skip this class tests if no cls.ip\u0027s as all tests need a valid cls.ip\u0027s?","commit_id":"752d9fa4619837064d0b76ca2f45f4d984a3bf1e"}]}