)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e787bf20471379789b23b8df989144474394fe7c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        waiters.wait_for_server_status("},{"line_number":73,"context_line":"            self.os_admin.servers_client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _shelve_server(self):"},{"line_number":76,"context_line":"        self.servers_client.shelve_server(self.server_id)"},{"line_number":77,"context_line":"        self.addCleanup(self._cleanup_server_actions,"},{"line_number":78,"context_line":"                        self.servers_client.unshelve_server,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_1f84edb0","line":75,"updated":"2017-10-28 23:10:39.000000000","message":"Looks like this is copied from tempest.common.compute but that\u0027s OK because you use admin client for waiting.","commit_id":"736b4048cd72e71574a87c32b2414f1a1d78d79b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e787bf20471379789b23b8df989144474394fe7c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _cleanup_server_actions(self, action, server_id, **action_arg):"},{"line_number":91,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":92,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":93,"context_line":"            action(server_id, **action_arg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7f9d2109","line":90,"range":{"start_line":90,"start_character":38,"end_line":90,"end_character":44},"updated":"2017-10-28 23:10:39.000000000","message":"nit: May we rename action to function?","commit_id":"736b4048cd72e71574a87c32b2414f1a1d78d79b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e787bf20471379789b23b8df989144474394fe7c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _cleanup_server_actions(self, action, server_id, **action_arg):"},{"line_number":91,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":92,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":93,"context_line":"            action(server_id, **action_arg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5fa2654d","line":90,"range":{"start_line":90,"start_character":59,"end_line":90,"end_character":69},"updated":"2017-10-28 23:10:39.000000000","message":"nit: May we rename action_arg to kwargs?","commit_id":"736b4048cd72e71574a87c32b2414f1a1d78d79b"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"53b38a664ef9473c941d3e50e20a8b44872e3416","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _cleanup_server_actions(self, action, server_id, **action_arg):"},{"line_number":91,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":92,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":93,"context_line":"            action(server_id, **action_arg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_e8f38f72","line":90,"range":{"start_line":90,"start_character":38,"end_line":90,"end_character":44},"in_reply_to":"3f4b6375_7f9d2109","updated":"2017-10-30 07:42:51.000000000","message":"Thanks for reviewing, i will update both in next patch","commit_id":"736b4048cd72e71574a87c32b2414f1a1d78d79b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bdd14a37be1fb98ddd12d512ff2455a818100176","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup(self._cleanup_server_actions,"},{"line_number":78,"context_line":"                        self.servers_client.unshelve_server,"},{"line_number":79,"context_line":"                        self.server_id)"},{"line_number":80,"context_line":"        offload_time \u003d CONF.compute.shelved_offload_time"},{"line_number":81,"context_line":"        if offload_time \u003e\u003d 0:"},{"line_number":82,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":83,"context_line":"                                           self.server_id,"},{"line_number":84,"context_line":"                                           \u0027SHELVED_OFFLOADED\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_d9d11c25","line":81,"range":{"start_line":80,"start_character":8,"end_line":81,"end_character":29},"updated":"2017-11-06 03:08:13.000000000","message":"Reading the policy documentation for this, looks like shelve-offload policy is only ever enforced for the shelve-offload action API? Can the shelve-offload policy ever be enforced based off this configuration value?","commit_id":"e3a11631e92a3db000f1ec2939990e8f22f883f0"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"42e3cde7d5c821136c5182bcb77db514d47b6760","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup(self._cleanup_server_actions,"},{"line_number":78,"context_line":"                        self.servers_client.unshelve_server,"},{"line_number":79,"context_line":"                        self.server_id)"},{"line_number":80,"context_line":"        offload_time \u003d CONF.compute.shelved_offload_time"},{"line_number":81,"context_line":"        if offload_time \u003e\u003d 0:"},{"line_number":82,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":83,"context_line":"                                           self.server_id,"},{"line_number":84,"context_line":"                                           \u0027SHELVED_OFFLOADED\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_79522837","line":81,"range":{"start_line":80,"start_character":8,"end_line":81,"end_character":29},"in_reply_to":"3f4b6375_d9d11c25","updated":"2017-11-06 03:35:51.000000000","message":"As per my understanding shelve offload policy can not be enforced with this configuration value, it is just used here to compare the server status after shelve action.","commit_id":"e3a11631e92a3db000f1ec2939990e8f22f883f0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bdd14a37be1fb98ddd12d512ff2455a818100176","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    @rbac_rule_validation.action("},{"line_number":292,"context_line":"        service\u003d\"nova\","},{"line_number":293,"context_line":"        rule\u003d\"os_compute_api:os-shelve:shelve\")"},{"line_number":294,"context_line":"    def test_shelve_server(self):"},{"line_number":295,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":296,"context_line":"        self._shelve_server()"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b97ae020","line":294,"updated":"2017-11-06 03:08:13.000000000","message":"nit: These 2 tests have the same runtime looking at the gates. 17s versus 20s. I think they could be bunched together in the slow gate because of that.","commit_id":"e3a11631e92a3db000f1ec2939990e8f22f883f0"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"42e3cde7d5c821136c5182bcb77db514d47b6760","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    @rbac_rule_validation.action("},{"line_number":292,"context_line":"        service\u003d\"nova\","},{"line_number":293,"context_line":"        rule\u003d\"os_compute_api:os-shelve:shelve\")"},{"line_number":294,"context_line":"    def test_shelve_server(self):"},{"line_number":295,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":296,"context_line":"        self._shelve_server()"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_5933ec14","line":294,"in_reply_to":"3f4b6375_b97ae020","updated":"2017-11-06 03:35:51.000000000","message":"I will add this to slow tests.","commit_id":"e3a11631e92a3db000f1ec2939990e8f22f883f0"}]}