)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8cb9dc331f95f4f12f2ed2bd0dcd11be1280bbec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rajat29 \u003crajat.sharma@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-27 13:28:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Show \u0027 update_backup \u0027 policy tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1189f53f32b5008200dbf2b67e349577973065df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_a77baef2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"updated":"2017-10-27 08:58:09.000000000","message":"please provide more information in commit msg like link to policy and what API it is enforced.","commit_id":"e8ac456287187e2d9effff0e2eea7945ce1453f5"}],"patrole_tempest_plugin/tests/api/volume/test_volumes_backup_rbac.py":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"c9bb88ecc57fc586a3335e1ee6a4e5dc96cf67e2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        backup \u003d self.create_backup(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":131,"context_line":"        self.backup_client.update_backup((backup[\u0027id\u0027])[\u0027backup\u0027])"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":134,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_5c260c6a","line":131,"updated":"2017-10-27 09:54:00.000000000","message":"please update any argument like \u0027name\u0027 in backup request.\nfor reference.","commit_id":"e8ac456287187e2d9effff0e2eea7945ce1453f5"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"ed149d56dc29b053b02a2487702c6f4c8bbf3d46","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        backup \u003d self.create_backup(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":131,"context_line":"        self.backup_client.update_backup((backup[\u0027id\u0027])[\u0027backup\u0027])"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":134,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_bc14e0e9","line":131,"in_reply_to":"3f4b6375_5c260c6a","updated":"2017-10-27 09:54:56.000000000","message":"https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_backup.py#L171","commit_id":"e8ac456287187e2d9effff0e2eea7945ce1453f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fa281d8fcccd5902a131ba12033489fe7debe8d9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":135,"context_line":"        self.backup_client.update_backup(backup[\u0027id\u0027],"},{"line_number":136,"context_line":"                                         **update_kwargs)[\u0027backup\u0027]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_c13f77b3","line":135,"range":{"start_line":135,"start_character":13,"end_line":135,"end_character":26},"updated":"2017-10-30 22:14:41.000000000","message":"I don\u0027t think this is defined anywhere [0].\n\nShould be `backups_client`.\n\n[0] https://github.com/openstack/tempest/blob/1235b81b9cebd6e54aa362b3094c0027c3b5bf74/tempest/api/volume/base.py#L73","commit_id":"b8e4fb804964efd3b02a5f54efadf2a4c0274b33"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"186e128a2df2d4cd7055c40e2477ea5f2a6945b6","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":135,"context_line":"        self.backups_client.update_backup(backup[\u0027id\u0027],"},{"line_number":136,"context_line":"                                         **update_kwargs)[\u0027backup\u0027]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":139,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_514543b3","line":136,"updated":"2017-11-02 10:28:57.000000000","message":"need 1 more space","commit_id":"9e1ee42cf8b14fd527aaeea07d7b7aa5401134ce"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9570c4c1035c5b9a0d07afdc3d8bfc74b8042351","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":120,"context_line":"            self.admin_backups_client, restore[\u0027backup_id\u0027], \u0027available\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":123,"context_line":"    @decorators.idempotent_id(\u002752481a42-5a4e-40ef-9224-13f513744433\u0027)"},{"line_number":124,"context_line":"    @rbac_rule_validation.action("},{"line_number":125,"context_line":"        service\u003d\"cinder\","},{"line_number":126,"context_line":"        rule\u003d\"backup:update\")"},{"line_number":127,"context_line":"    def test_backup_update(self):"},{"line_number":128,"context_line":"        backup \u003d self.create_backup(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":129,"context_line":"        update_kwargs \u003d {"},{"line_number":130,"context_line":"            \u0027name\u0027: data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027),"},{"line_number":131,"context_line":"            \u0027description\u0027: data_utils.rand_name(\"volume-backup-description\")"},{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":135,"context_line":"        self.backups_client.update_backup(backup[\u0027id\u0027],"},{"line_number":136,"context_line":"                                          **update_kwargs)[\u0027backup\u0027]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":139,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_d87a5622","line":136,"range":{"start_line":122,"start_character":0,"end_line":136,"end_character":68},"updated":"2017-11-03 09:39:05.000000000","message":"this test is added in microversion 3.9 so has to be added as separate class.\nlike https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_backup.py#L148\n\ncreate separate class like done in tempest and then you will be good to go.","commit_id":"8e9bbd46eee8a368970c00a67d6a142ad30a5a47"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6b6a8baaa86fcec91002f643729e0b7170fb4a8a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    @rbac_rule_validation.action("},{"line_number":125,"context_line":"        service\u003d\"cinder\","},{"line_number":126,"context_line":"        rule\u003d\"backup:update\")"},{"line_number":127,"context_line":"    def test_backup_update(self):"},{"line_number":128,"context_line":"        backup \u003d self.create_backup(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":129,"context_line":"        update_kwargs \u003d {"},{"line_number":130,"context_line":"            \u0027name\u0027: data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_4da8988a","line":127,"updated":"2017-11-08 03:58:55.000000000","message":"This entire test can be removed now as it lives in its own class below","commit_id":"b7f3546dc6fc16f98c87fc69ae47303c7e478f25"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6b6a8baaa86fcec91002f643729e0b7170fb4a8a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":231,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @decorators.idempotent_id(\u0027b45b0e98-6eb8-4c62-aa53-0f8c7c09faa6\u0027)"},{"line_number":234,"context_line":"    @rbac_rule_validation.action("},{"line_number":235,"context_line":"        service\u003d\"cinder\","},{"line_number":236,"context_line":"        rule\u003d\"backup:update\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_ed906450","line":233,"updated":"2017-11-08 03:58:55.000000000","message":"Nit: missing slow decorator tag","commit_id":"b7f3546dc6fc16f98c87fc69ae47303c7e478f25"}]}