)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"2c48502b6204f89a6b7a947768417ecb2a48c9ae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":"    def _pause_server(self):"},{"line_number":90,"context_line":"        self.servers_client.pause_server(self.server_id)"},{"line_number":91,"context_line":"        self.addCleanup(self._cleanup_server_actions,"},{"line_number":92,"context_line":"                        self.servers_client.unpause_server,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_6809df2f","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":28},"updated":"2017-10-30 08:00:47.000000000","message":"Please add a blank line above.","commit_id":"2dd1d81ba43d4709e8b4524f12231d8452a7a0ac"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"c4fa3ed5db4e991c8685135c8676b37c2ce99cef","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":"    "},{"line_number":90,"context_line":"    def _pause_server(self):"},{"line_number":91,"context_line":"        self.servers_client.pause_server(self.server_id)"},{"line_number":92,"context_line":"        self.addCleanup(self._cleanup_server_actions,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b1edfe8c","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":4},"updated":"2017-10-30 09:56:25.000000000","message":"Remove this whitespace","commit_id":"bcbe3da22bb3e9a1d0152be39b987b219ca1f332"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b35fe7006358416445ef061f53a60931ad4a128b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":88,"context_line":"                                           self.server_id, \u0027SHELVED\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _pause_server(self):"},{"line_number":91,"context_line":"        self.servers_client.pause_server(self.server_id)"},{"line_number":92,"context_line":"        self.addCleanup(self._cleanup_server_actions,"},{"line_number":93,"context_line":"                        self.servers_client.unpause_server,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_39532ce5","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":21},"updated":"2017-10-30 16:27:15.000000000","message":"May we remove these helper functions and put the logic directly inside the tests? These helpers are only used once and this makes code readability more difficult.","commit_id":"a1cc4d546f8c79c317c229633e12104d701f16cb"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e306500e15ead2928011b093c99c248f5ed0b18c","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _unpause_server(self):"},{"line_number":99,"context_line":"        self.servers_client.unpause_server(self.server_id)"},{"line_number":100,"context_line":"        waiters.wat_forserver_status("},{"line_number":101,"context_line":"            self.os_admin.servers_client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _cleanup_server_actions(self, action, server_id, **action_arg):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_6cdc3346","line":100,"range":{"start_line":100,"start_character":16,"end_line":100,"end_character":36},"updated":"2017-10-31 04:51:01.000000000","message":"wrong function name","commit_id":"a1cc4d546f8c79c317c229633e12104d701f16cb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b35fe7006358416445ef061f53a60931ad4a128b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @rbac_rule_validation.action("},{"line_number":118,"context_line":"        service\u003d\"nova\","},{"line_number":119,"context_line":"        rule\u003d\"os_compute_api:server:unpause\")"},{"line_number":120,"context_line":"    def test_unpause__server(self):"},{"line_number":121,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":122,"context_line":"        self._unpause_server()"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_9944601d","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":28},"updated":"2017-10-30 16:27:15.000000000","message":"nit: test_unpause_server","commit_id":"a1cc4d546f8c79c317c229633e12104d701f16cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43f276b91b053af8997ea79731d9f972d0e213f6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @decorators.idempotent_id(\u0027117f4ff2-8544-437b-824f-5e41cb6640ee\u0027)"},{"line_number":96,"context_line":"    @rbac_rule_validation.action("},{"line_number":97,"context_line":"        service\u003d\"nova\","},{"line_number":98,"context_line":"        rule\u003d\"os_compute_api:servers:pause\")"},{"line_number":99,"context_line":"    def test_pause_server(self):"},{"line_number":100,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":101,"context_line":"        self.servers_client.pause_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_5305270f","line":98,"range":{"start_line":98,"start_character":14,"end_line":98,"end_character":42},"updated":"2017-11-03 10:04:13.000000000","message":"there is no such rule it should be \"os_compute_api:os-pause-server:pause\"","commit_id":"7ea8b2425c10de44fe7eabfefa88438e3e6dec15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43f276b91b053af8997ea79731d9f972d0e213f6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027087008cf-82fa-4eeb-ae8b-32c4126456ad\u0027)"},{"line_number":109,"context_line":"    @rbac_rule_validation.action("},{"line_number":110,"context_line":"        service\u003d\"nova\","},{"line_number":111,"context_line":"        rule\u003d\"os_compute_api:server:unpause\")"},{"line_number":112,"context_line":"    def test_unpause_server(self):"},{"line_number":113,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":114,"context_line":"        self.servers_client.unpause_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_93ff1f00","line":111,"range":{"start_line":111,"start_character":14,"end_line":111,"end_character":43},"updated":"2017-11-03 10:04:13.000000000","message":"ditto","commit_id":"7ea8b2425c10de44fe7eabfefa88438e3e6dec15"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"795c26475a0cd11d10fd04f7bc4f27542a05505c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def test_unpause_server(self):"},{"line_number":113,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":114,"context_line":"        self.servers_client.unpause_server(self.server_id)"},{"line_number":115,"context_line":"        waiters.wait_forserver_status("},{"line_number":116,"context_line":"            self.os_admin.servers_client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8c7beff2","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":37},"updated":"2017-10-31 05:25:30.000000000","message":"s/wait_forserver_status/wait_for_server_status ?","commit_id":"7ea8b2425c10de44fe7eabfefa88438e3e6dec15"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"795c26475a0cd11d10fd04f7bc4f27542a05505c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        waiters.wait_forserver_status("},{"line_number":116,"context_line":"            self.os_admin.servers_client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":119,"context_line":"    @rbac_rule_validation.action("},{"line_number":120,"context_line":"        service\u003d\"nova\","},{"line_number":121,"context_line":"        rule\u003d\"os_compute_api:servers:stop\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8c640f4b","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":33},"updated":"2017-10-31 05:25:30.000000000","message":"why is this decorator added?","commit_id":"7ea8b2425c10de44fe7eabfefa88438e3e6dec15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3c6a5a181a3295baf5839141e3a810d384e6a495","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        waiters.wait_forserver_status("},{"line_number":116,"context_line":"            self.os_admin.servers_client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":119,"context_line":"    @rbac_rule_validation.action("},{"line_number":120,"context_line":"        service\u003d\"nova\","},{"line_number":121,"context_line":"        rule\u003d\"os_compute_api:servers:stop\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8f39a1a4","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":33},"in_reply_to":"3f4b6375_8c640f4b","updated":"2017-10-31 06:10:31.000000000","message":"yea this is not needed. it is no slow test.","commit_id":"7ea8b2425c10de44fe7eabfefa88438e3e6dec15"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"40df1f4656c72fe63bac82ff22d687e44210c6ac","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":101,"context_line":"            function(server_id, **kwargs)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u0027117f4ff2-8544-437b-824f-5e41cb6640ee\u0027)"},{"line_number":104,"context_line":"    @rbac_rule_validation.action("},{"line_number":105,"context_line":"        service\u003d\"nova\","},{"line_number":106,"context_line":"        rule\u003d\"os_compute_api:os-pause-server:pause\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_64b7d688","line":103,"updated":"2017-11-10 08:53:02.000000000","message":"These tests are missing the necessary feature flag decorator:\n\n    @testtools.skipUnless(CONF.compute_feature_enabled.pause,\n                          \u0027Pause is not available.\u0027)","commit_id":"0ca30c8af6fd8f0ab729275ea5ee08db238ac1dd"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b23e5147f57dda49689467fc49e6b0cd02f71df0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":111,"context_line":"        self._pause_server()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027087008cf-82fa-4eeb-ae8b-32c4126456ad\u0027)"},{"line_number":114,"context_line":"    @rbac_rule_validation.action("},{"line_number":115,"context_line":"        service\u003d\"nova\","},{"line_number":116,"context_line":"        rule\u003d\"os_compute_api:os-pause-server:unpause\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_aab7d5d8","line":113,"updated":"2017-11-10 10:55:16.000000000","message":"Sorry for not being clear. This one also needs the skipUnless decorator since it does _pause_server too during set up.","commit_id":"0516378fadd6dedf13f7eb8dde15eda36ab35f8d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f9ab022f68439b0559bb71d0b1c42ed595d73251","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":101,"context_line":"            function(server_id, **kwargs)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u0027117f4ff2-8544-437b-824f-5e41cb6640ee\u0027)"},{"line_number":104,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"},{"line_number":105,"context_line":"                          \u0027Pause is not available.\u0027)"},{"line_number":106,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_173ed2d9","line":103,"updated":"2017-11-14 07:55:44.000000000","message":"This test takes 200s+ to run, could add slow decorator tag here.\n\nhttp://logs.openstack.org/79/516179/11/check/legacy-tempest-dsvm-patrole-admin/269ac5b/job-output.txt.gz#_2017-11-14_06_14_27_438407","commit_id":"9b15903a663295edb74cf61e218ac308de60a4d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80ca6edf2791e1d21311124397b49d8e89d5cdbd","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def _cleanup_server_actions(self, function, server_id, **kwargs):"},{"line_number":99,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":100,"context_line":"        if server[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":101,"context_line":"            function(server_id, **kwargs)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u0027117f4ff2-8544-437b-824f-5e41cb6640ee\u0027)"},{"line_number":104,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_eea7a50a","line":101,"range":{"start_line":101,"start_character":11,"end_line":101,"end_character":41},"updated":"2017-11-16 00:25:09.000000000","message":"this can return 409 in many case when server is not state to perform action. \n\ni would like to catch 409 here and return pass.\n\nBut thats not in this patch scope so we can fix later if we extend usage of this function.","commit_id":"e5c8e6d81af0ecc40708fa366f2f0f184ebe1b63"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80ca6edf2791e1d21311124397b49d8e89d5cdbd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":111,"context_line":"        self._pause_server()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":114,"context_line":"    @decorators.idempotent_id(\u0027087008cf-82fa-4eeb-ae8b-32c4126456ad\u0027)"},{"line_number":115,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"},{"line_number":116,"context_line":"                          \u0027Pause is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_4ed5991b","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":33},"updated":"2017-11-16 00:25:09.000000000","message":"we should not make it slow tests, it takes only 3.9 sec\nIt not slow on tempest side also.\n\n- http://logs.openstack.org/79/516179/13/check/legacy-tempest-dsvm-patrole-multinode-admin/e74a2d1/job-output.txt.gz#_2017-11-15_23_17_06_267372","commit_id":"e5c8e6d81af0ecc40708fa366f2f0f184ebe1b63"}]}