)]}'
{"patrole_tempest_plugin/tests/api/volume/test_snapshots_metadata_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"13fa89be29fab878fed3a6aafc0066f7c81a6770","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","},{"line_number":85,"context_line":"                                 rule\u003d\"volume:update_snapshot_metadata\")"},{"line_number":86,"context_line":"    def test_update_snapshot_metadata(self):"},{"line_number":87,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":88,"context_line":"        self._create_test_snapshot_metadata()"},{"line_number":89,"context_line":"        update \u003d {\"key3\": \"value3_update\","},{"line_number":90,"context_line":"                  \"key4\": \"value4\"}"},{"line_number":91,"context_line":"        self.snapshots_client.update_snapshot_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_a44b8e85","line":88,"range":{"start_line":87,"start_character":8,"end_line":88,"end_character":45},"updated":"2017-11-10 09:04:15.000000000","message":"These two lines should be swapped.","commit_id":"5b290554a425281c5bd977e0e3adab96f6c84870"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"13fa89be29fab878fed3a6aafc0066f7c81a6770","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                  \"key4\": \"value4\"}"},{"line_number":91,"context_line":"        self.snapshots_client.update_snapshot_metadata("},{"line_number":92,"context_line":"            self.snapshot[\u0027id\u0027], metadata\u003dupdate)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SnapshotMetadataV3RbacTest(SnapshotMetadataRbacTest):"},{"line_number":96,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_a4194e89","line":93,"updated":"2017-11-10 09:04:15.000000000","message":"We can also add tests for:\n\n  * test_update_snapshot_metadata_item which uses self.snapshots_client.update_snapshot_metadata_item and enforces  volume:update_snapshot_metadata [0]\n  * test_delete_snapshot_metadata_item which uses self.snapshots_client.delete_snapshot_metadata_item and enforces volume:delete_snapshot_metadata [1]\n  * test_get_snapshot_metadata_item which uses self.snapshots_client.show_snapshot_metadata_item and enforces volume:get_snapshot_metadata [2]\n\n[0] https://github.com/openstack/cinder/blob/d1d17068a727c0c3a41f6e266d29b84f27bc21e1/cinder/policies/snapshot_metadata.py#L54\n[1] https://github.com/openstack/cinder/blob/d1d17068a727c0c3a41f6e266d29b84f27bc21e1/cinder/policies/snapshot_metadata.py#L65\n[2] https://github.com/openstack/cinder/blob/d1d17068a727c0c3a41f6e266d29b84f27bc21e1/cinder/policies/snapshot_metadata.py#L39","commit_id":"5b290554a425281c5bd977e0e3adab96f6c84870"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b7c497fb2e82300668174f7df0b099ae3752fd70","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._create_test_snapshot_metadata()"},{"line_number":99,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":100,"context_line":"        self.snapshots_client.show_snapshot_metadata_item("},{"line_number":101,"context_line":"            self.snapshot[\u0027id\u0027], \"key3\")[\u0027meta\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u00271f8f43e7-da31-4128-bb3c-73fc548650e3\u0027)"},{"line_number":104,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_0ab9162d","line":101,"range":{"start_line":101,"start_character":40,"end_line":101,"end_character":48},"updated":"2017-11-13 21:13:19.000000000","message":"nit: Not needed, but it\u0027s present above so this is fine","commit_id":"7c3ba053f331c94f9cd1e6b34c7a29a6fcff7dcf"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b7c497fb2e82300668174f7df0b099ae3752fd70","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self._create_test_snapshot_metadata()"},{"line_number":109,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":110,"context_line":"        self.snapshots_client.update_snapshot_metadata_item("},{"line_number":111,"context_line":"            self.snapshot[\u0027id\u0027], \"key3\", meta\u003dupdate_item)[\u0027meta\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u00273ec32516-f7cd-4f88-b78a-ddee67492071\u0027)"},{"line_number":114,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_aa87a261","line":111,"range":{"start_line":111,"start_character":58,"end_line":111,"end_character":66},"updated":"2017-11-13 21:13:19.000000000","message":"Ditto","commit_id":"7c3ba053f331c94f9cd1e6b34c7a29a6fcff7dcf"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b7c497fb2e82300668174f7df0b099ae3752fd70","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def test_delete_snapshot_metadata_item(self):"},{"line_number":117,"context_line":"        self._create_test_snapshot_metadata()"},{"line_number":118,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":119,"context_line":"        self.snapshots_client.delete_snapshot_metadata_item("},{"line_number":120,"context_line":"            self.snapshot[\u0027id\u0027], \"key1\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_17081f2a","line":119,"updated":"2017-11-13 21:13:19.000000000","message":"nit: It would be safer to create a snapshot metadata item on L118 and then delete that item for the RBAC test, to avoid \"key1\" not existing in other tests... but no other tests use key1 so this is fine.","commit_id":"7c3ba053f331c94f9cd1e6b34c7a29a6fcff7dcf"}]}
