)]}'
{"patrole_tempest_plugin/tests/api/volume/test_volumes_backup_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d6be38fccb820454f85190ffabf553c281010b69","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import base64"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import waiters"},{"line_number":20,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_db2a617d","side":"PARENT","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":48},"updated":"2017-11-28 20:13:54.000000000","message":"This is used on L52/55 below so it can\u0027t just be removed outright.","commit_id":"3d0a1eaa90e5cbbd29f343d8a9e6ec85507939a9"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"d016a4d38f5f8254352d150b81e3394213f7f972","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import base64"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import waiters"},{"line_number":20,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_78b1d046","side":"PARENT","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":48},"in_reply_to":"ff82abbf_35c83172","updated":"2017-11-29 03:18:34.000000000","message":"Yeah, this import will be fix [F821] Undefined name \u0027json\u0027. Thanks so much!","commit_id":"3d0a1eaa90e5cbbd29f343d8a9e6ec85507939a9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1e5a8214654f2b83d7db401faa30242ecfcd3c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import base64"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import waiters"},{"line_number":20,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_35c83172","side":"PARENT","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":48},"in_reply_to":"ff82abbf_9f959e89","updated":"2017-11-29 02:35:02.000000000","message":"Please see [0]. The test that expects json failed in the non-voting gate.\n\nAlso:\n\nstack@osboxes:~$ python\nPython 2.7.12 (default, Nov 19 2016, 06:48:10) \n[GCC 5.4.0 20160609] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e json.dumps({\u0027foo\u0027: \u0027bar\u0027})\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027json\u0027 is not defined\n\u003e\u003e\u003e exit()\nstack@osboxes:~$ python3\nPython 3.5.2 (default, Aug 18 2017, 17:48:00) \n[GCC 5.4.0 20160609] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e json.dumps({\u0027foo\u0027: \u0027bar\u0027})\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027json\u0027 is not defined\n\u003e\u003e\u003e exit()\n\nFailed for both versions of Python. Are you sure we don\u0027t need to:\n\n    import json\n\non L15?\n\n[0] http://logs.openstack.org/14/523014/3/check/tempest-dsvm-patrole-multinode-admin/649d7ef/job-output.txt.gz#_2017-11-28_08_30_49_605644","commit_id":"3d0a1eaa90e5cbbd29f343d8a9e6ec85507939a9"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"76bb239a026bf97ecc2171ab6085de8749363dc9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import base64"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import waiters"},{"line_number":20,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_9f959e89","side":"PARENT","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":48},"in_reply_to":"ff82abbf_db2a617d","updated":"2017-11-29 01:25:15.000000000","message":"common json is build-in of python thus we donot need this line.","commit_id":"3d0a1eaa90e5cbbd29f343d8a9e6ec85507939a9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"be3eb14e42f883ba5844a639b60cbe3a3baae676","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_serialization import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.common import waiters"},{"line_number":21,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e32996e5","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":37},"updated":"2017-11-29 22:42:52.000000000","message":"Can we remove this easily as well? I agree that json in oslo.serialization isn\u0027t necessary but not so much about base64.\n\nIf we need base64, then there\u0027s no reason for this patch IMO.","commit_id":"47b24e64f898f94453df706d432be1152c922972"}],"tox.ini":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ce66ebeae521223e634f388bdf0c01eb80cf6fef","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# [H205] Use assert(Greater|Less)(Equal) for comparison."},{"line_number":66,"context_line":"# [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in mock.patch/mock.patch.object calls"},{"line_number":67,"context_line":"# [H904] Delay string interpolations at logging calls."},{"line_number":68,"context_line":"# [F821] Undefined name \u0027json\u0027"},{"line_number":69,"context_line":"enable-extensions \u003d H106,H203,H204,H205,H210,H904"},{"line_number":70,"context_line":"show-source \u003d True"},{"line_number":71,"context_line":"# E123, E125 skipped as they are invalid PEP-8."}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff82abbf_45ec3129","line":68,"updated":"2017-11-28 17:16:37.000000000","message":"If we do add this to ignore, this would go on line 76","commit_id":"dc522028896e9d35b5892e56792029f74889f63c"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"df0295613761c48351c3eeb0b342a2dc0484a419","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# [H205] Use assert(Greater|Less)(Equal) for comparison."},{"line_number":66,"context_line":"# [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in mock.patch/mock.patch.object calls"},{"line_number":67,"context_line":"# [H904] Delay string interpolations at logging calls."},{"line_number":68,"context_line":"# [F821] Undefined name \u0027json\u0027"},{"line_number":69,"context_line":"enable-extensions \u003d H106,H203,H204,H205,H210,H904"},{"line_number":70,"context_line":"show-source \u003d True"},{"line_number":71,"context_line":"# E123, E125 skipped as they are invalid PEP-8."}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff82abbf_9ff6fed6","line":68,"in_reply_to":"ff82abbf_45ec3129","updated":"2017-11-29 01:28:22.000000000","message":"Yeah. Sure.","commit_id":"dc522028896e9d35b5892e56792029f74889f63c"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ce66ebeae521223e634f388bdf0c01eb80cf6fef","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# H405 is another one that is good as a guideline, but sometimes"},{"line_number":74,"context_line":"# multiline doc strings just don\u0027t have a natural summary"},{"line_number":75,"context_line":"# line. Rejecting code for this reason is wrong."},{"line_number":76,"context_line":"ignore \u003d E123,E125,H405,F821"},{"line_number":77,"context_line":"builtins \u003d _"},{"line_number":78,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff82abbf_057dc96c","line":76,"updated":"2017-11-28 17:16:37.000000000","message":"Can you explain the value in adding this to ignore?","commit_id":"dc522028896e9d35b5892e56792029f74889f63c"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"df0295613761c48351c3eeb0b342a2dc0484a419","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# H405 is another one that is good as a guideline, but sometimes"},{"line_number":74,"context_line":"# multiline doc strings just don\u0027t have a natural summary"},{"line_number":75,"context_line":"# line. Rejecting code for this reason is wrong."},{"line_number":76,"context_line":"ignore \u003d E123,E125,H405,F821"},{"line_number":77,"context_line":"builtins \u003d _"},{"line_number":78,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff82abbf_df100603","line":76,"in_reply_to":"ff82abbf_057dc96c","updated":"2017-11-29 01:28:22.000000000","message":"the pep8 will be raise F821 msg, because tox -epep8 run through hacking check. I am not sure how to fix this issue thus I add it into ignore of flake8.","commit_id":"dc522028896e9d35b5892e56792029f74889f63c"}]}