)]}'
{"patrole_tempest_plugin/tests/api/volume/test_volume_metadata_rbac.py":[{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"fe681e6de4b2afcf0e07033fc35048a518b0d062","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.volumes_client.update_volume_image_metadata("},{"line_number":120,"context_line":"            self.volume[\u0027id\u0027], image_id\u003dself.image_id)"},{"line_number":121,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":122,"context_line":"        self.volume_types_client.show_volume_image_metadata(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_390eba32","line":122,"range":{"start_line":122,"start_character":13,"end_line":122,"end_character":32},"updated":"2017-12-13 06:48:31.000000000","message":"I think you should use \"volume_client\" here","commit_id":"6b6546a74254e2546dd12c798ae791f603bfc3e8"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"93de2c924d48b7e8add9381a9b689f81c78391af","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def test_show_volume_image_metadata(self):"},{"line_number":119,"context_line":"        self.volumes_client.update_volume_image_metadata("},{"line_number":120,"context_line":"            self.volume[\u0027id\u0027], image_id\u003dself.image_id)"},{"line_number":121,"context_line":"        self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)"},{"line_number":122,"context_line":"        self.volumes_client.show_volume_image_metadata(self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_72e8d87b","line":122,"range":{"start_line":121,"start_character":8,"end_line":122,"end_character":73},"updated":"2017-12-13 09:54:53.000000000","message":"may be we can refactor this to \nwith self.rbac_utils.override_role(self):\n    self.volumes_client.show_volume_image_metadata(self.volume[\u0027id\u0027])","commit_id":"d0bee49c88021ce048ec8cb91f68881a903494f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6b301c976ab8d194bacb7324d4aec33134ef03f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df87a7cf_873f4f86","line":123,"updated":"2017-12-13 16:53:54.000000000","message":"So the policy documentation isn\u0027t very helpful in this case. This case is actually a bit more complicated. See: [0]\n\nWhen you use fatal\u003dFalse in context.authorize() followed by a call like `_add_image_metadata` this implies that an attribute is added to the response body if policy enforcement succeeds.\n\nNeed to change this test to:\n\n    self.volumes_client.update_volume_image_metadata(\n            self.volume[\u0027id\u0027], image_id\u003dself.image_id)\n    with self.rbac_utils.override_role(self):\n        body \u003d self.volumes_client.show_volume_image_metadata(\n            self.volume[\u0027id\u0027])\n    if \u0027volume_image_metadata\u0027 not in body:\n        raise rbac_exceptions.RbacMalforedException(attribute\u003d\u0027volume_image_metadata\u0027)\n\nCan also add a test for `test_list_details_volume_image_metadata` which also enforces this policy [1]\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_image_metadata.py#L73\n[1] https://github.com/openstack/cinder/blob/2322ced7cc46fe86749cd152879a3852faabd6b5/cinder/policies/volume_metadata.py#L90","commit_id":"a0c58d04802fb24ea3e4c0879f10a59f0f636f78"}]}
