)]}'
{"patrole_tempest_plugin/tests/api/volume/test_group_snapshots_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bf16a1eaf95ade7dcaaa890b63c33d8e90b0bf11","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from patrole_tempest_plugin.tests.api.volume import rbac_base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class BaseGroupSnapshotsRbacTest(rbac_base.BaseVolumeRbacTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _create_group_snapshot(self, **kwargs):"},{"line_number":29,"context_line":"        if \u0027name\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_52703273","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":32},"updated":"2017-12-21 00:32:57.000000000","message":"nit: We don\u0027t really need this class -- but we will when we add reset group snapshot status so this is OK.","commit_id":"6fcd37b9a3cfde888d795fe0423f5e35ced03ca9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bf16a1eaf95ade7dcaaa890b63c33d8e90b0bf11","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                self.__class__.__name__ + \u0027-Group_Snapshot\u0027)"},{"line_number":32,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":33,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":34,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":35,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":36,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":37,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_72dc5646","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":55},"updated":"2017-12-21 00:32:57.000000000","message":"I don\u0027t think we need this line of code, checking in Tempest: https://review.openstack.org/#/c/529434/","commit_id":"6fcd37b9a3cfde888d795fe0423f5e35ced03ca9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a4b4530fd71352b9f4499cb2174e7525d9676a6b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                self.__class__.__name__ + \u0027-Group_Snapshot\u0027)"},{"line_number":32,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":33,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":34,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":35,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":36,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":37,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_d0274864","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":55},"in_reply_to":"bf8cb3f7_72dc5646","updated":"2017-12-21 17:52:43.000000000","message":"Ignore this comment, this is right.","commit_id":"6fcd37b9a3cfde888d795fe0423f5e35ced03ca9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bf16a1eaf95ade7dcaaa890b63c33d8e90b0bf11","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            group_snapshot[\u0027id\u0027])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class GroupSnaphotsRbacTest(BaseGroupSnapshotsRbacTest):"},{"line_number":57,"context_line":"    _api_version \u003d 3"},{"line_number":58,"context_line":"    min_microversion \u003d \u00273.14\u0027"},{"line_number":59,"context_line":"    max_microversion \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_f25386e1","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":27},"updated":"2017-12-21 00:32:57.000000000","message":"GroupSnapshotsV314RbacTest","commit_id":"6fcd37b9a3cfde888d795fe0423f5e35ced03ca9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bf16a1eaf95ade7dcaaa890b63c33d8e90b0bf11","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":91,"context_line":"            self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":92,"context_line":"                                        name\u003dgroup_snapshot_name)"},{"line_number":93,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":94,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":95,"context_line":"        for snap in snapshots:"},{"line_number":96,"context_line":"            if self.vol[\u0027id\u0027] \u003d\u003d snap[\u0027volume_id\u0027]:"},{"line_number":97,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":98,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u00278b966844-4421-4f73-940b-9157cb878331\u0027)"},{"line_number":101,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_324a4e27","line":98,"range":{"start_line":93,"start_character":0,"end_line":98,"end_character":67},"updated":"2017-12-21 00:32:57.000000000","message":"Can we move this to L39?","commit_id":"6fcd37b9a3cfde888d795fe0423f5e35ced03ca9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ee72b4262d91b3b379f914c8e2b7d227324719b4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_create_group_snapshot(self):"},{"line_number":95,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"},{"line_number":96,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":97,"context_line":"            self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":98,"context_line":"                                        name\u003dgroup_snapshot_name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u00278b966844-4421-4f73-940b-9157cb878331\u0027)"},{"line_number":101,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_9f945646","line":98,"range":{"start_line":97,"start_character":12,"end_line":98,"end_character":65},"updated":"2017-12-23 07:35:53.000000000","message":"Unfortunately this function isn\u0027t granular enough (even before the list_snapshots move, because of the waiter in there). This will have to be refactored too:\n\n    with self.rbac_utils.override_role(self):\n        name \u003d data_utils.rand_name(\n            self.__class__.__name__ + \u0027-Group_Snapshot\u0027)\n        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot(\n            name\u003dname)[\u0027group_snapshot\u0027]\n    group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]\n    self.addCleanup(test_utils.call_and_ignore_notfound_exc,\n                    self._delete_group_snapshot, group_snapshot)\n    waiters.wait_for_volume_resource_status(\n        self.group_snapshots_client, group_snapshot[\u0027id\u0027], \u0027available\u0027)\n    snapshots \u003d self.snapshots_client.list_snapshots(\n        detail\u003dTrue)[\u0027snapshots\u0027]\n    for snap in snapshots:\n        if self.vol[\u0027id\u0027] \u003d\u003d snap[\u0027volume_id\u0027]:\n           waiters.wait_for_volume_resource_status(\n               self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)","commit_id":"e36f2092b4ccd08c8dc765d293608a712dac1f78"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"6c816f9f0bf22f1aa4ef53e847d985dbd21bea32","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_create_group_snapshot(self):"},{"line_number":95,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"},{"line_number":96,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":97,"context_line":"            self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":98,"context_line":"                                        name\u003dgroup_snapshot_name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u00278b966844-4421-4f73-940b-9157cb878331\u0027)"},{"line_number":101,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_26b1a890","line":98,"range":{"start_line":97,"start_character":12,"end_line":98,"end_character":65},"in_reply_to":"bf8cb3f7_9f945646","updated":"2018-01-11 09:47:00.000000000","message":"Done","commit_id":"e36f2092b4ccd08c8dc765d293608a712dac1f78"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ee72b4262d91b3b379f914c8e2b7d227324719b4","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        group_snapshot \u003d self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":133,"context_line":"                                                     name\u003dgroup_snapshot_name)"},{"line_number":134,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":135,"context_line":"            self._delete_group_snapshot(group_snapshot)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_5f9ece63","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":55},"updated":"2017-12-23 07:35:53.000000000","message":"See above. This needs to be refactored so that only the delete action is called inside the contextmanager.","commit_id":"e36f2092b4ccd08c8dc765d293608a712dac1f78"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"6c816f9f0bf22f1aa4ef53e847d985dbd21bea32","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        group_snapshot \u003d self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":133,"context_line":"                                                     name\u003dgroup_snapshot_name)"},{"line_number":134,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":135,"context_line":"            self._delete_group_snapshot(group_snapshot)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_46ae342f","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":55},"in_reply_to":"bf8cb3f7_5f9ece63","updated":"2018-01-11 09:47:00.000000000","message":"Done","commit_id":"e36f2092b4ccd08c8dc765d293608a712dac1f78"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"aa88298d2327982147fac6d6b95a3ad0d07db3ba","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        rule\u003d\"group:get_all_group_snapshots\""},{"line_number":129,"context_line":"    )"},{"line_number":130,"context_line":"    def test_list_group_snapshot_rbac(self):"},{"line_number":131,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"},{"line_number":132,"context_line":"        self._create_group_snapshot(group_id\u003dself.grp[\u0027id\u0027],"},{"line_number":133,"context_line":"                                    name\u003dgroup_snapshot_name)"},{"line_number":134,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":135,"context_line":"            self.group_snapshots_client.list_group_snapshots()"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_dd5e80e5","line":133,"range":{"start_line":131,"start_character":0,"end_line":133,"end_character":61},"updated":"2018-01-12 01:09:00.000000000","message":"nit: We should be able to remove this as an optimization. Listing doesn\u0027t require anything to exist, usually.","commit_id":"643786998f3626964693329dd0a0c0eea076c9af"}]}
