)]}'
{"patrole_tempest_plugin/tests/api/compute/rbac_base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return flavor"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def wait_for_server_status(cls, servers, status\u003dNone):"},{"line_number":65,"context_line":"        \"\"\"Helper method to wait for servers to reach desired status."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        This helper method is useful for avoiding extra policy actions being"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_7d96f395","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":30},"updated":"2018-01-16 05:51:29.000000000","message":"we could have use tempest.common.waiters.wait_for_server_status but that is not stable interface so better to write own here.","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        for server in servers:"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                waiters.wait_for_server_status("},{"line_number":89,"context_line":"                    cls.servers_client, server[\u0027id\u0027], status)"},{"line_number":90,"context_line":"            except Exception:"},{"line_number":91,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_dd6147ab","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":46},"updated":"2018-01-16 05:51:29.000000000","message":"you are calling that here :)\n\nm ok as of now. we can migrate together.","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"}],"patrole_tempest_plugin/tests/api/compute/test_server_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_create_server(self):"},{"line_number":53,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":54,"context_line":"            server \u003d self.create_test_server()"},{"line_number":55,"context_line":"        self.wait_for_server_status(server, \u0027ACTIVE\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @rbac_rule_validation.action("},{"line_number":58,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_fdc20359","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":53},"updated":"2018-01-16 05:51:29.000000000","message":"tempest create_test_server was added mainly because tempest test want to wait for their status to check connectivity etc. if patrole does not need i prefer to use create_server directly on servers_client. \nthat depends on case by case but use direct create_server as much as possible. \n\nnow come to this case, i feel we can avoid waiting for ACTIVE server, status change is async task in nova and does not effect policy enforcement for create server.","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":74,"context_line":"            server \u003d self.create_test_server("},{"line_number":75,"context_line":"                availability_zone\u003davailability_zone)"},{"line_number":76,"context_line":"        self.wait_for_server_status(server, \u0027ACTIVE\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":79,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_1dc7af66","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":53},"updated":"2018-01-16 05:51:29.000000000","message":"ditto","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            # Use image_id\u003d\u0027\u0027 to avoid using the default image in tempest.conf."},{"line_number":101,"context_line":"            server \u003d self.create_test_server(name\u003dserver_name, image_id\u003d\u0027\u0027,"},{"line_number":102,"context_line":"                                             **device_mapping)"},{"line_number":103,"context_line":"        self.wait_for_server_status(server, \u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"        # Delete the server and wait for the volume to become available to"},{"line_number":105,"context_line":"        # avoid clean up errors."},{"line_number":106,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5d96974e","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":53},"updated":"2018-01-16 05:51:29.000000000","message":"this too","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":144,"context_line":"            server \u003d self.create_test_server(networks\u003d[network_id])"},{"line_number":145,"context_line":"        self.wait_for_server_status(server, \u0027ACTIVE\u0027)"},{"line_number":146,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":147,"context_line":"                        self.servers_client, server[\u0027id\u0027])"},{"line_number":148,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_1d9c8f68","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":53},"updated":"2018-01-16 05:51:29.000000000","message":"ditto","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c5b19ce12fa41d8363f9da1befa7288493b7940d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        rule\u003d\"os_compute_api:servers:delete\")"},{"line_number":153,"context_line":"    @decorators.idempotent_id(\u0027062e3440-e873-4b41-9317-bf6d8be50c12\u0027)"},{"line_number":154,"context_line":"    def test_delete_server(self):"},{"line_number":155,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":158,"context_line":"            self.servers_client.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_dd8b871c","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":61},"updated":"2018-01-16 05:51:29.000000000","message":"you can make those change here as we want server to ACTIVE before delete.","commit_id":"72887db6a3da3f0039ebe314e87e3ce4d29eb5f8"}]}