)]}'
{"patrole_tempest_plugin/tests/api/volume/test_group_type_specs.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c5379e48bd0f665179596dce420bacce1c15bfe8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_group_type_specs_show(self):"},{"line_number":53,"context_line":"        group_type \u003d self.create_group_type()"},{"line_number":54,"context_line":"        spec_keys \u003d [\u0027key2\u0027]"},{"line_number":55,"context_line":"        self.group_types_client. create_or_update_group_type_specs("},{"line_number":56,"context_line":"            group_type[\u0027id\u0027], spec_keys)[\u0027group_specs\u0027]"},{"line_number":57,"context_line":"        # Show specified item of group type specs"},{"line_number":58,"context_line":"        with self.rbac_utils.override_role(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_d999e4c3","line":55,"range":{"start_line":55,"start_character":32,"end_line":55,"end_character":33},"updated":"2018-02-02 22:53:17.000000000","message":"Syntax error here","commit_id":"d7b53c666208e58944444090040ce78252a6a02d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"63787970f94fde39cbb3443468c7a821fef0d082","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        group_type \u003d self.create_group_type()"},{"line_number":96,"context_line":"        # Delete specified item of group type specs"},{"line_number":97,"context_line":"        delete_key \u003d \u0027key1\u0027"},{"line_number":98,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":99,"context_line":"            self.group_types_client.delete_group_type_specs_item("},{"line_number":100,"context_line":"                group_type[\u0027id\u0027], delete_key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_59eb9411","line":98,"updated":"2018-02-02 22:58:15.000000000","message":"Need to create the group_type_specs before it can be deleted.","commit_id":"d7b53c666208e58944444090040ce78252a6a02d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ea2d1d5095ccc3cd568c19907f2244cfdd088c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FiberHome Telecommunication Technologies CO.,LTD"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_5d8dbb28","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":26},"updated":"2018-02-05 20:27:34.000000000","message":"2018 AT\u0026T Corporation","commit_id":"f6189e1bbcdd889fa070a16e621e44fbd74c262c"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ea2d1d5095ccc3cd568c19907f2244cfdd088c6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.volume import base"},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_ffc49e42","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":35},"updated":"2018-02-05 20:27:34.000000000","message":"This is the wrong base class to import.","commit_id":"8c740bf946b74e36d8c239740f83bf2968ecf01a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ea2d1d5095ccc3cd568c19907f2244cfdd088c6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from patrole_tempest_plugin import rbac_rule_validation"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class GroupTypeSpecsRbacTest(base.BaseVolumeAdminTest):"},{"line_number":23,"context_line":"    _api_version \u003d 3"},{"line_number":24,"context_line":"    min_microversion \u003d \u00273.11\u0027"},{"line_number":25,"context_line":"    max_microversion \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_dfbc42bd","line":22,"range":{"start_line":22,"start_character":29,"end_line":22,"end_character":53},"updated":"2018-02-05 20:27:34.000000000","message":"This is incorrect; it should be inheriting from rbac_base. See how it\u0027s done here: https://github.com/openstack/patrole/blob/13051245302b7df86f52c7d22c3821c5d596aef4/patrole_tempest_plugin/tests/api/volume/test_groups_rbac.py#L26","commit_id":"8c740bf946b74e36d8c239740f83bf2968ecf01a"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"e051b7e26bc87704c0d8dfa66d2033abd87a1ab6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class GroupTypeSpecsRbacTest(base.BaseVolumeAdminTest):"},{"line_number":23,"context_line":"    _api_version \u003d 3"},{"line_number":24,"context_line":"    min_microversion \u003d \u00273.11\u0027"},{"line_number":25,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @decorators.idempotent_id(\u0027b2859734-00ad-4a22-88ee-541698e90d12\u0027)"},{"line_number":28,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_3a945444","line":25,"range":{"start_line":24,"start_character":4,"end_line":25,"end_character":31},"updated":"2018-02-05 20:58:07.000000000","message":"Looking at the documentation, it doesn\u0027t seem like there is a min microversion involved with this API, so these two lines are unnecessary.","commit_id":"8c740bf946b74e36d8c239740f83bf2968ecf01a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a555a7bb0b95fdada86851b94508a51301dc1fa4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class GroupTypeSpecsRbacTest(base.BaseVolumeAdminTest):"},{"line_number":23,"context_line":"    _api_version \u003d 3"},{"line_number":24,"context_line":"    min_microversion \u003d \u00273.11\u0027"},{"line_number":25,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @decorators.idempotent_id(\u0027b2859734-00ad-4a22-88ee-541698e90d12\u0027)"},{"line_number":28,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_e0887e20","line":25,"range":{"start_line":24,"start_character":4,"end_line":25,"end_character":31},"in_reply_to":"3fa0c359_3a945444","updated":"2018-02-05 21:35:05.000000000","message":"It\u0027s the same microversion as group type:\n\n-\n https://github.com/openstack/cinder/blob/97207a045f2c1726a51f93599ae77df33a216552/cinder/api/microversions.py#L62\n- https://github.com/openstack/cinder/blob/97207a045f2c1726a51f93599ae77df33a216552/cinder/api/v3/group_types.py#L54\n- https://github.com/openstack/tempest/blob/1068f8b77556b0a8871915f6c80c91fd3f856f3c/tempest/api/volume/admin/test_group_type_specs.py#L23\n\nSo I think it\u0027s safe to say these lines are needed.","commit_id":"8c740bf946b74e36d8c239740f83bf2968ecf01a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ea2d1d5095ccc3cd568c19907f2244cfdd088c6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        delete_key \u003d \u0027key1\u0027"},{"line_number":98,"context_line":"        specs \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":99,"context_line":"        self.group_types_client.create_or_update_group_type_specs("},{"line_number":100,"context_line":"           group_type[\u0027id\u0027], specs )[\u0027group_specs\u0027]"},{"line_number":101,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":102,"context_line":"           self.group_types_client.delete_group_type_specs_item("},{"line_number":103,"context_line":"               group_type[\u0027id\u0027], \u0027key1\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_7fb16ee1","line":100,"range":{"start_line":100,"start_character":34,"end_line":100,"end_character":35},"updated":"2018-02-05 20:27:34.000000000","message":"Remove WS","commit_id":"8c740bf946b74e36d8c239740f83bf2968ecf01a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5c23ead934cde37f0e236652abb71a444be5a7a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FiberHome Telecommunication Technologies CO.,LTD"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_27f0b5c9","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":65},"updated":"2018-02-06 03:59:21.000000000","message":"2018 AT\u0026T Corporation","commit_id":"70a80302cc956c4f50480f132a4a59f52664ed12"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"579eb19638425780762c09583d09b8aa476333cf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # Show specified item of group type specs"},{"line_number":62,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":63,"context_line":"            self.group_types_client.show_group_type_specs_item("},{"line_number":64,"context_line":"                group_type[\u0027id\u0027], spec_keys[0])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u00272e706a4e-dec9-46bf-9426-1c5b6f3ce102\u0027)"},{"line_number":67,"context_line":"    @rbac_rule_validation.action("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa0c359_67c1ce54","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":46},"updated":"2018-02-06 17:30:35.000000000","message":"Nit: We can just replace this with \u0027key2\u0027.","commit_id":"0da98750248798a4e07a48f7e6ddb98ebd4467f5"}]}