)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"48150a6feb33276b8f16911ceaad2ee4d467345f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This fixes the Patrole test for"},{"line_number":10,"context_line":"\"volume_extension:extended_snapshot_attributes\" which is"},{"line_number":11,"context_line":"incorrectly being executed by a create test which is wrong according"},{"line_number":12,"context_line":"to [0]. Instead, the test should be executed for GET /snapshots"},{"line_number":13,"context_line":"and GET /snapshots/details. Further, the test should use soft"},{"line_number":14,"context_line":"or non-fatal authorization, which was recently fixed in Cinder [1]."},{"line_number":15,"context_line":"Finally, the tests should live in test_volumes_snapshots_rbac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df7087c5_ecf4e1d1","line":12,"range":{"start_line":12,"start_character":54,"end_line":12,"end_character":63},"updated":"2018-03-20 03:21:33.000000000","message":"/snapshots/{snapshot_id}\n\nThis is because of a Cinder bug I\u0027ve now fixed so this is deceiving so I will need to respin.","commit_id":"f6db7616ce981a09c32c25d6d8e1835ceb94eb6f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f438f14618f587518beda97d384482fb3043a0b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"volume_extension:extended_snapshot_attributes\" which is"},{"line_number":11,"context_line":"incorrectly being executed by a create test which is wrong according"},{"line_number":12,"context_line":"to [0]. Instead, the test should be executed for"},{"line_number":13,"context_line":"GET /snapshots/{snapshot_id} and GET /snapshots/details. Further, the"},{"line_number":14,"context_line":"test should use soft or non-fatal authorization, which was recently"},{"line_number":15,"context_line":"fixed in Cinder [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Finally, the tests should live in test_volumes_snapshots_rbac"},{"line_number":18,"context_line":"for the same reason the policy is listed under snapshots family"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_9491c055","line":15,"range":{"start_line":13,"start_character":57,"end_line":15,"end_character":20},"updated":"2018-03-26 03:18:11.000000000","message":"this is security issue and policy is being changed in backward incompatible way :)","commit_id":"6da23e69300207a8ede4bf476f971557e597216f"}],"patrole_tempest_plugin/tests/api/volume/test_volumes_snapshots_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c7b59d281d397b8e8cda2eddd1253090c33b17ed","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @rbac_rule_validation.action("},{"line_number":67,"context_line":"        service\u003d\"cinder\","},{"line_number":68,"context_line":"        rule\u003d\"volume_extension:extended_snapshot_attributes\")"},{"line_number":69,"context_line":"    def test_show_snapshot_with_extended_attributes(self):"},{"line_number":70,"context_line":"        \"\"\"List snapshots with extended attributes.\"\"\""},{"line_number":71,"context_line":"        expected_attrs \u003d (\u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":72,"context_line":"                          \u0027os-extended-snapshot-attributes:progress\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_63f4645c","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":51},"updated":"2018-03-20 00:40:11.000000000","message":"This is fixed in this PS: https://review.openstack.org/#/c/554071/\n\nThis policy affects show and list with details (current docs say list and list with details which is a bug).","commit_id":"f6db7616ce981a09c32c25d6d8e1835ceb94eb6f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5167114aee63207b9ca2321abc882aba9ce84c2b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        service\u003d\"cinder\","},{"line_number":68,"context_line":"        rule\u003d\"volume_extension:extended_snapshot_attributes\")"},{"line_number":69,"context_line":"    def test_show_snapshot_with_extended_attributes(self):"},{"line_number":70,"context_line":"        \"\"\"List snapshots with extended attributes.\"\"\""},{"line_number":71,"context_line":"        expected_attrs \u003d (\u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":72,"context_line":"                          \u0027os-extended-snapshot-attributes:progress\u0027)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_1aa079f4","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":25},"updated":"2018-03-26 05:31:43.000000000","message":"Show snapshot","commit_id":"6da23e69300207a8ede4bf476f971557e597216f"}]}
