)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c60637f7879bbc29b7e780ec5d6c5544bd0df9e8","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # Create network the interface will be attached to"},{"line_number":572,"context_line":"        network_name \u003d data_utils.rand_name(\u0027rbac-net-\u0027)"},{"line_number":573,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":574,"context_line":"        post_body[\u0027router:external\u0027] \u003d False"},{"line_number":575,"context_line":"        post_body[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_4176e1da","line":572,"range":{"start_line":572,"start_character":43,"end_line":572,"end_character":55},"updated":"2018-05-01 04:31:41.000000000","message":"nit: self.__class__.__name__ + \u0027-network\u0027","commit_id":"0c086d79600a9025cbfe14e6409751dfc3faca61"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"4f915b634dc7c74b10aa36ca465eb1e5492b4262","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # Create network the interface will be attached to"},{"line_number":572,"context_line":"        network_name \u003d data_utils.rand_name(\u0027rbac-net-\u0027)"},{"line_number":573,"context_line":"        post_body \u003d {\u0027name\u0027: network_name}"},{"line_number":574,"context_line":"        post_body[\u0027router:external\u0027] \u003d False"},{"line_number":575,"context_line":"        post_body[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_37d0c6c9","line":572,"range":{"start_line":572,"start_character":43,"end_line":572,"end_character":55},"in_reply_to":"9f6a8fd7_4176e1da","updated":"2018-05-01 15:23:19.000000000","message":"will update. thanks","commit_id":"0c086d79600a9025cbfe14e6409751dfc3faca61"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c60637f7879bbc29b7e780ec5d6c5544bd0df9e8","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            ip_version\u003d4)[\u0027subnet\u0027]"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    @classmethod"},{"line_number":587,"context_line":"    def resource_cleanup(cls):"},{"line_number":588,"context_line":"        # ports on the network need to be deleted before the network can"},{"line_number":589,"context_line":"        # be deleted"},{"line_number":590,"context_line":"        ports \u003d cls.ports_client.\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_816cf908","line":587,"updated":"2018-05-01 04:31:41.000000000","message":"The new way to do this is to use addClassResourceCleanup: https://github.com/openstack/tempest/blob/34b5503592ae2e94bad656324d656335953c563f/tempest/test.py#L565\n\nShould be used the same way addCleanup is used except is resource_setup immediately after you create the resource.","commit_id":"0c086d79600a9025cbfe14e6409751dfc3faca61"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"4f915b634dc7c74b10aa36ca465eb1e5492b4262","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            ip_version\u003d4)[\u0027subnet\u0027]"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    @classmethod"},{"line_number":587,"context_line":"    def resource_cleanup(cls):"},{"line_number":588,"context_line":"        # ports on the network need to be deleted before the network can"},{"line_number":589,"context_line":"        # be deleted"},{"line_number":590,"context_line":"        ports \u003d cls.ports_client.\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_25e650ea","line":587,"in_reply_to":"9f6a8fd7_816cf908","updated":"2018-05-01 15:23:19.000000000","message":"fixed in next PS. thank you","commit_id":"0c086d79600a9025cbfe14e6409751dfc3faca61"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"24acfe4e8a0e0b3bb16c21a43b93f0db7962ebc7","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        cls.network \u003d \\"},{"line_number":587,"context_line":"            cls.networks_client.create_network(**post_body)[\u0027network\u0027]"},{"line_number":588,"context_line":"        cls.addClassResourceCleanup("},{"line_number":589,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":590,"context_line":"            cls.networks_client.delete_network, cls.network[\u0027id\u0027])"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # Create subnet for network"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c41aed15","line":589,"range":{"start_line":589,"start_character":11,"end_line":589,"end_character":52},"updated":"2018-05-01 21:53:17.000000000","message":"Probably don\u0027t need this call as we don\u0027t delete the network just the attachment","commit_id":"aee7dd54608818d9d3be37a613dabeb5d5ca49a8"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"126ce20c3706eef98c08e4a3b1d8fa0316ad6f6a","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        cls.network \u003d \\"},{"line_number":587,"context_line":"            cls.networks_client.create_network(**post_body)[\u0027network\u0027]"},{"line_number":588,"context_line":"        cls.addClassResourceCleanup("},{"line_number":589,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":590,"context_line":"            cls.networks_client.delete_network, cls.network[\u0027id\u0027])"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # Create subnet for network"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_179821be","line":589,"range":{"start_line":589,"start_character":11,"end_line":589,"end_character":52},"in_reply_to":"9f6a8fd7_c41aed15","updated":"2018-05-08 17:44:47.000000000","message":"you are correct, I tested and it isn\u0027t needed.","commit_id":"aee7dd54608818d9d3be37a613dabeb5d5ca49a8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"24acfe4e8a0e0b3bb16c21a43b93f0db7962ebc7","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            cidr\u003dcls.cidr,"},{"line_number":597,"context_line":"            ip_version\u003d4)[\u0027subnet\u0027]"},{"line_number":598,"context_line":"        cls.addClassResourceCleanup("},{"line_number":599,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":600,"context_line":"            cls.subnets_client.delete_subnet, cls.subnet[\u0027id\u0027])"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        # ports on the network need to be deleted before the network can"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_84d2b533","line":599,"range":{"start_line":599,"start_character":12,"end_line":599,"end_character":52},"updated":"2018-05-01 21:53:17.000000000","message":"Ditto","commit_id":"aee7dd54608818d9d3be37a613dabeb5d5ca49a8"}]}