)]}'
{"patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"3dbe39b9f6a6d7e3bcad12b5579ca8fa0ebaca0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_fdde240f","updated":"2018-05-31 17:09:33.000000000","message":"I don\u0027t see this granularity in upstream cinder: https://github.com/openstack/cinder/blob/master/cinder/policies/volume_type.py","commit_id":"21f2f5446f441c02010c4931125e012620226509"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"94ed26f8dc87f54ac93ae01726b0d030bfe41f66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_733d65c2","in_reply_to":"5f7c97a3_58708640","updated":"2018-05-31 18:20:31.000000000","message":"I don\u0027t see the granularity in Ocata either: https://github.com/openstack/cinder/blob/stable/ocata/etc/cinder/policy.json#L39","commit_id":"21f2f5446f441c02010c4931125e012620226509"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"108ecc563f08263b45978f3d2f6b03084c8d5d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_ee1bc87d","in_reply_to":"5f7c97a3_733d65c2","updated":"2018-05-31 20:22:28.000000000","message":"It may not be in policy.json, but my log file indicates that the create. update, and delete rule/policy is being hit for each of the corresponding action.  I have just submit the cinder upstream changes https://review.openstack.org/#/c/571563/1 for the same.  If this is not what we want, please suggest the way forward.","commit_id":"21f2f5446f441c02010c4931125e012620226509"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"4d14c7ad9f1f53072af6e3e56840895ce78316fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_58708640","in_reply_to":"5f7c97a3_7899c2c1","updated":"2018-05-31 17:53:40.000000000","message":"In Ocata, the create, update, delete actions are indeed hitting the granular rules. I am not sure why it would make sense in master branch with one volume_extension:volume_type_encryption rule applies to all CRUD actions.  Can you give an example of policy feature flags implementation if this really need to be done that way?","commit_id":"21f2f5446f441c02010c4931125e012620226509"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"1cb6ed57320c694c19cb771b998ae374bb8f5661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_89948e8c","in_reply_to":"5f7c97a3_ee1bc87d","updated":"2018-05-31 20:33:44.000000000","message":"It is because we did the granularity downstream. Thanks for making the commit to upstream cinder as that has been on our todo list for a while now. \n\nAs Felipe has mentioned please break down this commit especially now that there is a dependency on code being merged in cinder.","commit_id":"21f2f5446f441c02010c4931125e012620226509"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8caf81a86662f41fca6610bb04b401f624fcaaad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_7899c2c1","in_reply_to":"5f7c97a3_fdde240f","updated":"2018-05-31 17:35:21.000000000","message":"Even if it were there, we would need to introduce policy feature flags assuming the granularity had been added during the last cycle or so. So that this could work with n-1 and n-2.","commit_id":"21f2f5446f441c02010c4931125e012620226509"}],"patrole_tempest_plugin/tests/api/volume/test_volume_basic_crud_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c5726c4859bda932508124dd00878059958f8f6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":70,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":71,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":72,"context_line":"            self.volumes_client.list_volumes(detail\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_06991a78","side":"PARENT","line":72,"updated":"2018-06-04 15:05:56.000000000","message":"Docs say this is enforced here: https://github.com/openstack/cinder/blob/953781e3af15832078b4cfb5eac0a8054c67ea75/cinder/policies/volume_metadata.py#L90\n\nThat being said, this is being handled incorrectly. See this: https://github.com/openstack/cinder/blob/cc01f2e041b252b25f5fb14be5ad0360aa1ab59d/cinder/api/contrib/volume_image_metadata.py#L82\n\nWe need to add this:\n    \n    with self.rbac_utils.override_role(self):\n        resp \u003d self.volumes_client.list_volumes(detail\u003dTrue)\n    if \u0027volume_image_metadata\u0027 not in resp[\u0027volumes\u0027][0]:\n        # raise appropriate exception in rbac_exceptions\n    # Would be better to assert that the image metadata is what we\n    # expect, i.e. what we created the volume with.","commit_id":"f1ba5ae05ce075b30b2824f2631caa6ea2357f9b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c49ca97b286a58033c60b12a0caccfb9d7a39aa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":70,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":71,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":72,"context_line":"            self.volumes_client.list_volumes(detail\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a68ce62e","side":"PARENT","line":72,"in_reply_to":"5f7c97a3_06991a78","updated":"2018-06-04 15:06:47.000000000","message":"That is, I meant this is not currently being handled correctly. Needs refactoring. But shouldn\u0027t delete this.","commit_id":"f1ba5ae05ce075b30b2824f2631caa6ea2357f9b"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"f28aa061948cbc5ffdaa88bc2b20aad2c7de86bb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":70,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":71,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":72,"context_line":"            self.volumes_client.list_volumes(detail\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_57381eed","side":"PARENT","line":72,"in_reply_to":"5f7c97a3_06991a78","updated":"2018-06-04 17:47:26.000000000","message":"The problem is this the resp will not have a volume_image_metadata when the setup simply just create_volume(). In test_volume_metadata_rbac.py, the test_list_volumes_details_image_metadata test case has to do an update to volume image metadata before the volume_image_metadata attribute created.  Basically, the latter test case is testing the exact same thing to me.  Therefore, I am deleting this one.","commit_id":"f1ba5ae05ce075b30b2824f2631caa6ea2357f9b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2871da5dccc787837474fb4895ef53a6e3c2335e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00273d48ca91-f02b-4616-a69d-4a8b296c8529\u0027)"},{"line_number":70,"context_line":"    def test_volume_list_image_metadata(self):"},{"line_number":71,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":72,"context_line":"            self.volumes_client.list_volumes(detail\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_92cfa4b2","side":"PARENT","line":72,"in_reply_to":"5f7c97a3_57381eed","updated":"2018-06-04 17:56:24.000000000","message":"Ok, I agree this should be removed because it\u0027s the same test as this: https://github.com/openstack/patrole/blob/9ae705db1631172db370c2be48aeebc4f9a0b085/patrole_tempest_plugin/tests/api/volume/test_volume_metadata_rbac.py#L103","commit_id":"f1ba5ae05ce075b30b2824f2631caa6ea2357f9b"}]}
